From patchwork Fri Jun 15 18:23:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Lingshan X-Patchwork-Id: 10467297 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4094B601C2 for ; Fri, 15 Jun 2018 18:25:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F3EE28E3B for ; Fri, 15 Jun 2018 18:25:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23CA928E40; Fri, 15 Jun 2018 18:25:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B614F28E3B for ; Fri, 15 Jun 2018 18:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756298AbeFOSZP (ORCPT ); Fri, 15 Jun 2018 14:25:15 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:49434 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756352AbeFOSZO (ORCPT ); Fri, 15 Jun 2018 14:25:14 -0400 Received: from vstart.localdomain (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Fri, 15 Jun 2018 12:25:04 -0600 From: Zhu Lingshan To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, nab@linux-iscsi.org, mchristi@redhat.com, martin.petersen@oracle.com Cc: hare@suse.de, lduncan@suse.com, ddiss@suse.de, lszhu@suse.de, Zhu Lingshan Subject: [PATCH 21/33] TCMU PR: add a func to update PR info on TCMU dev Date: Sat, 16 Jun 2018 02:23:30 +0800 Message-Id: <20180615182342.6239-21-lszhu@suse.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180615182342.6239-1-lszhu@suse.com> References: <20180615182342.6239-1-lszhu@suse.com> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch added a function tcmu_pr_info_replace() which can help update Persistent Reservation information stored on a TCMU device. It will generate a new string based on the provided struct tcmu_pr_info struct, then write it to the device.For example, If we are using RBD, it will update PR info to RBD meatada. Signed-off-by: Zhu Lingshan --- drivers/target/target_core_user.c | 43 +++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 4b426a9061b1..559e0d40d63b 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -111,6 +111,8 @@ /* don't allow encoded PR info to exceed 8K */ #define TCMU_PR_INFO_XATTR_MAX_SIZE 8192 +#define TCMU_PR_REG_MAX_RETRIES 5 + #define TCMU_PR_INFO_XATTR_ENCODED_SCSI2_RSV_MAXLEN \ (TCMU_PR_IT_NEXUS_MAXLEN + sizeof("\n")) @@ -2648,6 +2650,47 @@ tcmu_execute_pr_register_existing(struct tcmu_pr_info *pr_info, return ret; } +static int tcmu_pr_info_replace(struct tcmu_dev *udev, + char *pr_xattr_old, int pr_xattr_len_old, + struct tcmu_pr_info *pr_info_new) +{ + int rc; + char *pr_xattr_new = NULL; + int pr_xattr_len_new = 0; + + WARN_ON(!pr_xattr_old || !pr_info_new); + + /* bump seqnum prior to xattr write. Not rolled back on failure */ + pr_info_new->seq++; + rc = tcmu_pr_info_encode(pr_info_new, &pr_xattr_new, + &pr_xattr_len_new); + + if (rc) { + pr_err("failed to encode PR xattr: %d\n", rc); + return rc; + } + + if (pr_xattr_len_new > TCMU_PR_INFO_XATTR_MAX_SIZE) { + pr_err("unable to store oversize (%d) PR info: %s\n", + pr_xattr_len_new, pr_xattr_new); + rc = -E2BIG; + goto err_xattr_new_free; + } + + rc = tcmu_set_dev_pr_info(udev, pr_xattr_new); + if (rc) { + pr_err("failed to set PR xattr: %d\n", rc); + goto err_xattr_new_free; + } + + pr_debug("successfully replaced PR info\n"); + rc = 0; +err_xattr_new_free: + kfree(pr_xattr_new); + + return 0; +} + static int tcmu_configure_device(struct se_device *dev) { struct tcmu_dev *udev = TCMU_DEV(dev);