diff mbox

[16/20] target/tcm_loop: Avoid that static checkers warn about dead code

Message ID 20180622215307.8758-17-bart.vanassche@wdc.com (mailing list archive)
State New, archived
Headers show

Commit Message

Bart Van Assche June 22, 2018, 9:53 p.m. UTC
The code under the "release:" label can only be reached after se_cmd
has been set to a non-NULL value. Hence remove the if (se_cmd) test.
Keep the else-part since calling transport_generic_free_cmd() is not
necessary for a command that has not been submitted to the core.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 4d3895d5ea43 ("target/tcm_loop: Merge struct tcm_loop_cmd and struct tcm_loop_tmr")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
 drivers/target/loopback/tcm_loop.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff mbox


diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 4c8a97711291..b2e7ff50ff61 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -239,10 +239,7 @@  static int tcm_loop_issue_tmr(struct tcm_loop_tpg *tl_tpg,
 	return ret;
-	if (se_cmd)
-		transport_generic_free_cmd(se_cmd, 0);
-	else
-		kmem_cache_free(tcm_loop_cmd_cache, tl_cmd);
+	kmem_cache_free(tcm_loop_cmd_cache, tl_cmd);
 	goto out;