From patchwork Tue Oct 9 11:37:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Disseldorp X-Patchwork-Id: 10632371 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 230C23CF1 for ; Tue, 9 Oct 2018 11:37:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FE522884A for ; Tue, 9 Oct 2018 11:37:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0471C288F4; Tue, 9 Oct 2018 11:37:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B612F28C40 for ; Tue, 9 Oct 2018 11:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbeJISxw (ORCPT ); Tue, 9 Oct 2018 14:53:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:52926 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726439AbeJISxv (ORCPT ); Tue, 9 Oct 2018 14:53:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 89C6DB011 for ; Tue, 9 Oct 2018 11:37:17 +0000 (UTC) From: David Disseldorp To: target-devel@vger.kernel.org Cc: David Disseldorp Subject: [PATCH 4/4] target: log NOP ping timeouts as errors Date: Tue, 9 Oct 2018 13:37:06 +0200 Message-Id: <20181009113706.27696-5-ddiss@suse.de> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20181009113706.27696-1-ddiss@suse.de> References: <20181009113706.27696-1-ddiss@suse.de> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Events resulting in connection outages like this should be logged as errors. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c index 49be1e41290c..b20e87f0795f 100644 --- a/drivers/target/iscsi/iscsi_target_util.c +++ b/drivers/target/iscsi/iscsi_target_util.c @@ -925,7 +925,7 @@ void iscsit_handle_nopin_response_timeout(struct timer_list *t) return; } - pr_debug("Did not receive response to NOPIN on CID: %hu on" + pr_err("Did not receive response to NOPIN on CID: %hu on" " SID: %u, failing connection.\n", conn->cid, conn->sess->sid); conn->nopin_response_timer_flags &= ~ISCSI_TF_RUNNING;