From patchwork Tue Apr 2 19:58:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10882271 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 82033139A for ; Tue, 2 Apr 2019 19:58:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C2B22875F for ; Tue, 2 Apr 2019 19:58:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 604D1288D7; Tue, 2 Apr 2019 19:58:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 082BA288D3 for ; Tue, 2 Apr 2019 19:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726384AbfDBT6c (ORCPT ); Tue, 2 Apr 2019 15:58:32 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42060 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbfDBT6c (ORCPT ); Tue, 2 Apr 2019 15:58:32 -0400 Received: by mail-pl1-f196.google.com with SMTP id cv12so6789414plb.9 for ; Tue, 02 Apr 2019 12:58:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sc/tDFFX599Yj5eKYbgNuAMSFnZm3pcl+ODaixMtr3k=; b=qm8SN08rXO6XoKaLIxZzUDMYlZHM27fcrlCtajF9+vjqIFg/V+x9PU8Wiz3Rte9lsp /jI2enjF3pCVFS3zMdGUsA4qaSyJmkwLfxkyM/6URB9bGJwxATA43qa0wuU8coLCIBeD Lfc8Do8rMvzhk5ZQL5twYTOplvlhGQSHDJt9e9xHA1FZ0pRbx52ZQLizaFIhX3W/HAw9 /lSB8MN+Z2I8UZR5Caoozq3GeXWmJLz+yoAcOc8LIRqAfoWZS3Lj30l08xeyEPJD/gX/ HoOCsJL05o0lECOPuJua28Uht9T1LK+sNQUeWSOU4IMwoO3Ba4HRUrC/j95ypb1iFpje OweQ== X-Gm-Message-State: APjAAAVcnvVF6wzwrbehL694OhOC237CHPvc410c66Ax4y84X8OmPmfj QV6LxdAPdeQ0lPKKiPp3h8kaDRjOmEI= X-Google-Smtp-Source: APXvYqwvqXtF09LSIrxI3erDE3KCZCzLh+QX64WUcpZmsSurkuiqdwMZuClZf3BGCXZDaM9XKXltOQ== X-Received: by 2002:a17:902:aa91:: with SMTP id d17mr7755473plr.43.1554235111684; Tue, 02 Apr 2019 12:58:31 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id o5sm49055490pfa.135.2019.04.02.12.58.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 12:58:30 -0700 (PDT) From: Bart Van Assche To: "Martin K . Petersen" Cc: Mike Christie , Christoph Hellwig , target-devel@vger.kernel.org, Bart Van Assche , Mike Christie , Hannes Reinecke , Nicholas Bellinger Subject: [PATCH 04/11] target/core: Remove a set-but-not-used member variable from the XCOPY implementation Date: Tue, 2 Apr 2019 12:58:08 -0700 Message-Id: <20190402195815.254796-5-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190402195815.254796-1-bvanassche@acm.org> References: <20190402195815.254796-1-bvanassche@acm.org> MIME-Version: 1.0 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch does not change any functionality. Cc: Mike Christie Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Nicholas Bellinger Signed-off-by: Bart Van Assche --- drivers/target/target_core_xcopy.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c index 9be1418e919f..d97be766e4ac 100644 --- a/drivers/target/target_core_xcopy.c +++ b/drivers/target/target_core_xcopy.c @@ -389,7 +389,6 @@ static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd, */ struct xcopy_pt_cmd { - bool remote_port; struct se_cmd se_cmd; struct completion xpt_passthrough_sem; unsigned char sense_buffer[TRANSPORT_SENSE_BUFFER]; @@ -520,9 +519,7 @@ static void target_xcopy_setup_pt_port( * when CDB is received on local source port, and READs blocks to * WRITE on remote destination port. */ - if (remote_port) { - xpt_cmd->remote_port = remote_port; - } else { + if (!remote_port) { pt_cmd->se_lun = ec_cmd->se_lun; pt_cmd->se_dev = ec_cmd->se_dev; @@ -539,9 +536,7 @@ static void target_xcopy_setup_pt_port( * blocks from the remote source port to WRITE on local * destination port. */ - if (remote_port) { - xpt_cmd->remote_port = remote_port; - } else { + if (!remote_port) { pt_cmd->se_lun = ec_cmd->se_lun; pt_cmd->se_dev = ec_cmd->se_dev;