| Message ID | 20240204-bus_cleanup-target-v1-1-96106936c4ab@marliere.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4ad9465365378d696545a337c4b1a28277de84d7 |
| Headers | show |
| Series | scsi: tcm_loop: make tcm_loop_lld_bus const | expand |
On Sun, Feb 04, 2024 at 05:48:26PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the tcm_loop_lld_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ricardo, > Now that the driver core can properly handle constant struct bus_type, > move the tcm_loop_lld_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. Applied to 6.9/scsi-staging, thanks!
On Sun, 04 Feb 2024 17:48:26 -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the tcm_loop_lld_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Applied to 6.9/scsi-queue, thanks! [1/1] scsi: tcm_loop: make tcm_loop_lld_bus const https://git.kernel.org/mkp/scsi/c/4ad946536537
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 8e4035ff3674..761c511aea07 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -83,7 +83,7 @@ static int tcm_loop_show_info(struct seq_file *m, struct Scsi_Host *host) static int tcm_loop_driver_probe(struct device *); static void tcm_loop_driver_remove(struct device *); -static struct bus_type tcm_loop_lld_bus = { +static const struct bus_type tcm_loop_lld_bus = { .name = "tcm_loop_bus", .probe = tcm_loop_driver_probe, .remove = tcm_loop_driver_remove,
Now that the driver core can properly handle constant struct bus_type, move the tcm_loop_lld_bus variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/target/loopback/tcm_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 3f90ac7138edb995b4312221647b58afcc15ec06 change-id: 20240204-bus_cleanup-target-5393cf09c658 Best regards,