From patchwork Tue Dec 12 21:46:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10108309 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F043F602B3 for ; Tue, 12 Dec 2017 21:47:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E21D6284DE for ; Tue, 12 Dec 2017 21:47:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D6C1528B76; Tue, 12 Dec 2017 21:47:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 925E0284DE for ; Tue, 12 Dec 2017 21:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbdLLVr0 (ORCPT ); Tue, 12 Dec 2017 16:47:26 -0500 Received: from mout.web.de ([212.227.15.4]:58560 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbdLLVrY (ORCPT ); Tue, 12 Dec 2017 16:47:24 -0500 Received: from [192.168.1.3] ([77.181.137.123]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MQeqb-1ebCiR31dF-00U67p; Tue, 12 Dec 2017 22:46:47 +0100 Subject: [PATCH 4/8] target/iscsi: Delete an unnecessary variable initialisation in iscsit_allocate_ooo_cmdsn() From: SF Markus Elfring To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, Al Viro , Arun Easi , Bart Van Assche , Dan Carpenter , David Disseldorp , Hannes Reinecke , Ingo Molnar , "Jason A. Donenfeld" , Jiang Yi , Kees Cook , "Nicholas A. Bellinger" , Russell King , Tang Wenji , Theodore Ts'o , Varun Prakash Cc: LKML , kernel-janitors@vger.kernel.org References: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> Message-ID: <3db75482-2817-46b1-95e5-ace7342e2a90@users.sourceforge.net> Date: Tue, 12 Dec 2017 22:46:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:nte7RzK1/qkma6n2bwwTVPLXIC4RsF34z3r67V30+3jsqThL/YC TH/HwNQu8u+ws3oFLNNo+PHeZyxuxM1ikFuzxO1KiyEOANMylm/OdSVKGXLapl/hhvGaQFT yywdf8Eg9OPsStC1nCpiuYSY5z8q+ALxNg1afya4Y88jabmLUu69Nk1UQKOywUv1vmLbTGV z1GfVScEtP+c6hVaMWbjg== X-UI-Out-Filterresults: notjunk:1; V01:K0:mvg/g9MG0u4=:FrJksnzg6tMcL76MyzLKpa 8keVmP0M4bfR8MUm+Xlqi3dti5UEDdGDaWlJqTpS3wX0M9QkaSugTMAArclZCzqjdkwfoZwkD dOYiWuZcytZlwq4sImLxbJGrpwXNNxKGUmNR9LeX+zI7qYAJw0Ef4bjv9oRmI3twS7Y6M03fg HEEAUuabBbXMkrbcEXto7asULZTKlIgtdJUcHkJGIkvtI9M81KwkTswABrikCwFZVFd4jD7E2 m4dElcNtPNq1ps+KNh0VizUWVSjy/xrb2rkm/dnaEymdCgLQXfeWxQSKjuBQEifxxVwPj0gCg lzQQxKec4PeT+M2jZYjL7b0eQqioW00vRssLVaJaHO+7+rq2OJ1Ly0+Xj6tfIjbH6+LH3ZkYA ufTrL/tyB9AqYt+l2H84Wa8/lV7ikWxzRv3piKyphyjl9cgCL2yZyLMICLunt/zgkrLKdUrFv wFrXwVNaWHMCIz+yOgMwdfhbIFxNZfmc0O6DqcvHVJ+og51PEuhVeOw1QioNWc0IPgG0bwU6j osYJUwW8QbV9FozoTmAb1YirKHYJYnSf6b/P58TiqbJy5D84D2TgORzzrwJK1ZThZ1Io2QSlu vYimCHn4J/vFjSac65RzaQxm0cLdvIN6tDV0usGSviKp9ggdT/z9AIAyceHGKs6lMGyE8w36R Pxlhu6hollizE81xh63iqowGczztOIZUjpMETvLJDRlKjgDvt40mLUMcLZRwzQ1DtXdqBoblW zorLIIoljahA0QHHiQcYZZ2H7VcYSQOMl92IgShER74NfP9oteEb98H0Isx0V2oQRx0/hMbs7 RHEHNUYAxU0HdcolszHS4J51OvzMNxFlYbmLddOxgenF2rO9ZU= Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 12 Dec 2017 21:13:49 +0100 The local variable "ooo_cmdsn" will be reassigned by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/target/iscsi/iscsi_target_erl1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index ff3e08b6d4e1..c4c550128161 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c @@ -782,7 +782,7 @@ int iscsit_recover_dataout_sequence( static struct iscsi_ooo_cmdsn *iscsit_allocate_ooo_cmdsn(void) { - struct iscsi_ooo_cmdsn *ooo_cmdsn = NULL; + struct iscsi_ooo_cmdsn *ooo_cmdsn; ooo_cmdsn = kmem_cache_zalloc(lio_ooo_cache, GFP_ATOMIC); if (!ooo_cmdsn)