From patchwork Tue Dec 12 21:49:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10108317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2DACD602B3 for ; Tue, 12 Dec 2017 21:49:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CA9728E9D for ; Tue, 12 Dec 2017 21:49:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CF1D28EC4; Tue, 12 Dec 2017 21:49:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9C9928E9D for ; Tue, 12 Dec 2017 21:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598AbdLLVtp (ORCPT ); Tue, 12 Dec 2017 16:49:45 -0500 Received: from mout.web.de ([212.227.15.3]:62760 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbdLLVtn (ORCPT ); Tue, 12 Dec 2017 16:49:43 -0500 Received: from [192.168.1.3] ([77.181.137.123]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LrKEG-1fAGOA1m96-0133XM; Tue, 12 Dec 2017 22:49:10 +0100 Subject: [PATCH 6/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_create_default_params() From: SF Markus Elfring To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, Al Viro , Arun Easi , Bart Van Assche , Dan Carpenter , David Disseldorp , Hannes Reinecke , Ingo Molnar , "Jason A. Donenfeld" , Jiang Yi , Kees Cook , "Nicholas A. Bellinger" , Russell King , Tang Wenji , Theodore Ts'o , Varun Prakash Cc: LKML , kernel-janitors@vger.kernel.org References: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> Message-ID: <734e9a91-f127-c454-47ca-ba33f153758f@users.sourceforge.net> Date: Tue, 12 Dec 2017 22:49:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:PM4E9L1+8Wrk6LERU3lcQXi3VECdUOJv9HMj15EAq+2i+rNH43/ pNiwr7R93ei/NfGLRDgECXKJGHU/1aj3+teDuZVNBL2udL/EfOrWGAu1qefm4juKd0L+jf4 fTd2vU/krtlqgomKUADsnvLs9F7gVpo+fEI0bHPbkyfckIqE7agFGienjcGicO5dpIG5XNl V+4TfZPhnEj6Ky/B8RIlQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:ITxzDCIhx3Q=:DloUtp9pTVlFEd/om+IPWI 6sXdGIfL7FPKWiFHIQ1B6tbYIoZ4ZtUV3nsRtcEBKc5rm3YjnnRspCV4dyRTov57krLRHOLVG GEjFVI+mOtGEuq+PXyb48PAGNTSfj+yu/oKIhS7iYz0q28t5nDTLnKmXMecBs3JgkjkbMOPO3 N3twbMTlpqUepHG4EGEjrFrqe/96iXsCs3KYJcrms9+UT5xLo6a7udBIDioMfO7tUb5GIiBOK xDJMw9qDaP4hb9SeFOXLrb++2+UJN6bGui8rtHLRFUDYZ+RIHSAr5pQ7/mJOVuFY9F0ZpjwQX 9aYDxqLZPHZ6lMERXmPb/50YXCO8Dd51g3e69GjFioHDxGu0vT1EStGggbbuW+jfHLgUTKrfE I58u4BpRsap8xpMUSJTNxIJJ8wtx2ZNWjo6eURTY6W2gbc4MBoemKnnVJe5sUQudud2y74J51 bkwXR/kIQAvt4/i8PKT21lysSCDOGCya56b5oJHyTLbveunMFtkvaz99mn9/3bzWdofEn0dml 4uO8kUh7oe2w0NWOvFBdqY+ZpymxV+4gAzfgTg9mNKMSegZToJ9Hi01KirB2PVm6dBiKUdwm5 X9W3WOC0SAXuyenjjEebqroMOExrhi1Gi0xaLMK6jyaL6fPRi/CtzV8u02185voclPnMTjlAo D8JtjoTjhyM4LGH1tU67wkIyZQPeELTHLLesg33lmjkq+CJQNtN2nWJpHlysfmzgZHFqLM0Cx D1YjiH8dX3s+2xiDPbUMDQbt2JITgMaPVyf9XaBwTZs5JbKJmhpQtzMM7LPLZ3vmhms5XBaHJ fHuicWd3WQ6PzK1Jp3eluGD2Sx90XsAuENwDG5m45GoaGRos3A= Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 12 Dec 2017 21:18:39 +0100 The variable "param" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/target/iscsi/iscsi_target_parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c index 25a3a9550488..151269b8816d 100644 --- a/drivers/target/iscsi/iscsi_target_parameters.c +++ b/drivers/target/iscsi/iscsi_target_parameters.c @@ -196,7 +196,7 @@ static struct iscsi_param *iscsi_set_default_param(struct iscsi_param_list *para /* #warning Add extension keys */ int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr) { - struct iscsi_param *param = NULL; + struct iscsi_param *param; struct iscsi_param_list *pl; pl = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL);