| Message ID | 1479895454-15076-4-git-send-email-tomas.winkler@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > The tpm stack uses pdev name convention for the parent device. > Fix that also in tpm_chip_alloc(). Usually I'm not too fond for minor style fixes but in this case it improves the clarity. Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko > > Fixes: 3897cd9c8d1d ("tpm: Split out the devm stuff from tpmm_chip_alloc")' > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > --- > V2: resend > drivers/char/tpm/tpm-chip.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > index 7a4869151d3b..eefdc809faf0 100644 > --- a/drivers/char/tpm/tpm-chip.c > +++ b/drivers/char/tpm/tpm-chip.c > @@ -141,7 +141,7 @@ static void tpm_dev_release(struct device *dev) > * Allocates a new struct tpm_chip instance and assigns a free > * device number for it. Must be paired with put_device(&chip->dev). > */ > -struct tpm_chip *tpm_chip_alloc(struct device *dev, > +struct tpm_chip *tpm_chip_alloc(struct device *pdev, > const struct tpm_class_ops *ops) > { > struct tpm_chip *chip; > @@ -160,7 +160,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *dev, > rc = idr_alloc(&dev_nums_idr, NULL, 0, TPM_NUM_DEVICES, GFP_KERNEL); > mutex_unlock(&idr_lock); > if (rc < 0) { > - dev_err(dev, "No available tpm device numbers\n"); > + dev_err(pdev, "No available tpm device numbers\n"); > kfree(chip); > return ERR_PTR(rc); > } > @@ -170,7 +170,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *dev, > > chip->dev.class = tpm_class; > chip->dev.release = tpm_dev_release; > - chip->dev.parent = dev; > + chip->dev.parent = pdev; > chip->dev.groups = chip->groups; > > if (chip->dev_num == 0) > @@ -182,7 +182,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *dev, > if (rc) > goto out; > > - if (!dev) > + if (!pdev) > chip->flags |= TPM_CHIP_FLAG_VIRTUAL; > > cdev_init(&chip->cdev, &tpm_fops); > -- > 2.7.4 > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
On Sat, Dec 03, 2016 at 05:35:30PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > > The tpm stack uses pdev name convention for the parent device. > > Fix that also in tpm_chip_alloc(). > > Usually I'm not too fond for minor style fixes but in this case it > improves the clarity. > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> ... in the sense that the changes do not break the compilation and do not produce sparse or cocciheck errors. I guess that should be enough for these documentation changes. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index 7a4869151d3b..eefdc809faf0 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -141,7 +141,7 @@ static void tpm_dev_release(struct device *dev) * Allocates a new struct tpm_chip instance and assigns a free * device number for it. Must be paired with put_device(&chip->dev). */ -struct tpm_chip *tpm_chip_alloc(struct device *dev, +struct tpm_chip *tpm_chip_alloc(struct device *pdev, const struct tpm_class_ops *ops) { struct tpm_chip *chip; @@ -160,7 +160,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *dev, rc = idr_alloc(&dev_nums_idr, NULL, 0, TPM_NUM_DEVICES, GFP_KERNEL); mutex_unlock(&idr_lock); if (rc < 0) { - dev_err(dev, "No available tpm device numbers\n"); + dev_err(pdev, "No available tpm device numbers\n"); kfree(chip); return ERR_PTR(rc); } @@ -170,7 +170,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *dev, chip->dev.class = tpm_class; chip->dev.release = tpm_dev_release; - chip->dev.parent = dev; + chip->dev.parent = pdev; chip->dev.groups = chip->groups; if (chip->dev_num == 0) @@ -182,7 +182,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *dev, if (rc) goto out; - if (!dev) + if (!pdev) chip->flags |= TPM_CHIP_FLAG_VIRTUAL; cdev_init(&chip->cdev, &tpm_fops);
The tpm stack uses pdev name convention for the parent device. Fix that also in tpm_chip_alloc(). Fixes: 3897cd9c8d1d ("tpm: Split out the devm stuff from tpmm_chip_alloc")' Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> --- V2: resend drivers/char/tpm/tpm-chip.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)