From patchwork Tue Dec 16 21:31:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jarkko Sakkinen X-Patchwork-Id: 5503581 Return-Path: X-Original-To: patchwork-tpmdd-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 72774BEEA8 for ; Tue, 16 Dec 2014 21:31:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2E8EB209DC for ; Tue, 16 Dec 2014 21:31:44 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0628209E5 for ; Tue, 16 Dec 2014 21:31:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Y0ziW-0005WN-OV; Tue, 16 Dec 2014 21:31:40 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Y0ziV-0005WF-E3; Tue, 16 Dec 2014 21:31:39 +0000 X-ACL-Warn: Received: from mga01.intel.com ([192.55.52.88]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Y0ziU-0001K9-44; Tue, 16 Dec 2014 21:31:39 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 16 Dec 2014 13:31:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,589,1413270000"; d="scan'208,223";a="648732255" Received: from ddkotela-mobl.gar.corp.intel.com (HELO localhost) ([10.252.123.8]) by fmsmga002.fm.intel.com with ESMTP; 16 Dec 2014 13:31:25 -0800 Date: Tue, 16 Dec 2014 23:31:24 +0200 From: Jarkko Sakkinen To: Peter Huewe Message-ID: <20141216213123.GA21710@intel.com> References: <1418413600-5400-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20141215201757.GA27923@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.0 (/) X-Headers-End: 1Y0ziU-0001K9-44 Cc: christophe.ricard@gmail.com, linux-api@vger.kernel.org, Ashley Lai , linux-kernel@vger.kernel.org, josh@joshtriplett.org, tpmdd-devel@lists.sourceforge.net, jason.gunthorpe@obsidianresearch.com, trousers-tech@lists.sourceforge.net Subject: Re: [tpmdd-devel] [PATCH v10 0/8] TPM 2.0 support X-BeenThere: tpmdd-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Tpm Device Driver maintainance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces@lists.sourceforge.net X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, HK_RANDOM_ENVFROM, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Dec 16, 2014 at 10:19:26PM +0100, Peter Huewe wrote: > > So, what do you think? Are we now settled with this? > > Meh... > It does not recognize my tpm20 with force=1 :( :( :( > Probably since I don't have a machine with bios integration -> no tpm startup, > and your startup is returned with RC_SIZE :( I don't know why it worked for me. My dTPM2 does not export ACPI device but I guess firmware does execute startup. I root caused this quickly and attached patch here. Does that resolve your issue? >  rmmod tpm; modprobe tpm_tis force=1 ; dmesg > modprobe: ERROR: could not insert 'tpm_tis': No such device > [ 77.744050] tpm_tis tpm_tis: 2.0 TPM (device-id 0x1A, rev-id 16) > [ 77.816049] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 77.888043] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 77.960043] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 77.960057] genirq: Flags mismatch irq 6. 00000080 (tpm0) vs. 00000000 (floppy) > [ 77.960067] tpm_tis tpm_tis: Unable to request irq: 6 for probe > [ 77.960073] genirq: Flags mismatch irq 7. 00000080 (tpm0) vs. 00000000 (parport0) > [ 77.960077] tpm_tis tpm_tis: Unable to request irq: 7 for probe > [ 77.960082] genirq: Flags mismatch irq 8. 00000080 (tpm0) vs. 00000000 (rtc0) > [ 77.960087] tpm_tis tpm_tis: Unable to request irq: 8 for probe > [ 78.032041] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.104043] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.176041] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.248041] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.320041] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.392040] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.464041] tpm_tis tpm_tis: A TPM error (256) occurred attempting to generate an interrupt > [ 78.524041] tpm_tis tpm_tis: A TPM error (256) occurred continue selftest > [ 78.524048] tpm_tis tpm_tis: Firmware has not started TPM > [ 78.596041] tpm_tis tpm_tis: A TPM error (149) occurred attempting to start the TPM > [ 78.596048] tpm_tis tpm_tis: TPM self test failed > > > ;( > Peter /Jarkko ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk >From e8337658b6f29fc1259b1ddaf81e51ede91219e8 Mon Sep 17 00:00:00 2001 From: Jarkko Sakkinen Date: Tue, 16 Dec 2014 23:28:51 +0200 Subject: [PATCH] tpm: invalid size for struct tpm2_startup_header sizeof(tpm2_pcr_read_in) was used in place of sizeof(tpm2_startup_in). This patch fixes the issue. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm2-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c index 610dc87..d1b99df 100644 --- a/drivers/char/tpm/tpm2-cmd.c +++ b/drivers/char/tpm/tpm2-cmd.c @@ -411,7 +411,7 @@ ssize_t tpm2_get_tpm_pt(struct tpm_chip *chip, u32 property_id, u32 *value, #define TPM2_STARTUP_IN_SIZE \ (sizeof(struct tpm_input_header) + \ - sizeof(struct tpm2_pcr_read_in)) + sizeof(struct tpm2_startup_in)) static const struct tpm_input_header tpm2_startup_header = { .tag = cpu_to_be16(TPM2_ST_NO_SESSIONS), -- 2.1.0