| Message ID | 20160719204027.GE16042@obsidianresearch.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 19, 2016 at 02:40:27PM -0600, Jason Gunthorpe wrote: > On Tue, Jul 19, 2016 at 11:36:34PM +0300, Jarkko Sakkinen wrote: > > If Christophe could submit a fix for st33, I could include it to this > > series and make one more revision. Thank you for reviewing this! > > Here is a commit: Right I see. I just read through that file and now I understand the context. I revamp one more revision of the series with tpm_gen_interrupt() moved as internal function for tis. /Jarkko > From 5e178858dcdc2bff9ac31f9851db52370cc282cb Mon Sep 17 00:00:00 2001 > From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > Date: Tue, 19 Jul 2016 14:38:55 -0600 > Subject: [PATCH] tpm/st33zp24: Remove useless tpm_gen_interrupt > > This function should only be called as part of an IRQ probing protocol > and st33 does not have any code to detect that the IRQ it tries to > generate was not generated and disable the IRQ. > > Since st33 is primarily a DT binding driver it should not be doing > IRQ probing anyhow, so let us just delete this useless call. > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > --- > drivers/char/tpm/st33zp24/st33zp24.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c > index c2ee30451e41..6f060c76217b 100644 > --- a/drivers/char/tpm/st33zp24/st33zp24.c > +++ b/drivers/char/tpm/st33zp24/st33zp24.c > @@ -589,8 +589,6 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops, > chip->flags |= TPM_CHIP_FLAG_IRQ; > > disable_irq_nosync(tpm_dev->irq); > - > - tpm_gen_interrupt(chip); > } > > return tpm_chip_register(chip); > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c index c2ee30451e41..6f060c76217b 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -589,8 +589,6 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops, chip->flags |= TPM_CHIP_FLAG_IRQ; disable_irq_nosync(tpm_dev->irq); - - tpm_gen_interrupt(chip); } return tpm_chip_register(chip);