From patchwork Wed May 31 00:05:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 9760921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E83366038E for ; Thu, 1 Jun 2017 19:20:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7540284F9 for ; Thu, 1 Jun 2017 19:20:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC38128504; Thu, 1 Jun 2017 19:20:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7851E2850F for ; Thu, 1 Jun 2017 19:20:02 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-3.v29.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1dGVdZ-0003Wy-Lq; Thu, 01 Jun 2017 19:20:01 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1dFrVY-0007Pb-G0 for tpmdd-devel@lists.sourceforge.net; Wed, 31 May 2017 00:29:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date; bh=kZG8vXdgPhiXU+hQKHlfafb2CfzLvB4Pm2wItx8Hy9Y=; b=BqN9oETmtWcKx+qe2x7k3/rKZ3C2cfMrlRsj/iCh7SSyLT0v5F0Ra99hhqNFyO2F1a3Hztbg8WMJ1dINJqJlAk3kBRS2/IAk6jDvYffXsPyFAPDw+qNZwAvyP4Ny0zHuod5KDXzy0m2X8keB0z0FB2LX2dVC1AEXXht7m6DKgfs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date; bh=kZG8vXdgPhiXU+hQKHlfafb2CfzLvB4Pm2wItx8Hy9Y=; b=ITOZX9SRpPagiCNay1M5QOIzhLKlAjIBeURC4IMQLHgrRCGRkTV/EtgfVjAxXd6ABbewB+SGxVILxnqIe1Kb8tuD7w/vqMGyMjZ40WGlaugak/s1DPMdK5/aRNwQrxajf5hG+cB7loJYQnLWuNvf/t5qEtWJyr+tweufqzf3kfo=; Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of embeddedor.com designates 192.185.47.206 as permitted sender) client-ip=192.185.47.206; envelope-from=garsilva@embeddedor.com; helo=gateway22.websitewelcome.com; Received: from gateway22.websitewelcome.com ([192.185.47.206]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1dFrVX-0003OY-H9 for tpmdd-devel@lists.sourceforge.net; Wed, 31 May 2017 00:29:04 +0000 Received: from cm6.websitewelcome.com (cm6.websitewelcome.com [108.167.139.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id EF09814611 for ; Tue, 30 May 2017 19:06:05 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cm6.websitewelcome.com with id So5y1v00y0V9LXg01o5zLQ; Tue, 30 May 2017 19:05:59 -0500 Received: from [189.152.189.101] (port=45254 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dFr9C-000Mtp-J8; Tue, 30 May 2017 19:05:58 -0500 Date: Tue, 30 May 2017 19:05:57 -0500 From: "Gustavo A. R. Silva" To: Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe Message-ID: <20170531000557.GA3301@embeddedgus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170530174027.Horde.AYiQnLwlE09KhkcqzdNaVTk@gator4166.hostgator.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.sourceforge.net X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.101 X-Exim-ID: 1dFr9C-000Mtp-J8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.101]:45254 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Headers-End: 1dFrVX-0003OY-H9 X-Mailman-Approved-At: Thu, 01 Jun 2017 19:19:58 +0000 Subject: [tpmdd-devel] [PATCH] char: tpm: remove unnecessary code X-BeenThere: tpmdd-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: Tpm Device Driver maintainance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tpmdd-devel@lists.sourceforge.net, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org Errors-To: tpmdd-devel-bounces@lists.sourceforge.net X-Virus-Scanned: ClamAV using ClamSMTP Remove unnecessary code. Pointer chip cannot be NULL in st33zp24_send(). Addresses-Coverity-ID: 1397648 Cc: Jason Gunthorpe Signed-off-by: Gustavo A. R. Silva --- drivers/char/tpm/st33zp24/st33zp24.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c index 4d1dc8b..ca74c24 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf, int ret; u8 data; - if (!chip) - return -EBUSY; if (len < TPM_HEADER_SIZE) return -EBUSY;