From patchwork Sun May 9 16:18:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jvrao X-Patchwork-Id: 98242 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4AIZWS4013318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 10 May 2010 18:36:08 GMT Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OBXp7-0005fO-Ug; Mon, 10 May 2010 18:35:25 +0000 Received: from sfi-mx-2.v28.ch3.sourceforge.com ([172.29.28.122] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OBXp7-0005fI-08 for v9fs-developer@lists.sourceforge.net; Mon, 10 May 2010 18:35:25 +0000 X-ACL-Warn: Received: from e36.co.us.ibm.com ([32.97.110.154]) by sfi-mx-2.v28.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1OBXp6-0004Wo-6V for v9fs-developer@lists.sourceforge.net; Mon, 10 May 2010 18:35:24 +0000 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4AHxdk2020477 for ; Mon, 10 May 2010 11:59:39 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o4AI2jIX175796 for ; Mon, 10 May 2010 12:02:45 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4AI2gll026652 for ; Mon, 10 May 2010 12:02:42 -0600 Received: from elm9m80.beaverton.ibm.com (elm9m80.beaverton.ibm.com [9.47.81.80]) by d03av02.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id o4AI2eXN026616 for ; Mon, 10 May 2010 12:02:41 -0600 Received: by elm9m80.beaverton.ibm.com (Postfix, from userid 0) id BAE9A67C22; Sun, 9 May 2010 09:18:54 -0700 (PDT) From: "Venkateswararao Jujjuri (JV)" To: v9fs-developer@lists.sourceforge.net Date: Sun, 9 May 2010 09:18:54 -0700 Message-Id: <1273421934-8238-1-git-send-email-jvrao@linux.vnet.ibm.com> X-Mailer: git-send-email 1.6.0.6 X-Spam-Score: 1.5 (+) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 1.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records 1.6 DATE_IN_PAST_24_48 Date: is 24 to 48 hours before Received: date -1.5 AWL AWL: From: address is in the auto white-list X-Headers-End: 1OBXp6-0004Wo-6V Subject: [V9fs-developer] [PATCH] 9p: Optimize v9fs_create by eliminating additional fids and stat. X-BeenThere: v9fs-developer@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: v9fs-developer-bounces@lists.sourceforge.net X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 10 May 2010 18:36:08 +0000 (UTC) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index ec2bed4..443c51b 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -504,22 +504,13 @@ v9fs_create(struct v9fs_session_info *v9ses, struct inode *dir, goto error; } - /* now walk from the parent so we can get unopened fid */ - fid = p9_client_walk(dfid, 1, &name, 1); - if (IS_ERR(fid)) { - err = PTR_ERR(fid); - P9_DPRINTK(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err); - fid = NULL; - goto error; - } + /* + * Get an indoe and instantiate it in the dentry without any + * fid or stat information. That information can be obtained + * from the server when needed. + */ - /* instantiate inode and assign the unopened fid to the dentry */ - inode = v9fs_inode_from_fid(v9ses, fid, dir->i_sb); - if (IS_ERR(inode)) { - err = PTR_ERR(inode); - P9_DPRINTK(P9_DEBUG_VFS, "inode creation failed %d\n", err); - goto error; - } + inode = v9fs_get_inode(dir->i_sb, p9mode2unixmode(v9ses, mode)); if (v9ses->cache) dentry->d_op = &v9fs_cached_dentry_operations; @@ -527,7 +518,7 @@ v9fs_create(struct v9fs_session_info *v9ses, struct inode *dir, dentry->d_op = &v9fs_dentry_operations; d_instantiate(dentry, inode); - err = v9fs_fid_add(dentry, fid); + if (err < 0) goto error;