From patchwork Mon Jul 15 08:44:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 2827337 Return-Path: X-Original-To: patchwork-v9fs-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 32FF9C0AB2 for ; Mon, 15 Jul 2013 08:57:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 57C0A20142 for ; Mon, 15 Jul 2013 08:57:48 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23B562013A for ; Mon, 15 Jul 2013 08:57:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UyebI-0007yC-Ml; Mon, 15 Jul 2013 08:57:44 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1UyebF-0007y2-Jo for v9fs-developer@lists.sourceforge.net; Mon, 15 Jul 2013 08:57:41 +0000 X-ACL-Warn: Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1UyebB-0002jB-1t for v9fs-developer@lists.sourceforge.net; Mon, 15 Jul 2013 08:57:40 +0000 Received: from cpsps-ews06.kpnxchange.com ([10.94.84.173]) by cpsmtpb-ews07.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 15 Jul 2013 10:44:05 +0200 Received: from CPSMTPM-TLF102.kpnxchange.com ([195.121.3.5]) by cpsps-ews06.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 15 Jul 2013 10:44:05 +0200 Received: from [192.168.1.103] ([212.123.139.93]) by CPSMTPM-TLF102.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 15 Jul 2013 10:44:05 +0200 Message-ID: <1373877845.2591.9.camel@x61.thuisdomein> From: Paul Bolle To: Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , "David S. Miller" Date: Mon, 15 Jul 2013 10:44:05 +0200 X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 X-OriginalArrivalTime: 15 Jul 2013 08:44:06.0035 (UTC) FILETIME=[77056630:01CE8137] X-RcptDomain: lists.sourceforge.net X-Spam-Score: 0.0 (/) X-Headers-End: 1UyebB-0002jB-1t Cc: v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [V9fs-developer] 9P: hook up rdma_cancelled() into p9_rdma_trans? X-BeenThere: v9fs-developer@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: v9fs-developer-bounces@lists.sourceforge.net X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 0) Building trans_rdma.o (in v3.11-rc1) triggers a warning: net/9p/trans_rdma.c:594:12: warning: ‘rdma_cancelled’ defined but not used [-Wunused-function] 1) Did commit 80b45261a0 ("9P: Add cancelled() to the transport functions.") forget to actually hook up rdma_cancelled() into p9_rdma_trans()? Say, like this: That (compile tested only) patch silences this warning. Is there a patch queued to do something like this? I couldn't find it. Paul Bolle ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 928f2bb..0c42b1c 100644 --- a/net/9p/trans_rdma.c +++ b/net/9p/trans_rdma.c @@ -732,6 +732,7 @@ static struct p9_trans_module p9_rdma_trans = { .close = rdma_close, .request = rdma_request, .cancel = rdma_cancel, + .cancelled = rdma_cancelled, }; /**