From patchwork Sat Sep 28 23:32:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Geyslan G. Bem" X-Patchwork-Id: 2959381 Return-Path: X-Original-To: patchwork-v9fs-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 28B179FA44 for ; Sat, 28 Sep 2013 23:37:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6F27820200 for ; Sat, 28 Sep 2013 23:36:59 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 926A8201FF for ; Sat, 28 Sep 2013 23:36:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VQ44G-0000oA-OJ; Sat, 28 Sep 2013 23:36:56 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VQ44F-0000nz-E4 for v9fs-developer@lists.sourceforge.net; Sat, 28 Sep 2013 23:36:55 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.216.46 as permitted sender) client-ip=209.85.216.46; envelope-from=geyslan@gmail.com; helo=mail-qa0-f46.google.com; Received: from mail-qa0-f46.google.com ([209.85.216.46]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VQ44E-00049h-Sn for v9fs-developer@lists.sourceforge.net; Sat, 28 Sep 2013 23:36:55 +0000 Received: by mail-qa0-f46.google.com with SMTP id j7so1406717qaq.5 for ; Sat, 28 Sep 2013 16:36:49 -0700 (PDT) X-Received: by 10.224.54.129 with SMTP id q1mr23012157qag.19.1380411409455; Sat, 28 Sep 2013 16:36:49 -0700 (PDT) Received: from localhost.localdomain (189-48-112-205.user.veloxzone.com.br. [189.48.112.205]) by mx.google.com with ESMTPSA id 5sm34534915qao.3.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 28 Sep 2013 16:36:49 -0700 (PDT) From: "Geyslan G. Bem" To: ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net Date: Sat, 28 Sep 2013 20:32:17 -0300 Message-Id: <1380411144-9236-5-git-send-email-geyslan@gmail.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1380411144-9236-1-git-send-email-geyslan@gmail.com> References: <1380411144-9236-1-git-send-email-geyslan@gmail.com> X-Spam-Score: -1.6 (-) X-Headers-End: 1VQ44E-00049h-Sn Cc: v9fs-developer@lists.sourceforge.net, "Geyslan G. Bem" , linux-kernel@vger.kernel.org Subject: [V9fs-developer] [PATCH] 9p: fix return value in case of error in v9fs_fid_xattr_set X-BeenThere: v9fs-developer@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: v9fs-developer-bounces@lists.sourceforge.net X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In case of error in the p9_client_write, the function v9fs_fid_xattr_set should return its negative value, what was never being done. Signed-off-by: Geyslan G. Bem --- fs/9p/xattr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c index 3c28cdf..0788388 100644 --- a/fs/9p/xattr.c +++ b/fs/9p/xattr.c @@ -149,11 +149,10 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, write_count = value_len; write_count = p9_client_write(fid, ((char *)value)+offset, NULL, offset, write_count); - if (write_count < 0) { - /* error in xattr write */ - retval = write_count; - break; - } + /* error in xattr write */ + if (write_count < 0) + return write_count; + offset += write_count; value_len -= write_count; }