From patchwork Sat Sep 28 23:32:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Geyslan G. Bem" X-Patchwork-Id: 2959431 Return-Path: X-Original-To: patchwork-v9fs-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CA6CBBFF0B for ; Sat, 28 Sep 2013 23:37:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1287520200 for ; Sat, 28 Sep 2013 23:37:09 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDBF8201FF for ; Sat, 28 Sep 2013 23:37:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-3.v29.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VQ44Q-0005EJ-3z; Sat, 28 Sep 2013 23:37:06 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VQ44O-0005E7-Fv for v9fs-developer@lists.sourceforge.net; Sat, 28 Sep 2013 23:37:04 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=geyslan@gmail.com; helo=mail-qe0-f54.google.com; Received: from mail-qe0-f54.google.com ([209.85.128.54]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VQ44N-0004A2-SD for v9fs-developer@lists.sourceforge.net; Sat, 28 Sep 2013 23:37:04 +0000 Received: by mail-qe0-f54.google.com with SMTP id cy11so2870239qeb.27 for ; Sat, 28 Sep 2013 16:36:58 -0700 (PDT) X-Received: by 10.49.49.133 with SMTP id u5mr18474316qen.19.1380411418463; Sat, 28 Sep 2013 16:36:58 -0700 (PDT) Received: from localhost.localdomain (189-48-112-205.user.veloxzone.com.br. [189.48.112.205]) by mx.google.com with ESMTPSA id 5sm34534915qao.3.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 28 Sep 2013 16:36:58 -0700 (PDT) From: "Geyslan G. Bem" To: ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net Date: Sat, 28 Sep 2013 20:32:20 -0300 Message-Id: <1380411144-9236-8-git-send-email-geyslan@gmail.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1380411144-9236-1-git-send-email-geyslan@gmail.com> References: <1380411144-9236-1-git-send-email-geyslan@gmail.com> X-Spam-Score: -1.6 (-) X-Headers-End: 1VQ44N-0004A2-SD Cc: v9fs-developer@lists.sourceforge.net, "Geyslan G. Bem" , linux-kernel@vger.kernel.org Subject: [V9fs-developer] [PATCH] 9p: proper use of the 'name' variable X-BeenThere: v9fs-developer@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: v9fs-developer-bounces@lists.sourceforge.net X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'name' variable was assigned but never used. Hence puts its assignment to the top and makes proper use of its value. Signed-off-by: Geyslan G. Bem --- fs/9p/vfs_inode_dotl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index 6803758..86b6944 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c @@ -772,8 +772,10 @@ v9fs_vfs_link_dotl(struct dentry *old_dentry, struct inode *dir, struct p9_fid *dfid, *oldfid; struct v9fs_session_info *v9ses; + name = (char *) dentry->d_name.name; + p9_debug(P9_DEBUG_VFS, "dir ino: %lu, old_name: %s, new_name: %s\n", - dir->i_ino, old_dentry->d_name.name, dentry->d_name.name); + dir->i_ino, old_dentry->d_name.name, name); v9ses = v9fs_inode2v9ses(dir); dir_dentry = dentry->d_parent; @@ -785,9 +787,7 @@ v9fs_vfs_link_dotl(struct dentry *old_dentry, struct inode *dir, if (IS_ERR(oldfid)) return PTR_ERR(oldfid); - name = (char *) dentry->d_name.name; - - err = p9_client_link(dfid, oldfid, (char *)dentry->d_name.name); + err = p9_client_link(dfid, oldfid, name); if (err < 0) { p9_debug(P9_DEBUG_VFS, "p9_client_link failed %d\n", err);