| Message ID | 20240224134617.829016-1-chengming.zhou@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | 9p: remove SLAB_MEM_SPREAD flag usage | expand |
On 2024/2/24 21:46, chengming.zhou@linux.dev wrote: > From: Chengming Zhou <zhouchengming@bytedance.com> > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. Update changelog to make it clearer: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks! > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> > --- > fs/9p/v9fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c > index 61dbe52bb3a3..281a1ed03a04 100644 > --- a/fs/9p/v9fs.c > +++ b/fs/9p/v9fs.c > @@ -637,7 +637,7 @@ static int v9fs_init_inode_cache(void) > v9fs_inode_cache = kmem_cache_create("v9fs_inode_cache", > sizeof(struct v9fs_inode), > 0, (SLAB_RECLAIM_ACCOUNT| > - SLAB_MEM_SPREAD|SLAB_ACCOUNT), > + SLAB_ACCOUNT), > v9fs_inode_init_once); > if (!v9fs_inode_cache) > return -ENOMEM;
Chengming Zhou wrote on Mon, Feb 26, 2024 at 10:51:00AM +0800: > On 2024/2/24 21:46, chengming.zhou@linux.dev wrote: > > From: Chengming Zhou <zhouchengming@bytedance.com> > > > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > > its usage so we can delete it from slab. No functional change. > > Update changelog to make it clearer: > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed as of v6.8-rc1, so it became a dead flag since the commit > 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the > series[1] went on to mark it obsolete to avoid confusion for users. > Here we can just remove all its users, which has no functional change. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks for the updated text, this is a bit better. I've updated your commit message with this and will push to Linus next merge window in a couple of weeks, as you said there's no change so no reason to submit a patch this late in the cycle.
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c index 61dbe52bb3a3..281a1ed03a04 100644 --- a/fs/9p/v9fs.c +++ b/fs/9p/v9fs.c @@ -637,7 +637,7 @@ static int v9fs_init_inode_cache(void) v9fs_inode_cache = kmem_cache_create("v9fs_inode_cache", sizeof(struct v9fs_inode), 0, (SLAB_RECLAIM_ACCOUNT| - SLAB_MEM_SPREAD|SLAB_ACCOUNT), + SLAB_ACCOUNT), v9fs_inode_init_once); if (!v9fs_inode_cache) return -ENOMEM;