| Message ID | 20241019092302.212221-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | 9p/trans_usbg: Fix incorrect error check in usb9pfs_alloc_instance() | expand |
On Saturday, October 19, 2024 11:23:02 AM CEST Yue Haibing wrote: > kzalloc() should use NULL check not a IS_ERR() check. > > Fixes: a3be076dc174 ("net/9p/usbg: Add new usb gadget function transport") > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com> > --- > net/9p/trans_usbg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/9p/trans_usbg.c b/net/9p/trans_usbg.c > index 975b76839dca..6b694f117aef 100644 > --- a/net/9p/trans_usbg.c > +++ b/net/9p/trans_usbg.c > @@ -909,9 +909,9 @@ static struct usb_function_instance *usb9pfs_alloc_instance(void) > usb9pfs_opts->buflen = DEFAULT_BUFLEN; > > dev = kzalloc(sizeof(*dev), GFP_KERNEL); > - if (IS_ERR(dev)) { > + if (!dev) { > kfree(usb9pfs_opts); > - return ERR_CAST(dev); > + return ERR_PTR(-ENOMEM); > } > > usb9pfs_opts->dev = dev; >
diff --git a/net/9p/trans_usbg.c b/net/9p/trans_usbg.c index 975b76839dca..6b694f117aef 100644 --- a/net/9p/trans_usbg.c +++ b/net/9p/trans_usbg.c @@ -909,9 +909,9 @@ static struct usb_function_instance *usb9pfs_alloc_instance(void) usb9pfs_opts->buflen = DEFAULT_BUFLEN; dev = kzalloc(sizeof(*dev), GFP_KERNEL); - if (IS_ERR(dev)) { + if (!dev) { kfree(usb9pfs_opts); - return ERR_CAST(dev); + return ERR_PTR(-ENOMEM); } usb9pfs_opts->dev = dev;
kzalloc() should use NULL check not a IS_ERR() check. Fixes: a3be076dc174 ("net/9p/usbg: Add new usb gadget function transport") Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- net/9p/trans_usbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)