mbox series

[v8,0/2] xen/arm: Consolidate make_timer_node and make_timer_domU_node

Message ID 20190807125725.31683-1-viktor.mitin.19@gmail.com (mailing list archive)
Headers show
Series xen/arm: Consolidate make_timer_node and make_timer_domU_node | expand

Message

Viktor Mitin Aug. 7, 2019, 12:57 p.m. UTC
Functions make_timer_node and make_timer_domU_node are quite similar,
so it is better to consolidate them to avoid discrepancy.

This patch series achives this goal in two steps:
- Extend fdt_property_interrupts to deal with other domain than the hwdom.
- Consolidate make_timer_node and make_timer_domU_node into one function:

Viktor Mitin (2):
  xen/arm: extend fdt_property_interrupts to support DomU
  xen/arm: consolidate make_timer_node and make_timer_domU_node

 xen/arch/arm/domain_build.c | 118 ++++++++++++++----------------------
 1 file changed, 44 insertions(+), 74 deletions(-)

Comments

Julien Grall Aug. 7, 2019, 1:02 p.m. UTC | #1
Hi,

Please give some time for reviewers to review the full series... I am still 
writing an answer on patch #2 in v7...

You should at least wait for review on the series before sending a new version. 
This would have likely avoided to be at v8 for such series.

In this case, I don't think there was anything requiring a v8.

Cheers,

On 07/08/2019 13:57, Viktor Mitin wrote:
> Functions make_timer_node and make_timer_domU_node are quite similar,
> so it is better to consolidate them to avoid discrepancy.
> 
> This patch series achives this goal in two steps:
> - Extend fdt_property_interrupts to deal with other domain than the hwdom.
> - Consolidate make_timer_node and make_timer_domU_node into one function:
> 
> Viktor Mitin (2):
>    xen/arm: extend fdt_property_interrupts to support DomU
>    xen/arm: consolidate make_timer_node and make_timer_domU_node
> 
>   xen/arch/arm/domain_build.c | 118 ++++++++++++++----------------------
>   1 file changed, 44 insertions(+), 74 deletions(-)
>
Julien Grall Aug. 14, 2019, 10:14 a.m. UTC | #2
Hi,

On 07/08/2019 13:57, Viktor Mitin wrote:
> Functions make_timer_node and make_timer_domU_node are quite similar,
> so it is better to consolidate them to avoid discrepancy.
> 
> This patch series achives this goal in two steps:
> - Extend fdt_property_interrupts to deal with other domain than the hwdom.
> - Consolidate make_timer_node and make_timer_domU_node into one function:
> 
> Viktor Mitin (2):
>    xen/arm: extend fdt_property_interrupts to support DomU
>    xen/arm: consolidate make_timer_node and make_timer_domU_node

I have committed the two patches. thank you!

Cheers,