From patchwork Wed Feb 12 16:49:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 11378795 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 97F5C924 for ; Wed, 12 Feb 2020 16:51:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73BF820724 for ; Wed, 12 Feb 2020 16:51:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="ATBtWo7Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73BF820724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1vDP-0007pt-GE; Wed, 12 Feb 2020 16:50:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1vDN-0007po-DJ for xen-devel@lists.xenproject.org; Wed, 12 Feb 2020 16:50:17 +0000 X-Inumbo-ID: bebad448-4db7-11ea-aa99-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bebad448-4db7-11ea-aa99-bc764e2007e4; Wed, 12 Feb 2020 16:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1581526217; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kR6pfS/4f3wUGf6gHUXBHV7FhntVRyrKckAmAh9NeDA=; b=ATBtWo7ZLoUS/NdLpQz4nUooRuOf5DXPBN/4VUpejHBaaJkH7dMhoZuU dWg/ebW8FJRHTQa9HtZhPBBTZqM9ijPd9pGJpKA9EODZguXI/CSQNcaJQ Z+tWAne5wyEPiYNk8GzonHG6ptOTIke8YwGVyOzA6c37q3NH7+7hMQL9c I=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: BsY4QULXFPvNS7GYb+fL/BDKsxY0JX5SrDPKXeiggw1pPGzWgWLS1spbG226iFvzdtqEKvtuo9 clHtrSiJj7R9zsXXJCH83Gf2NuBuTaCPs6h6QaMX5IZ8I7YM41AkcgSs5et5czoFWmG2isCPL7 7CK/D92P9kJ+n6duec/HVUHA+rhKNM3OSXFgtz1nnVbmMLgO3+WFfYKhtXbPpkW8PB58Z4zAaC 4qq9uTMMTdQqzJJMuCpgWIG2SRi8gmDdLD+z829Vq7THPtWxS7eksdEmhvFNYUNZACrHCFmtA/ gnI= X-SBRS: 2.7 X-MesageID: 12353162 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,433,1574139600"; d="scan'208";a="12353162" From: Roger Pau Monne To: Date: Wed, 12 Feb 2020 17:49:46 +0100 Message-ID: <20200212164949.56434-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 0/3] x86: fixes/improvements for scratch cpumask X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hello, Commit: 5500d265a2a8fa63d60c08beb549de8ec82ff7a5 x86/smp: use APIC ALLBUT destination shorthand when possible Introduced a bogus usage of the scratch cpumask: it was used in a function that could be called from interrupt context, and hence using the scratch cpumask there is not safe. Patch #2 is a fix for that usage. Patch #3 adds some debug infrastructure to make sure the scratch cpumask is used in the right context, and hence should prevent further missuses. Thanks, Roger. Roger Pau Monne (3): x86/smp: unify header includes in smp.h x86/smp: use a dedicated scratch cpumask in send_IPI_mask x86: add accessors for scratch cpu mask xen/arch/x86/io_apic.c | 6 ++++-- xen/arch/x86/irq.c | 13 ++++++++++--- xen/arch/x86/mm.c | 30 +++++++++++++++++++++--------- xen/arch/x86/msi.c | 4 +++- xen/arch/x86/smp.c | 14 +++++++++++++- xen/arch/x86/smpboot.c | 33 ++++++++++++++++++++++++++++++++- xen/include/asm-x86/smp.h | 15 +++++++++++---- 7 files changed, 94 insertions(+), 21 deletions(-)