mbox series

[v3,0/4] x86/nvmx: fixes for interrupt injection

Message ID 20200326152720.36970-1-roger.pau@citrix.com (mailing list archive)
Headers show
Series x86/nvmx: fixes for interrupt injection | expand

Message

Roger Pau Monné March 26, 2020, 3:27 p.m. UTC
Hello,

osstest identified a regression caused by my earlier attempt to fix
interrupt injection when using nested VMX. This series aims to fix the
regression, and should unblock several osstest branches.

The following report is from osstest with this series applied:

http://logs.test-lab.xenproject.org/osstest/logs/149051/

Note the last patch (4/4) is the one that actually fixes the issue. Xen
will always use the Ack on exit feature so patches 2/4 and 3/4 don't
change the functionality when running a nested Xen, as it always
requires SVI to be updated.

Thanks, Roger.

Roger Pau Monne (4):
  Revert "x86/vvmx: fix virtual interrupt injection when Ack on exit
    control is used"
  x86/nvmx: only update SVI when using Ack on exit
  x86/nvmx: split updating RVI from SVI in nvmx_update_apicv
  x86/nvmx: update exit bitmap when using virtual interrupt delivery

 xen/arch/x86/hvm/vmx/intr.c       | 21 +++++++++------
 xen/arch/x86/hvm/vmx/vvmx.c       | 43 ++++++++++++++++++++-----------
 xen/include/asm-x86/hvm/vmx/vmx.h |  2 ++
 3 files changed, 43 insertions(+), 23 deletions(-)

Comments

Jan Beulich March 26, 2020, 3:41 p.m. UTC | #1
On 26.03.2020 16:27, Roger Pau Monne wrote:
> Hello,
> 
> osstest identified a regression caused by my earlier attempt to fix
> interrupt injection when using nested VMX. This series aims to fix the
> regression, and should unblock several osstest branches.
> 
> The following report is from osstest with this series applied:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/149051/
> 
> Note the last patch (4/4) is the one that actually fixes the issue. Xen
> will always use the Ack on exit feature so patches 2/4 and 3/4 don't
> change the functionality when running a nested Xen, as it always
> requires SVI to be updated.
> 
> Thanks, Roger.
> 
> Roger Pau Monne (4):
>   Revert "x86/vvmx: fix virtual interrupt injection when Ack on exit
>     control is used"
>   x86/nvmx: only update SVI when using Ack on exit

You probably didn't notice that these two got committed earlier today?

Jan
Roger Pau Monné March 26, 2020, 3:49 p.m. UTC | #2
On Thu, Mar 26, 2020 at 04:41:15PM +0100, Jan Beulich wrote:
> On 26.03.2020 16:27, Roger Pau Monne wrote:
> > Hello,
> > 
> > osstest identified a regression caused by my earlier attempt to fix
> > interrupt injection when using nested VMX. This series aims to fix the
> > regression, and should unblock several osstest branches.
> > 
> > The following report is from osstest with this series applied:
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/149051/
> > 
> > Note the last patch (4/4) is the one that actually fixes the issue. Xen
> > will always use the Ack on exit feature so patches 2/4 and 3/4 don't
> > change the functionality when running a nested Xen, as it always
> > requires SVI to be updated.
> > 
> > Thanks, Roger.
> > 
> > Roger Pau Monne (4):
> >   Revert "x86/vvmx: fix virtual interrupt injection when Ack on exit
> >     control is used"
> >   x86/nvmx: only update SVI when using Ack on exit
> 
> You probably didn't notice that these two got committed earlier today?

Urg no, sorry. I rebased before lunch and then triggered the osstest
job. Thanks for committing those two!

Roger.