[v2,00/11] Multiple fixes to XENMEM_acquire_resource

Message

Andrew Cooper Sept. 22, 2020, 6:24 p.m. UTC

I thought this was going to be a very simple small bugfix for Michał's
Processor Trace series.  Serves me right for expecting it not to be full of
bear traps...

The sole implementation of acquire_resource never asks for size, so its little
surprise that Xen is broken for compat callers, and returns incorrect
information for regular callers.

v2 was delayed substantially due to the discovery of XSA-334, but is complete
now, permitting the mapping of arbitrary sized resouces, along with fixes to
the compat XLAT logic.

The final two patches are only local testing, and not intended for committing.

A branch can be obtained from:

  https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/xen-acquire-resource

Andrew Cooper (11):
  xen/memory: Introduce CONFIG_ARCH_ACQUIRE_RESOURCE
  xen/gnttab: Rework resource acquisition
  xen/memory: Fix compat XENMEM_acquire_resource for size requests
  xen/memory: Fix acquire_resource size semantics
  tools/foreignmem: Support querying the size of a resource
  xen/memory: Clarify the XENMEM_acquire_resource ABI description
  xen/memory: Improve compat XENMEM_acquire_resource handling
  xen/memory: Indent part of acquire_resource()
  xen/memory: Fix mapping grant tables with XENMEM_acquire_resource
  TESTING dom0
  TESTING XTF

 tools/libs/foreignmemory/Makefile                  |   2 +-
 tools/libs/foreignmemory/core.c                    |  14 ++
 .../libs/foreignmemory/include/xenforeignmemory.h  |  15 ++
 tools/libs/foreignmemory/libxenforeignmemory.map   |   4 +
 tools/libs/foreignmemory/linux.c                   |  36 +++
 tools/libs/foreignmemory/private.h                 |  14 ++
 tools/libs/uselibs.mk                              |   2 +-
 tools/misc/Makefile                                |   4 +
 tools/misc/xen-resource.c                          | 106 +++++++++
 xen/arch/x86/Kconfig                               |   1 +
 xen/arch/x86/mm.c                                  |  24 +-
 xen/common/Kconfig                                 |   3 +
 xen/common/compat/memory.c                         | 151 +++++++++----
 xen/common/grant_table.c                           | 128 ++++++++---
 xen/common/memory.c                                | 244 ++++++++++++++-------
 xen/include/asm-arm/mm.h                           |   8 -
 xen/include/asm-x86/mm.h                           |   3 +
 xen/include/public/memory.h                        |  23 +-
 xen/include/xen/grant_table.h                      |  21 +-
 xen/include/xen/mm.h                               |  15 ++
 20 files changed, 647 insertions(+), 171 deletions(-)
 create mode 100644 tools/misc/xen-resource.c