[0/5] tools/xenstore: remove read-only socket

Message

Jürgen Groß Oct. 2, 2020, 3:41 p.m. UTC

The read-only socket of Xenstore is usable for the daemon case only
and even there it is not really worth to be kept, as not all
Xesntore operations changing the state of Xenstore are blocked,
oxenstored ignoring the read-only semantics completely, and the
privileges for using the ro-socket being the same as for the normal
rw-socket.

So remove this feature with switching the related use cases to the
Xenstore-type agnostic open- and close-functions..

Juergen Gross (5):
  tools/xenstore: remove socket-only option from xenstore client
  tools/libs/store: ignore XS_OPEN_SOCKETONLY flag
  tools/libs/store: drop read-only functionality
  tools: drop all deprecated usages of xs_*_open() and friends in tools
  tools/xenstore: drop creation of read-only socket in xenstored

 docs/man/xenstore-chmod.1.pod           |  4 --
 docs/man/xenstore-ls.1.pod              |  4 --
 docs/man/xenstore-read.1.pod            |  4 --
 docs/man/xenstore-write.1.pod           |  4 --
 tools/console/client/main.c             |  2 +-
 tools/console/daemon/utils.c            |  4 +-
 tools/libs/light/libxl.c                |  6 +--
 tools/libs/light/libxl_exec.c           |  6 +--
 tools/libs/light/libxl_fork.c           |  2 +-
 tools/libs/stat/xenstat.c               |  4 +-
 tools/libs/store/include/xenstore.h     | 10 -----
 tools/libs/store/xs.c                   |  9 ++--
 tools/libs/vchan/init.c                 | 10 ++---
 tools/misc/xen-lowmemd.c                |  4 +-
 tools/python/xen/lowlevel/xs/xs.c       |  6 +--
 tools/tests/mce-test/tools/xen-mceinj.c |  4 +-
 tools/xenbackendd/xenbackendd.c         |  4 +-
 tools/xenpmd/xenpmd.c                   |  6 +--
 tools/xenstore/xenstore_client.c        |  8 +---
 tools/xenstore/xenstored_core.c         | 55 +++++--------------------
 tools/xenstore/xenstored_core.h         |  3 --
 tools/xenstore/xenstored_domain.c       |  4 +-
 tools/xenstore/xs_lib.c                 |  8 +---
 23 files changed, 46 insertions(+), 125 deletions(-)

Comments

Wei Liu Oct. 8, 2020, 12:54 p.m. UTC | #1

On Fri, Oct 02, 2020 at 05:41:36PM +0200, Juergen Gross wrote:
> The read-only socket of Xenstore is usable for the daemon case only
> and even there it is not really worth to be kept, as not all
> Xesntore operations changing the state of Xenstore are blocked,
> oxenstored ignoring the read-only semantics completely, and the
> privileges for using the ro-socket being the same as for the normal
> rw-socket.
> 
> So remove this feature with switching the related use cases to the
> Xenstore-type agnostic open- and close-functions..
> 
> Juergen Gross (5):
>   tools/xenstore: remove socket-only option from xenstore client
>   tools/libs/store: ignore XS_OPEN_SOCKETONLY flag
>   tools/libs/store: drop read-only functionality
>   tools: drop all deprecated usages of xs_*_open() and friends in tools
>   tools/xenstore: drop creation of read-only socket in xenstored

Acked + applied.

Please submit a follow-up patch for adding some comments to xenstore.h.

Wei.