From patchwork Fri Jan 15 14:28:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Pau Monne X-Patchwork-Id: 12023001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2E4C433DB for ; Fri, 15 Jan 2021 14:29:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F64523772 for ; Fri, 15 Jan 2021 14:29:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F64523772 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.68147.121926 (Exim 4.92) (envelope-from ) id 1l0Q5x-0000ue-K2; Fri, 15 Jan 2021 14:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 68147.121926; Fri, 15 Jan 2021 14:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l0Q5x-0000u3-GS; Fri, 15 Jan 2021 14:28:57 +0000 Received: by outflank-mailman (input) for mailman id 68147; Fri, 15 Jan 2021 14:28:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l0Q5v-0000sK-IQ for xen-devel@lists.xenproject.org; Fri, 15 Jan 2021 14:28:55 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e1e7d6d4-0fd2-4388-b1ed-e0d795e64495; Fri, 15 Jan 2021 14:28:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1e7d6d4-0fd2-4388-b1ed-e0d795e64495 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1610720934; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=OnkPplYvFhLEyw/OpHmkJSItrPz8rRm1vu7Brh6+KYM=; b=O+0yVmBKcB+Dt6AVopxByZkNOTBpGg0Erd/gvQcS540aeZXmMBXuMbbr nN0RreyouMr6yOfePrSx7g5PpkD20kIHL9POPzdunGSgWB4geEhTp1vyU ecmNv3mP71ei9LymHgxbNYNo/2EejSjJp43U6eufFvkFS4pNqkyh2mNyZ 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: JoZlehRoyqBWmLLp1bqGxM252AX3bxSwrfwA9pt+dR3g/TuNkMax8IK7ozJlao9aT3ynmBjHgd u+7zdZJKZwe7lv0V6ilGdaixtYYMNYYAy/P7Iq46vwzJex/2kC0WAII/Uf1G6jE98d4t2NTmZO cFCTeXNubGIMHM9iUGDf7VMZAnKvn9Y07F9SurQ8PXEzT474MFrFredu+u5nM2YGJtfG+hZKOu a/Q2ysTU492/EBomoHTHT1xQ5twBxx5uPi4jXHv3VjTF5nrHb1j7GjkDAN63ChT1L4kvqStIOf ypA= X-SBRS: 5.2 X-MesageID: 36468941 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.79,349,1602561600"; d="scan'208";a="36468941" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kidIuS8/xMmYzVRv6Vi7ycVls3PGG3KryfsE4+wSujexzxxnuY3+PCK0KvEg0Tf/NamyX0Z4qW50hustGp1PY+uSwr+BYCynfqyTozUDBkijkoA4K42vO3oXuVSkC5L2rJNVCrfIEGbfAKl7AyEsvMhtfLZyS3WQ38LAx4hrvFmtHjwmdDz/Qk7E1aR+ZeblbX82toNeyLikJ/EX7+1mt/fsBj/ML1H2WmqZwESl5JF5vAL0uwfvY/UQJsoD+aOssDfzPk4c/ejolsM2eBxzhxHEo3PzrGGV/vkolahzcxp4ruPClCplLF5EOtgAvXwGVtj0Tfmbp0n3xx+yfn7WrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAi4encjkLP3LlypbkVjVJWyr+I8zR85m/r5pmOXFOI=; b=JHOzQKvdBN5OeGot4UWq6MrhUdw4zKA5Tm9HpQ4cABVGbVBbyBjlSEAPDVM6iJ179SGENnDen9aU8ibQpDnLGMAAbhq5Nr5cGE3sYqN35dIpvYs6vPcXa+lZP8oWxUOLaiNv3QbEQ7xashAn1xUhY/ac5Sn5JoEvpw7ZTGkj5iO3VutSxD8ozrG9gnSUl2VbebLN3bJcpDkAi2zbu2bkFtyVF8CtTqSblFWF/XyEektUI3VdSTCMdAxodCE4mFjRRuQUuZdz9TiuRHzAJcYFdYK/xs6y3+lZ+7d9CaFJgQ+FM8yKPIQHE3QyDRiPmzrk6lnA5oiu0qZmcBcwSVkahQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAi4encjkLP3LlypbkVjVJWyr+I8zR85m/r5pmOXFOI=; b=IV8MyWl5PJnaRPRTXBazt9kDGdkI5DSoY6iVl5EgHedWOUKabduK9dHIhfuSfIJc8RCe9AECb4E08ElLqvkAIdwi1dDjN+U8/gZgWiKLTsXOTxj4E++4Fc6kQ+YAHwarJV8L39rJ5L80OgO9wh7oKrUwr+CM7sLet/nt9SGCdhA= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Kevin Tian , Paul Durrant Subject: [PATCH v2 0/4] x86/intr: guest interrupt handling fixes/cleanup Date: Fri, 15 Jan 2021 15:28:16 +0100 Message-ID: <20210115142820.35224-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.29.2 X-ClientProxiedBy: MR2P264CA0133.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc201b65-a2ea-4041-e6e8-08d8b961e19c X-MS-TrafficTypeDiagnostic: DM5PR03MB3147: X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7yXb3yRdoJ/g6Q67/nRSwAB53WNrvBdRZ2cOPzEyrazztwapHi3SHuMwLGSP8hX2vYVtqOVrRTqAUc0dnhsGyqIKrP6/DQTjpN0IbliSceii+4jLkzekjGIWsoLOjKQez4JnpV0p0wpTVeDZGEiLKG7y64hPsaD57iK6+HR0KrewJGc0dYQ+TakaZ81bHLQA9pK6bcE8tE3t2h78YGF7iWI1uLvLZoYEcD4fFzYuK6ClulnpaonxBhE3Fnna5GeHp5uiZO0PxIP59ZVGuHvxRlnMY2VDzWCSH0lrQuUgg2Li99EP0DWhsfvNbNw9TtQOYNUI63ER0lppbqqhRAusRha90oBUnoLBL60T5vW1lkz1mG6v9N+yjdNzYP1fMVxfEI/deY8bJmqTjtsxWIDFpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(6486002)(316002)(86362001)(83380400001)(4326008)(66946007)(6916009)(54906003)(1076003)(36756003)(6496006)(66476007)(66556008)(186003)(5660300002)(8936002)(2616005)(16526019)(478600001)(8676002)(956004)(2906002)(26005)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?RPAV9Xk8w+m54unpAv0s1BeZ4kT9Sg?= =?utf-8?q?WyDi0FduHmBgrG5ScwIwDr0Urnq8VOv25L72lfJ8POypNHbrdsmpljgDG5VixNrRy?= =?utf-8?q?8Edaakm+uVtxDk3DT34GScexv3LQyeL8nLdMkCob6jzOGK6xBge6Nn+bwZ5CciDC7?= =?utf-8?q?mieb5FkJXRrsOcFi0VOKLgKOmdF1LyXG2yB8Mr79PeqpLg0J4dAivELyNyaemLtao?= =?utf-8?q?Hy5x5dAAmPHOfO1ucw+w0zgIoAJoQIT37UJRQwbpljf4alPgd/HBN0JDdSsCX+yO+?= =?utf-8?q?B/68FQ2NL8/jCKQaqIwiHESUEZPL6TsJcdULs6KU/b+SXQn948vR/McyKshcEfkhG?= =?utf-8?q?D6Jaa/GIEshmxb40gS92EkntC8PsxjK6QMKaAPoboxjvR73ZobCkwjX7XLkY9PIMR?= =?utf-8?q?JPrkRbmJivEuxbSDJlaMzEmskFyk0Z/lB6Z5E/KhX4pqkGra3SUId0KRCKARsQily?= =?utf-8?q?Swd/dlXHbndtNbSNUyqOEWH7uFmYpNTuuPj6zr0KRp8DEOxnrOPlDUSiTr2tgywcS?= =?utf-8?q?yKfPhHb4ZR7zQoqhxOVsP1XA1BsdUWb2+Bd8mj1UrOXelDMouev9thSKUkHNZZ6bt?= =?utf-8?q?/7o8lPoicD9jpZKTTVeKsJuuc4K67AVl+VUMixffXjxmL9/ebJImA8+wOf/HFNyCd?= =?utf-8?q?gT7oY2aei5S6Rc+v6rsPPc+ZmmqGCl/U+UaWy2PWAw5uwlmEboazYOmDLFIKBwyvH?= =?utf-8?q?udh3Ka1tZGtlKru8IYWFUEob2F6fjd3Wz/xOo2lnsQ/ZMOACVEY5viW4ZUpNc3r0O?= =?utf-8?q?ijRkJ9uGrZUV4LgGD+3DAoXPiY8Bwm6l0QNqckExkOBoztkn+2AXyBtZp+Oxen2Iw?= =?utf-8?q?mVi5W/xSZ2ZEB/aEbIVBJd4y4HcuOnAz8skx2jU8sYEHOrFvOjlbkfDEg908g6GJG?= =?utf-8?q?nX8AKeSov+5fs3/DEuVvKBQS57nfjiZ3AZddCnLkKfLf+kkYj8y3AKsNarFXKpvQb?= =?utf-8?q?KDn9l5LylzUAmyeqLvT?= X-MS-Exchange-CrossTenant-Network-Message-Id: cc201b65-a2ea-4041-e6e8-08d8b961e19c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2021 14:28:52.2989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iFHgZ59Js26BWLFJG9ZbGr3QaUYFXMJ3lUNdushixntnsQiVV+bNmp6RbFx1srpiLrvdBWmTQJ8/HmiqioKOBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3147 X-OriginatorOrg: citrix.com Hello, The following series aims to fix some shortcomings of guest interrupt handling when using passthrough devices. The first 3 patches are bugfixes, which I think should solve the issue(s) that caused the dpci EOI timer to be introduced. However neither me nor others seem to be able to reproduce the original issue, so it's hard to tell. It's my opinion that we should remove the timer and see what explodes (if anything). That's the only way we will be able to figure out what the original issue was, and how to fix it without introducing yet another per-guest-irq related timer. Thanks, Roger. Roger Pau Monne (4): x86/vioapic: check IRR before attempting to inject interrupt after EOI x86/vioapic: issue EOI to dpci when switching pin to edge trigger mode x86/vpic: issue dpci EOI for cleared pins at ICW1 x86/dpci: remove the dpci EOI timer xen/arch/x86/hvm/vioapic.c | 13 +++- xen/arch/x86/hvm/vpic.c | 21 ++++++ xen/drivers/passthrough/vtd/x86/hvm.c | 3 - xen/drivers/passthrough/x86/hvm.c | 95 +-------------------------- xen/include/asm-x86/hvm/irq.h | 3 - xen/include/xen/iommu.h | 5 -- 6 files changed, 35 insertions(+), 105 deletions(-)