From patchwork Tue Jan 26 11:06:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Pau Monne X-Patchwork-Id: 12046123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC45C433E0 for ; Tue, 26 Jan 2021 11:08:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E22423104 for ; Tue, 26 Jan 2021 11:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E22423104 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.74838.134546 (Exim 4.92) (envelope-from ) id 1l4MCd-00016c-DH; Tue, 26 Jan 2021 11:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 74838.134546; Tue, 26 Jan 2021 11:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4MCd-00016V-9A; Tue, 26 Jan 2021 11:08:07 +0000 Received: by outflank-mailman (input) for mailman id 74838; Tue, 26 Jan 2021 11:08:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4MCc-00016Q-F7 for xen-devel@lists.xenproject.org; Tue, 26 Jan 2021 11:08:06 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 67c7d9ed-a01a-434e-a609-a4b0977faa8b; Tue, 26 Jan 2021 11:08:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67c7d9ed-a01a-434e-a609-a4b0977faa8b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1611659283; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=3Bjdf7c6T/C8vcbO1X5a2wgXcuVafuH6juWX+juRVfE=; b=M69Y0bPQfyf4M4YXxo4zUw73BFWJZi/kMrG7+bqXwGL4GywyJnGF+9do mPKOMxYiWM9VvlNrLBPPEaJwAmqmy39nLEM0+JKwTSEAV/OpYF5RRFpSN h/yU1ZP9Va+6ogiYOjFVjpvkZuV8ZNsgZX2ysY7ZbSx/bBXyOsV6woojM Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: BKSdcZ2iTRQWSy0qgx8LGtmfJ3zRy6U+/Yhs+FpHjOmS8hAPAUGiqvh7w8r/qTzm9xe6AOmY/3 l7aRUNUaFPGyXHmX53Cl+bG0fNj8HqlHvxxeepCvZkjZkBe4jEAoY0IoyKh7XB9cErgO17nd1t /uCenoTOF0Hgy/T0l+Q17SXT9uv8X9SEJHFjcCsXZib7uFRR/1O2I7KZFAp3WWDwCmrga+z2q3 /NgWAAtGfhYmI0abjxCDNJGiqHn+/1eYsLgjtCXgwfCyXdqR398jrOJywt5f+H8WLzC/WUWMp7 gGk= X-SBRS: 5.2 X-MesageID: 35903190 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.79,375,1602561600"; d="scan'208";a="35903190" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MqpqBTVhxRS6Na6ELYY7jFTpqAVMCS3+7lud24c22MADlf16qDrloE7hZqdoypFUuQHVdSDIcw2qRxQFENz+oDSK2zNQ1loi3kcmrBnzMrKViLZe4HaQaZMrvjQhxTn4ppcV2s/L8WZC3XtOOxHkn2chu2m847ti5UjoHeG47X9kIWvdmcrJH+FRFhTVLVisvIjs/vi94rQK2zCqcEPdpVi6SqCJBpy9HN8Vtu803UtfxPQfzp12Z3q4rSklGQmiDXReqMa3aI5XRkZePzNnHV2WOZmT3H6PwQ6hz8aLhrNH5r8bALl12xJin+KEAT+mmJxkvZ71yefi9m7X2UT85Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4BY+k+u1FJS5/nSTNcuCCrghG7rHss5ZnDW7+nDDT8=; b=YoKCTPiEN4AOpPZiFzvOJbnFLHSlDCkCLlN6V7ePFAuCTZXxo1DQJDz40Cg5GCvceepDGGHjcDe9cs3vpYpSvFqxHcgtcoGovnwFsC2BdjwMNXE2QOzdEUO8TzkjHmT+dy2vuMtDcxvnCa1GLJCivfhstS7imvLq7k6TKnXr1zYxCGCYZcL3LNdYWDVhGpTq148CvvbaafFf1jcuzjj9nXcSdZVBr4XfUgACEIK+yCZjrozrD/GRf44k/1frXXvmZMyOXfvN2eyn1HJGrdkTHdF7jTf/HxYTaXX1B3SXCrZYWwmEzpVYwXkMKrD0Y8VVSefQTLi0hKpb3Iz9XAF/Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4BY+k+u1FJS5/nSTNcuCCrghG7rHss5ZnDW7+nDDT8=; b=Ix6VzrLq8Q6iT/efuSXEtvRJAENeoyHKVUmno4kSBLUDJec1l5BqD9pHLWSyQzdhg/ISY1W/HJZ8sQD+Zxw0+NtsqDNbNAeJbj39iWuDfDN/oYDXiwHJeGN9eLkcSUC82w5VvQdjc4sWmm4yw5uAbFBwPC260ZfVcSueRCbgyHY= From: Roger Pau Monne To: CC: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant Subject: [PATCH 0/3] x86/intr: interrupt related fixes Date: Tue, 26 Jan 2021 12:06:03 +0100 Message-ID: <20210126110606.21741-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.29.2 X-ClientProxiedBy: PR3P189CA0023.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44e47477-52cf-4404-5322-08d8c1eaa454 X-MS-TrafficTypeDiagnostic: DM6PR03MB4059: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fB+Weq7GWK3OIeumSF6XxHOxgMfvyOqFpiwPpWUOfHoeb5O3u3IqZ4NzTWSzCtilctNZjF3JGjzZjfqWfl84KoTA2jN9tMEsRoftwGVrKGK+0r0jNt5hoog1xE+en8EMRq1rr0X6UAZ96QLpU6Z+jraTQSFw09YVz7CGsYUlAiwZTIHi6ugNuRwvMevIES/1aE2xtaS6CQXj7fOW1kfXaayazp6M2RwYVgakKnUqmGkwOP0KS5/grmQcSkwTc3v1xaxrF5/AGa1E6EyOJWMR7o5TrPSXz6WAIBKaAjYd3JwRdPfHoTJjJHqxWQm3zXa9MTISmqn+ITX2QZNWBEVFPGOFGmqSqGDV2yPPuPXi2rWz56PMssZVHyYuy3YhLeAUCGGrmxHaOVaI1kIgfrWv5H3nOovwkZ5o9s4DjlFQzGptj8Cvg68CeJLbXFL3ABa46dnAMRbLPuC26NuVMtJKiA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(4326008)(186003)(83380400001)(478600001)(26005)(5660300002)(2906002)(966005)(66476007)(54906003)(16526019)(6496006)(6486002)(4744005)(6666004)(956004)(8676002)(2616005)(86362001)(8936002)(36756003)(66946007)(6916009)(66556008)(1076003)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?BqfTgqy1XASr6l9un6Kak9rMoSnnZv?= =?utf-8?q?PFa8iBnBRzrBWTcPA87sxO5dXXB3KhkUcpXFY1p9eIP9z0mkuF2NMiRz9023rXBla?= =?utf-8?q?QtodeTvQBzuCEDrxbmoDSlSXm6Pj+QkSEhLbFAuJMtDtLHM6ptiWWc8amOeBw1iL/?= =?utf-8?q?FmMgc5dj7XcPYTRFEpWAa64cabSko8jZUcGBg+cOTC392oGjZLpv6YyXArHRKD4gU?= =?utf-8?q?shZ9IuMn04+D4l+sj/DP8BrfSFdyN4hPWEoMsyuZfWAxJSypzzH3n9mjxUDmXh5DE?= =?utf-8?q?SVXomMkxHReuxnlcjT69/ECRJkFkJnhqa4RjrLye6ZGke/Y4UzPi7AcSh2H72+zYe?= =?utf-8?q?ispglUhmp/Bugzx2hHtOx9muyH024ZYkZKJTAAbvsh54HXcReRGPPVIsTE16RnF2j?= =?utf-8?q?dsyCKhYrUt8M9U8kLBClzztmLgPp8rNv8Y4MS/fOxdQv6u5iI0qptX1o2YmlDgdXe?= =?utf-8?q?ZGHijuzSH7p9UXEhUwU0FzouPByywrLnwQRuiae9bI3XtlqwWJF2wPBlyT5r85BcJ?= =?utf-8?q?gCB7tAktPWu+rk+a71OBMNqBvIaxtBAabQdod1LvnGd5nfcyVFV417crZUPVKz+Yv?= =?utf-8?q?O9c0fHneEQ8PnxKgUIg60UPD5W/9wNWK3++5ZOTWLKgusPFdGTWScbtH9xktKJjWk?= =?utf-8?q?n1eoHdYF5LpW5M8q1aUkux/t6ajeMfgDH97H+zGZ37/H97kdx6zL7DAG4sWOrGn+u?= =?utf-8?q?Gnv5SyBrlZjTR/9KC2FRr+OcZNvkMKm+lRral4KIgnbKWYR+cKlvfvNn+QDOJC251?= =?utf-8?q?Jg04m0p3KI8WYDTJtoGgtsg76s9ckMKNH/IodnyE8ihSYJKplZlcLVbWsrytHIkgi?= =?utf-8?q?okMhpE8GEHGciGRuKgZw1v8U4VM631EoPF+btPF298JGmvR95MhSoJa6GOXba6ub5?= =?utf-8?q?EpN+njEhi/13gGjnko7b2nXztyjOQnqt9zLmcLBOLTQvx+uJhnJ+VC7xgL3wS6Nwr?= =?utf-8?q?1n59F9/HBplC8xMSJbO1VPcSEFQweKchuNUM7X8HWrOh7lbLRIwFUiwEwTmazVhhR?= =?utf-8?q?ZZtsznH+NWAo5cS+pV?= X-MS-Exchange-CrossTenant-Network-Message-Id: 44e47477-52cf-4404-5322-08d8c1eaa454 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2021 11:07:59.7408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tbEnksj5NM3pdcnDCNrDcj7oB/XCAFOeyYfjvKW92SAnXT1A/GsPwgTBBb4gYG4AXjfz1HCGtRbaVd9xU67CDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4059 X-OriginatorOrg: citrix.com Hello, This series has originated from the failure discovered by osstest in: https://lore.kernel.org/xen-devel/E1l1vyr-00074y-8j@osstest.test-lab.xenproject.org/ The commit pointed by osstest is correct, but it triggers an underlying shortcoming of the vPCI MSI handling which is fixed in patch 3. Patches 1 and 2 are small bugfixes found in the process of diagnosing the issue. Thanks, Roger. Roger Pau Monne (3): x86/irq: remove duplicated clear_domain_irq_pirq calls x86/irq: don't disable domain MSI IRQ on force unbind x86/vmsi: tolerate unsupported MSI address/data fields xen/arch/x86/hvm/vmsi.c | 93 +++++++++++++++++++----------------- xen/arch/x86/irq.c | 8 +--- xen/drivers/vpci/msi.c | 3 +- xen/include/asm-x86/hvm/io.h | 1 + xen/include/xen/vpci.h | 3 +- 5 files changed, 52 insertions(+), 56 deletions(-)