Message ID | 20220130084343.19070-1-jgross@suse.com (mailing list archive) |
---|---|
Headers | show |
Series | tools: remove include/xen-external directory | expand |
On Sun, Jan 30, 2022 at 09:43:38AM +0100, Juergen Gross wrote: > The tools/include/xen-external directory contains a header file from > FreeBSD used to generate Xen header files. This series is replacing the > complete directory by a single header with the same semantics. > > Juergen Gross (5): > tools/libs/light: replace _libxl_list.h with _xen_list.h > tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h > tools/libs/evtchn: use _xen_list.h > tools/include: remove xen-external directory > > tools/include/_xen_list.h | 523 +++++++++ > tools/include/libxl.h | 4 +- Hi, While this looks like a good cleanup, I'm not sure whether this is a good idea with regards to the change in libxl's public headers. The LIBXL_TAILQ_* macro are exposed via libxl.h, and it seems that using `libxl_event.link` is explicitly allowed (via "libxl_types.idl") to make a list of event in a application. But there isn't really a reason to use the macro. I didn't find any use of the macros in libvirt, so maybe it's fine to change it? What do people think? Cheers,
On 02.02.22 12:53, Anthony PERARD wrote: > On Sun, Jan 30, 2022 at 09:43:38AM +0100, Juergen Gross wrote: >> The tools/include/xen-external directory contains a header file from >> FreeBSD used to generate Xen header files. This series is replacing the >> complete directory by a single header with the same semantics. >> >> Juergen Gross (5): >> tools/libs/light: replace _libxl_list.h with _xen_list.h >> tools/libs/toolcore: replace _xentoolcore_list.h with _xen_list.h >> tools/libs/evtchn: use _xen_list.h >> tools/include: remove xen-external directory >> >> tools/include/_xen_list.h | 523 +++++++++ >> tools/include/libxl.h | 4 +- > > Hi, > > While this looks like a good cleanup, I'm not sure whether this is a > good idea with regards to the change in libxl's public headers. > > The LIBXL_TAILQ_* macro are exposed via libxl.h, and it seems that using > `libxl_event.link` is explicitly allowed (via "libxl_types.idl") to make > a list of event in a application. But there isn't really a reason to use > the macro. > > I didn't find any use of the macros in libvirt, so maybe it's fine to > change it? > > What do people think? If thought to be needed I could still add the LIBXL_TAILQ_* macros to libxl.h by defining them as aliases of the XEN_TAILQ_* macros. Juergen