From patchwork Thu Mar 24 14:01:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 12790697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D0F5C433F5 for ; Thu, 24 Mar 2022 14:02:01 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.294327.500409 (Exim 4.92) (envelope-from ) id 1nXO26-0008IO-SJ; Thu, 24 Mar 2022 14:01:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 294327.500409; Thu, 24 Mar 2022 14:01:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nXO26-0008IH-Ou; Thu, 24 Mar 2022 14:01:46 +0000 Received: by outflank-mailman (input) for mailman id 294327; Thu, 24 Mar 2022 14:01:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nXO24-0008Hr-Pq for xen-devel@lists.xenproject.org; Thu, 24 Mar 2022 14:01:44 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef74ed2b-ab7a-11ec-8fbc-03012f2f19d4; Thu, 24 Mar 2022 15:01:43 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0844F210DD; Thu, 24 Mar 2022 14:01:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A80912FF7; Thu, 24 Mar 2022 14:01:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KkF/JMZ5PGKeegAAMHmgww (envelope-from ); Thu, 24 Mar 2022 14:01:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef74ed2b-ab7a-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1648130503; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eM4dyQhe9WvzPlwymOvxwvqkXllRvlqS9zeEmc6DRmM=; b=GzCYuKw+K3CMDWtdCcsAgp0BXr9SpHMhaiV1ShcLbd0AQOHJmT1aQXvfQ5PsXZw/gIUVTK d0Zbx7jX0cXsKF98atNlcdGTNiYRnb7uq31eRgBDd6Ed12tmthbNOANsj2qQkf2YH6edaL EaYMuDZmhzfA+b/bwAobv2hLhFN/VT0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" Subject: [PATCH v6 0/9] xen: drop hypercall function tables Date: Thu, 24 Mar 2022 15:01:30 +0100 Message-Id: <20220324140139.5899-1-jgross@suse.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 In order to avoid indirect function calls on the hypercall path as much as possible this series is removing the hypercall function tables and is replacing the hypercall handler calls via the function array by automatically generated call macros. Another by-product of generating the call macros is the automatic generating of the hypercall handler prototypes from the same data base which is used to generate the macros. This has the additional advantage of using type safe calls of the handlers and to ensure related handler (e.g. PV and HVM ones) share the same prototypes. A very brief performance test (parallel build of the Xen hypervisor in a 6 vcpu guest) showed a very slim improvement (less than 1%) of the performance with the patches applied. The test was performed using a PV and a PVH guest. Changes in V2: - new patches 6, 14, 15 - patch 7: support hypercall priorities for faster code - comments addressed Changes in V3: - patches 1 and 4 removed as already applied - comments addressed Changes in V4: - 5 patches removed al already applied - new patches 1, 3 and 11 - avoid switching Arm hypercall handlers to return long (no change of handlers returning long already) Changes in V5: - patch 3 of V4 has been applied already - comments addressed - rebase Changes in V6: - patch 1 of V5 has been applied already - fix of a rebase artifact Juergen Gross (9): xen: move do_vcpu_op() to arch specific code xen: harmonize return types of hypercall handlers xen: don't include asm/hypercall.h from C sources xen: include compat/platform.h from hypercall.h xen: generate hypercall interface related code xen: use generated prototypes for hypercall handlers xen/x86: call hypercall handlers via generated macro xen/arm: call hypercall handlers via generated macro xen/x86: remove cf_check attribute from hypercall handlers .gitignore | 1 + xen/arch/arm/domain.c | 15 +- xen/arch/arm/hvm.c | 3 +- xen/arch/arm/include/asm/hypercall.h | 7 +- xen/arch/arm/platform_hypercall.c | 1 + xen/arch/arm/traps.c | 117 ++------- xen/arch/x86/compat.c | 6 +- xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/vpmu.c | 3 +- xen/arch/x86/domain.c | 11 +- xen/arch/x86/domctl.c | 4 +- xen/arch/x86/hvm/dm.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/hypercall.c | 177 ++----------- xen/arch/x86/hypercall.c | 59 ----- xen/arch/x86/include/asm/hypercall.h | 201 ++++----------- xen/arch/x86/include/asm/paging.h | 3 - xen/arch/x86/mm.c | 13 +- xen/arch/x86/mm/paging.c | 3 +- xen/arch/x86/physdev.c | 2 +- xen/arch/x86/platform_hypercall.c | 3 +- xen/arch/x86/pv/callback.c | 26 +- xen/arch/x86/pv/descriptor-tables.c | 8 +- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/arch/x86/pv/hypercall.c | 187 ++------------ xen/arch/x86/pv/iret.c | 5 +- xen/arch/x86/pv/misc-hypercalls.c | 22 +- xen/arch/x86/pv/shim.c | 4 +- xen/arch/x86/traps.c | 2 +- xen/arch/x86/x86_64/compat/mm.c | 3 +- xen/arch/x86/x86_64/domain.c | 16 +- xen/arch/x86/x86_64/mm.c | 2 - xen/arch/x86/x86_64/platform_hypercall.c | 1 - xen/common/argo.c | 8 +- xen/common/compat/domain.c | 15 +- xen/common/compat/grant_table.c | 3 +- xen/common/compat/kernel.c | 2 +- xen/common/compat/memory.c | 3 +- xen/common/dm.c | 2 +- xen/common/domain.c | 14 +- xen/common/domctl.c | 2 +- xen/common/event_channel.c | 3 +- xen/common/grant_table.c | 4 +- xen/common/hypfs.c | 2 +- xen/common/kernel.c | 2 +- xen/common/kexec.c | 6 +- xen/common/memory.c | 2 +- xen/common/multicall.c | 4 +- xen/common/sched/compat.c | 2 +- xen/common/sched/core.c | 4 +- xen/common/sysctl.c | 2 +- xen/common/xenoprof.c | 2 +- xen/drivers/char/console.c | 2 +- xen/include/Makefile | 13 + xen/include/hypercall-defs.c | 285 ++++++++++++++++++++ xen/include/xen/hypercall.h | 185 +------------ xen/scripts/gen_hypercall.awk | 314 +++++++++++++++++++++++ xen/xsm/xsm_core.c | 4 +- 58 files changed, 861 insertions(+), 937 deletions(-) create mode 100644 xen/include/hypercall-defs.c create mode 100644 xen/scripts/gen_hypercall.awk