mbox series

[XEN,v2,0/4] Some improvement for gitlab CI jobs

Message ID 20220721124602.9910-1-anthony.perard@citrix.com (mailing list archive)
Headers show
Series Some improvement for gitlab CI jobs | expand

Message

Anthony PERARD July 21, 2022, 12:45 p.m. UTC
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2

v2:
- rebased

Allow build and test jobs to run concurently.

Avoid running "test artifact" jobs on branch "master" and other, when test jobs
aren't runned.

Anthony PERARD (4):
  automation: fix typo in .gcc-tmpl
  automation: add a templates for test jobs
  automation: only run test artifact jobs when needed
  automation: use "needs" instead of "dependencies" for test jobs

 automation/gitlab-ci/build.yaml | 20 ++++---
 automation/gitlab-ci/test.yaml  | 99 +++++++++------------------------
 2 files changed, 40 insertions(+), 79 deletions(-)

Comments

Andrew Cooper July 21, 2022, 1:03 p.m. UTC | #1
On 21/07/2022 13:45, Anthony Perard wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2
>
> v2:
> - rebased
>
> Allow build and test jobs to run concurently.
>
> Avoid running "test artifact" jobs on branch "master" and other, when test jobs
> aren't runned.
>
> Anthony PERARD (4):
>   automation: fix typo in .gcc-tmpl
>   automation: add a templates for test jobs
>   automation: only run test artifact jobs when needed
>   automation: use "needs" instead of "dependencies" for test jobs

LGTM.  Got a CI run of these?

~Andrew
Anthony PERARD July 21, 2022, 1:09 p.m. UTC | #2
On Thu, Jul 21, 2022 at 01:03:41PM +0000, Andrew Cooper wrote:
> On 21/07/2022 13:45, Anthony Perard wrote:
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2
> >
> > v2:
> > - rebased
> >
> > Allow build and test jobs to run concurently.
> >
> > Avoid running "test artifact" jobs on branch "master" and other, when test jobs
> > aren't runned.
> >
> > Anthony PERARD (4):
> >   automation: fix typo in .gcc-tmpl
> >   automation: add a templates for test jobs
> >   automation: only run test artifact jobs when needed
> >   automation: use "needs" instead of "dependencies" for test jobs
> 
> LGTM.  Got a CI run of these?

Yes,

patchew's commit is in progress:
https://gitlab.com/xen-project/patchew/xen/-/pipelines/593479157

A run in my private repo:
https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/593340820
(no failure due to this change)

Running on one of my branch called "stable-wip" doesn't create any
pipeline, as expected.
Andrew Cooper July 21, 2022, 1:14 p.m. UTC | #3
On 21/07/2022 14:09, Anthony PERARD wrote:
> On Thu, Jul 21, 2022 at 01:03:41PM +0000, Andrew Cooper wrote:
>> On 21/07/2022 13:45, Anthony Perard wrote:
>>> Patch series available in this git branch:
>>> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2
>>>
>>> v2:
>>> - rebased
>>>
>>> Allow build and test jobs to run concurently.
>>>
>>> Avoid running "test artifact" jobs on branch "master" and other, when test jobs
>>> aren't runned.
>>>
>>> Anthony PERARD (4):
>>>   automation: fix typo in .gcc-tmpl
>>>   automation: add a templates for test jobs
>>>   automation: only run test artifact jobs when needed
>>>   automation: use "needs" instead of "dependencies" for test jobs
>> LGTM.  Got a CI run of these?
> Yes,
>
> patchew's commit is in progress:
> https://gitlab.com/xen-project/patchew/xen/-/pipelines/593479157
>
> A run in my private repo:
> https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/593340820
> (no failure due to this change)
>
> Running on one of my branch called "stable-wip" doesn't create any
> pipeline, as expected.
>


Cool.  I'll get these 4 committed in due course.

One thing, looking at this right now.  Is there anything we can we
prioritize the builds used to run the qemu smoke tests?  We've currently
got x86 smoke tests waiting while the workers are building hypervisors
unrelated to the tests.

~Andrew
Anthony PERARD July 21, 2022, 1:43 p.m. UTC | #4
On Thu, Jul 21, 2022 at 01:14:41PM +0000, Andrew Cooper wrote:
> On 21/07/2022 14:09, Anthony PERARD wrote:
> > On Thu, Jul 21, 2022 at 01:03:41PM +0000, Andrew Cooper wrote:
> >> On 21/07/2022 13:45, Anthony Perard wrote:
> >>> Patch series available in this git branch:
> >>> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2
> >>>
> >>> v2:
> >>> - rebased
> >>>
> >>> Allow build and test jobs to run concurently.
> >>>
> >>> Avoid running "test artifact" jobs on branch "master" and other, when test jobs
> >>> aren't runned.
> >>>
> >>> Anthony PERARD (4):
> >>>   automation: fix typo in .gcc-tmpl
> >>>   automation: add a templates for test jobs
> >>>   automation: only run test artifact jobs when needed
> >>>   automation: use "needs" instead of "dependencies" for test jobs
> >> LGTM.  Got a CI run of these?
> > Yes,
> >
> > patchew's commit is in progress:
> > https://gitlab.com/xen-project/patchew/xen/-/pipelines/593479157
> >
> > A run in my private repo:
> > https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/593340820
> > (no failure due to this change)
> >
> > Running on one of my branch called "stable-wip" doesn't create any
> > pipeline, as expected.
> >
> 
> 
> Cool.  I'll get these 4 committed in due course.

Thanks.

> One thing, looking at this right now.  Is there anything we can we
> prioritize the builds used to run the qemu smoke tests?  We've currently
> got x86 smoke tests waiting while the workers are building hypervisors
> unrelated to the tests.

I think the only way would be to create a new stage before the "build"
stage which would have all the build jobs needed by the tests jobs. But
that kind of became more complicated.