mbox series

[XEN,for-4.17,v2,0/6] Fixing some licences issue in public headers

Message ID 20221103115204.49610-1-anthony.perard@citrix.com (mailing list archive)
Headers show
Series Fixing some licences issue in public headers | expand

Message

Anthony PERARD Nov. 3, 2022, 11:51 a.m. UTC
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.licences-fix-public-headers-v2

Hi,

Andrew pointed out some licences issue:

https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-6137005add77@citrix.com/T/#u
tracked here: https://gitlab.com/xen-project/xen/-/issues/35

So I attempt to fix them with this series.

For 4.17:
    This mostly change "documentation" so little risk for those patch, except
    "xen-foreign: Capture licences from the input headers" which changes
    "mkheader.py" which could generate broken headers.

Anthony PERARD (6):
  xen: Add licence information to public/errno.h
  xen: Used SPDX identifier in some public headers
  tools/include/xen-foreign: Add SPDX identifier to generated headers
  xen: Add licence header to device_tree_defs.h
  Rework COPYING installed in /usr/include/xen/, due to several licences
  xen: Used SPDX identifier in public headers

 tools/include/Makefile                       |  1 -
 xen/include/public/arch-arm.h                | 19 +-------------
 xen/include/public/arch-arm/hvm/save.h       | 19 +-------------
 xen/include/public/arch-arm/smccc.h          | 19 +-------------
 xen/include/public/arch-x86/cpufeatureset.h  | 19 +-------------
 xen/include/public/arch-x86/cpuid.h          | 19 +-------------
 xen/include/public/arch-x86/guest-acpi.h     | 19 +-------------
 xen/include/public/arch-x86/hvm/save.h       | 19 +-------------
 xen/include/public/arch-x86/hvm/start_info.h | 19 +-------------
 xen/include/public/arch-x86/pmu.h            | 19 +-------------
 xen/include/public/arch-x86/xen-mca.h        | 19 +-------------
 xen/include/public/arch-x86/xen-x86_32.h     | 19 +-------------
 xen/include/public/arch-x86/xen-x86_64.h     | 19 +-------------
 xen/include/public/arch-x86/xen.h            | 19 +-------------
 xen/include/public/arch-x86_32.h             | 19 +-------------
 xen/include/public/arch-x86_64.h             | 19 +-------------
 xen/include/public/argo.h                    | 19 +-------------
 xen/include/public/callback.h                | 19 +-------------
 xen/include/public/device_tree_defs.h        |  6 +++++
 xen/include/public/dom0_ops.h                | 19 +-------------
 xen/include/public/domctl.h                  | 19 +-------------
 xen/include/public/elfnote.h                 | 19 +-------------
 xen/include/public/errno.h                   |  2 ++
 xen/include/public/event_channel.h           | 19 +-------------
 xen/include/public/features.h                | 19 +-------------
 xen/include/public/grant_table.h             | 19 +-------------
 xen/include/public/hvm/dm_op.h               | 19 +-------------
 xen/include/public/hvm/e820.h                | 19 +-------------
 xen/include/public/hvm/hvm_info_table.h      | 19 +-------------
 xen/include/public/hvm/hvm_op.h              | 19 +-------------
 xen/include/public/hvm/hvm_vcpu.h            | 19 +-------------
 xen/include/public/hvm/hvm_xs_strings.h      | 19 +-------------
 xen/include/public/hvm/ioreq.h               | 19 +-------------
 xen/include/public/hvm/params.h              | 19 +-------------
 xen/include/public/hvm/pvdrivers.h           | 19 +-------------
 xen/include/public/hvm/save.h                | 19 +-------------
 xen/include/public/hypfs.h                   | 19 +-------------
 xen/include/public/io/9pfs.h                 | 19 +-------------
 xen/include/public/io/blkif.h                | 19 +-------------
 xen/include/public/io/cameraif.h             | 19 +-------------
 xen/include/public/io/console.h              | 19 +-------------
 xen/include/public/io/displif.h              | 19 +-------------
 xen/include/public/io/fbif.h                 | 19 +-------------
 xen/include/public/io/fsif.h                 | 19 +-------------
 xen/include/public/io/kbdif.h                | 19 +-------------
 xen/include/public/io/libxenvchan.h          | 19 +-------------
 xen/include/public/io/netif.h                | 19 +-------------
 xen/include/public/io/pciif.h                | 19 +-------------
 xen/include/public/io/protocols.h            | 19 +-------------
 xen/include/public/io/pvcalls.h              | 19 +-------------
 xen/include/public/io/ring.h                 | 19 +-------------
 xen/include/public/io/sndif.h                | 19 +-------------
 xen/include/public/io/tpmif.h                | 19 +-------------
 xen/include/public/io/usbif.h                | 19 +-------------
 xen/include/public/io/vscsiif.h              | 19 +-------------
 xen/include/public/io/xenbus.h               | 19 +-------------
 xen/include/public/io/xs_wire.h              | 19 +-------------
 xen/include/public/kexec.h                   | 19 +-------------
 xen/include/public/memory.h                  | 19 +-------------
 xen/include/public/nmi.h                     | 19 +-------------
 xen/include/public/physdev.h                 | 19 +-------------
 xen/include/public/platform.h                | 19 +-------------
 xen/include/public/pmu.h                     | 19 +-------------
 xen/include/public/sched.h                   | 19 +-------------
 xen/include/public/sysctl.h                  | 19 +-------------
 xen/include/public/tmem.h                    | 19 +-------------
 xen/include/public/trace.h                   | 19 +-------------
 xen/include/public/vcpu.h                    | 19 +-------------
 xen/include/public/version.h                 | 19 +-------------
 xen/include/public/vm_event.h                | 19 +-------------
 xen/include/public/xen-compat.h              | 19 +-------------
 xen/include/public/xen.h                     | 19 +-------------
 xen/include/public/xencomm.h                 | 19 +-------------
 xen/include/public/xenoprof.h                | 19 +-------------
 xen/include/public/xsm/flask_op.h            | 19 +-------------
 tools/include/xen-foreign/mkheader.py        | 23 ++++++++++++++---
 tools/include/xen/COPYING                    | 26 ++++++++++++++++++++
 77 files changed, 125 insertions(+), 1301 deletions(-)
 create mode 100644 tools/include/xen/COPYING

Comments

Stefano Stabellini Nov. 10, 2022, 11:17 p.m. UTC | #1
Hi Anthony,

Thank you for doing this, it was much needed!


Hi all,

I think if we are going to commit this series for 4.17 then I would
suggest to also commit patches 1-3 of my "introduce SPDX" series:

https://marc.info/?l=xen-devel&m=166562222522996

They are already acked/reviewed and are zero risk as they don't actually
change any of the headers.


For clarify, I don't mean to cause any trouble to this series. I am also
happy to have this series committed in 4.17 without "introduce SPDX".

Cheers,

Stefano



On Thu, 3 Nov 2022, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.licences-fix-public-headers-v2
> 
> Hi,
> 
> Andrew pointed out some licences issue:
> 
> https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-6137005add77@citrix.com/T/#u
> tracked here: https://gitlab.com/xen-project/xen/-/issues/35
> 
> So I attempt to fix them with this series.
> 
> For 4.17:
>     This mostly change "documentation" so little risk for those patch, except
>     "xen-foreign: Capture licences from the input headers" which changes
>     "mkheader.py" which could generate broken headers.
> 
> Anthony PERARD (6):
>   xen: Add licence information to public/errno.h
>   xen: Used SPDX identifier in some public headers
>   tools/include/xen-foreign: Add SPDX identifier to generated headers
>   xen: Add licence header to device_tree_defs.h
>   Rework COPYING installed in /usr/include/xen/, due to several licences
>   xen: Used SPDX identifier in public headers
> 
>  tools/include/Makefile                       |  1 -
>  xen/include/public/arch-arm.h                | 19 +-------------
>  xen/include/public/arch-arm/hvm/save.h       | 19 +-------------
>  xen/include/public/arch-arm/smccc.h          | 19 +-------------
>  xen/include/public/arch-x86/cpufeatureset.h  | 19 +-------------
>  xen/include/public/arch-x86/cpuid.h          | 19 +-------------
>  xen/include/public/arch-x86/guest-acpi.h     | 19 +-------------
>  xen/include/public/arch-x86/hvm/save.h       | 19 +-------------
>  xen/include/public/arch-x86/hvm/start_info.h | 19 +-------------
>  xen/include/public/arch-x86/pmu.h            | 19 +-------------
>  xen/include/public/arch-x86/xen-mca.h        | 19 +-------------
>  xen/include/public/arch-x86/xen-x86_32.h     | 19 +-------------
>  xen/include/public/arch-x86/xen-x86_64.h     | 19 +-------------
>  xen/include/public/arch-x86/xen.h            | 19 +-------------
>  xen/include/public/arch-x86_32.h             | 19 +-------------
>  xen/include/public/arch-x86_64.h             | 19 +-------------
>  xen/include/public/argo.h                    | 19 +-------------
>  xen/include/public/callback.h                | 19 +-------------
>  xen/include/public/device_tree_defs.h        |  6 +++++
>  xen/include/public/dom0_ops.h                | 19 +-------------
>  xen/include/public/domctl.h                  | 19 +-------------
>  xen/include/public/elfnote.h                 | 19 +-------------
>  xen/include/public/errno.h                   |  2 ++
>  xen/include/public/event_channel.h           | 19 +-------------
>  xen/include/public/features.h                | 19 +-------------
>  xen/include/public/grant_table.h             | 19 +-------------
>  xen/include/public/hvm/dm_op.h               | 19 +-------------
>  xen/include/public/hvm/e820.h                | 19 +-------------
>  xen/include/public/hvm/hvm_info_table.h      | 19 +-------------
>  xen/include/public/hvm/hvm_op.h              | 19 +-------------
>  xen/include/public/hvm/hvm_vcpu.h            | 19 +-------------
>  xen/include/public/hvm/hvm_xs_strings.h      | 19 +-------------
>  xen/include/public/hvm/ioreq.h               | 19 +-------------
>  xen/include/public/hvm/params.h              | 19 +-------------
>  xen/include/public/hvm/pvdrivers.h           | 19 +-------------
>  xen/include/public/hvm/save.h                | 19 +-------------
>  xen/include/public/hypfs.h                   | 19 +-------------
>  xen/include/public/io/9pfs.h                 | 19 +-------------
>  xen/include/public/io/blkif.h                | 19 +-------------
>  xen/include/public/io/cameraif.h             | 19 +-------------
>  xen/include/public/io/console.h              | 19 +-------------
>  xen/include/public/io/displif.h              | 19 +-------------
>  xen/include/public/io/fbif.h                 | 19 +-------------
>  xen/include/public/io/fsif.h                 | 19 +-------------
>  xen/include/public/io/kbdif.h                | 19 +-------------
>  xen/include/public/io/libxenvchan.h          | 19 +-------------
>  xen/include/public/io/netif.h                | 19 +-------------
>  xen/include/public/io/pciif.h                | 19 +-------------
>  xen/include/public/io/protocols.h            | 19 +-------------
>  xen/include/public/io/pvcalls.h              | 19 +-------------
>  xen/include/public/io/ring.h                 | 19 +-------------
>  xen/include/public/io/sndif.h                | 19 +-------------
>  xen/include/public/io/tpmif.h                | 19 +-------------
>  xen/include/public/io/usbif.h                | 19 +-------------
>  xen/include/public/io/vscsiif.h              | 19 +-------------
>  xen/include/public/io/xenbus.h               | 19 +-------------
>  xen/include/public/io/xs_wire.h              | 19 +-------------
>  xen/include/public/kexec.h                   | 19 +-------------
>  xen/include/public/memory.h                  | 19 +-------------
>  xen/include/public/nmi.h                     | 19 +-------------
>  xen/include/public/physdev.h                 | 19 +-------------
>  xen/include/public/platform.h                | 19 +-------------
>  xen/include/public/pmu.h                     | 19 +-------------
>  xen/include/public/sched.h                   | 19 +-------------
>  xen/include/public/sysctl.h                  | 19 +-------------
>  xen/include/public/tmem.h                    | 19 +-------------
>  xen/include/public/trace.h                   | 19 +-------------
>  xen/include/public/vcpu.h                    | 19 +-------------
>  xen/include/public/version.h                 | 19 +-------------
>  xen/include/public/vm_event.h                | 19 +-------------
>  xen/include/public/xen-compat.h              | 19 +-------------
>  xen/include/public/xen.h                     | 19 +-------------
>  xen/include/public/xencomm.h                 | 19 +-------------
>  xen/include/public/xenoprof.h                | 19 +-------------
>  xen/include/public/xsm/flask_op.h            | 19 +-------------
>  tools/include/xen-foreign/mkheader.py        | 23 ++++++++++++++---
>  tools/include/xen/COPYING                    | 26 ++++++++++++++++++++
>  77 files changed, 125 insertions(+), 1301 deletions(-)
>  create mode 100644 tools/include/xen/COPYING
> 
> -- 
> Anthony PERARD
>
Henry Wang Nov. 11, 2022, 11:28 a.m. UTC | #2
Hi Stefano,

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@kernel.org>
> Hi all,
> 
> I think if we are going to commit this series for 4.17 then I would
> suggest to also commit patches 1-3 of my "introduce SPDX" series:
> 
> https://marc.info/?l=xen-devel&m=166562222522996
> 
> They are already acked/reviewed and are zero risk as they don't actually
> change any of the headers.

After some thinking and discussion I would like to follow your suggestion in
here. So for the first 3 patches from your "introduce SPDX" series:

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

I will need some more time to figure out some uncertain part from Anthony's
series about the relicensing of device_tree_defs.h [1] before providing my
release ack there.

[1] https://lore.kernel.org/xen-devel/fad0265d-a736-5135-b5ea-3735a8bc72da@xen.org/

Kind regards,
Henry
Stefano Stabellini Nov. 11, 2022, 10:18 p.m. UTC | #3
On Fri, 11 Nov 2022, Henry Wang wrote:
> Hi Stefano,
> 
> > -----Original Message-----
> > From: Stefano Stabellini <sstabellini@kernel.org>
> > Hi all,
> > 
> > I think if we are going to commit this series for 4.17 then I would
> > suggest to also commit patches 1-3 of my "introduce SPDX" series:
> > 
> > https://marc.info/?l=xen-devel&m=166562222522996
> > 
> > They are already acked/reviewed and are zero risk as they don't actually
> > change any of the headers.
> 
> After some thinking and discussion I would like to follow your suggestion in
> here. So for the first 3 patches from your "introduce SPDX" series:
> 
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks, I pushed the first 3 patches.
Henry Wang Nov. 16, 2022, 12:35 a.m. UTC | #4
Hi Anthony,

> -----Original Message-----
> From: Anthony PERARD <anthony.perard@citrix.com>
> Subject: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public
> headers
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> br.licences-fix-public-headers-v2
> 
> Hi,
> 
> Andrew pointed out some licences issue:
> 
> https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-
> 6137005add77@citrix.com/T/#u
> tracked here: https://gitlab.com/xen-project/xen/-/issues/35
> 
> So I attempt to fix them with this series.
> 
> For 4.17:
>     This mostly change "documentation" so little risk for those patch, except
>     "xen-foreign: Capture licences from the input headers" which changes
>     "mkheader.py" which could generate broken headers.

Yes, and I agree this series should go into the 4.17 to resolve one of the
release blocker pointed out by Andrew:
https://gitlab.com/xen-project/xen/-/issues/35

> 
> Anthony PERARD (6):
>   xen: Add licence information to public/errno.h
>   xen: Used SPDX identifier in some public headers
>   tools/include/xen-foreign: Add SPDX identifier to generated headers
>   xen: Add licence header to device_tree_defs.h

As Grant Likely from Linaro has confirmed the license change, for the
whole series:

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Great thanks for taking care of this issue.

Kind regards,
Henry


>   Rework COPYING installed in /usr/include/xen/, due to several licences
>   xen: Used SPDX identifier in public headers
> 
>  tools/include/Makefile                       |  1 -
>  xen/include/public/arch-arm.h                | 19 +-------------
>  xen/include/public/arch-arm/hvm/save.h       | 19 +-------------
>  xen/include/public/arch-arm/smccc.h          | 19 +-------------
>  xen/include/public/arch-x86/cpufeatureset.h  | 19 +-------------
>  xen/include/public/arch-x86/cpuid.h          | 19 +-------------
>  xen/include/public/arch-x86/guest-acpi.h     | 19 +-------------
>  xen/include/public/arch-x86/hvm/save.h       | 19 +-------------
>  xen/include/public/arch-x86/hvm/start_info.h | 19 +-------------
>  xen/include/public/arch-x86/pmu.h            | 19 +-------------
>  xen/include/public/arch-x86/xen-mca.h        | 19 +-------------
>  xen/include/public/arch-x86/xen-x86_32.h     | 19 +-------------
>  xen/include/public/arch-x86/xen-x86_64.h     | 19 +-------------
>  xen/include/public/arch-x86/xen.h            | 19 +-------------
>  xen/include/public/arch-x86_32.h             | 19 +-------------
>  xen/include/public/arch-x86_64.h             | 19 +-------------
>  xen/include/public/argo.h                    | 19 +-------------
>  xen/include/public/callback.h                | 19 +-------------
>  xen/include/public/device_tree_defs.h        |  6 +++++
>  xen/include/public/dom0_ops.h                | 19 +-------------
>  xen/include/public/domctl.h                  | 19 +-------------
>  xen/include/public/elfnote.h                 | 19 +-------------
>  xen/include/public/errno.h                   |  2 ++
>  xen/include/public/event_channel.h           | 19 +-------------
>  xen/include/public/features.h                | 19 +-------------
>  xen/include/public/grant_table.h             | 19 +-------------
>  xen/include/public/hvm/dm_op.h               | 19 +-------------
>  xen/include/public/hvm/e820.h                | 19 +-------------
>  xen/include/public/hvm/hvm_info_table.h      | 19 +-------------
>  xen/include/public/hvm/hvm_op.h              | 19 +-------------
>  xen/include/public/hvm/hvm_vcpu.h            | 19 +-------------
>  xen/include/public/hvm/hvm_xs_strings.h      | 19 +-------------
>  xen/include/public/hvm/ioreq.h               | 19 +-------------
>  xen/include/public/hvm/params.h              | 19 +-------------
>  xen/include/public/hvm/pvdrivers.h           | 19 +-------------
>  xen/include/public/hvm/save.h                | 19 +-------------
>  xen/include/public/hypfs.h                   | 19 +-------------
>  xen/include/public/io/9pfs.h                 | 19 +-------------
>  xen/include/public/io/blkif.h                | 19 +-------------
>  xen/include/public/io/cameraif.h             | 19 +-------------
>  xen/include/public/io/console.h              | 19 +-------------
>  xen/include/public/io/displif.h              | 19 +-------------
>  xen/include/public/io/fbif.h                 | 19 +-------------
>  xen/include/public/io/fsif.h                 | 19 +-------------
>  xen/include/public/io/kbdif.h                | 19 +-------------
>  xen/include/public/io/libxenvchan.h          | 19 +-------------
>  xen/include/public/io/netif.h                | 19 +-------------
>  xen/include/public/io/pciif.h                | 19 +-------------
>  xen/include/public/io/protocols.h            | 19 +-------------
>  xen/include/public/io/pvcalls.h              | 19 +-------------
>  xen/include/public/io/ring.h                 | 19 +-------------
>  xen/include/public/io/sndif.h                | 19 +-------------
>  xen/include/public/io/tpmif.h                | 19 +-------------
>  xen/include/public/io/usbif.h                | 19 +-------------
>  xen/include/public/io/vscsiif.h              | 19 +-------------
>  xen/include/public/io/xenbus.h               | 19 +-------------
>  xen/include/public/io/xs_wire.h              | 19 +-------------
>  xen/include/public/kexec.h                   | 19 +-------------
>  xen/include/public/memory.h                  | 19 +-------------
>  xen/include/public/nmi.h                     | 19 +-------------
>  xen/include/public/physdev.h                 | 19 +-------------
>  xen/include/public/platform.h                | 19 +-------------
>  xen/include/public/pmu.h                     | 19 +-------------
>  xen/include/public/sched.h                   | 19 +-------------
>  xen/include/public/sysctl.h                  | 19 +-------------
>  xen/include/public/tmem.h                    | 19 +-------------
>  xen/include/public/trace.h                   | 19 +-------------
>  xen/include/public/vcpu.h                    | 19 +-------------
>  xen/include/public/version.h                 | 19 +-------------
>  xen/include/public/vm_event.h                | 19 +-------------
>  xen/include/public/xen-compat.h              | 19 +-------------
>  xen/include/public/xen.h                     | 19 +-------------
>  xen/include/public/xencomm.h                 | 19 +-------------
>  xen/include/public/xenoprof.h                | 19 +-------------
>  xen/include/public/xsm/flask_op.h            | 19 +-------------
>  tools/include/xen-foreign/mkheader.py        | 23 ++++++++++++++---
>  tools/include/xen/COPYING                    | 26 ++++++++++++++++++++
>  77 files changed, 125 insertions(+), 1301 deletions(-)
>  create mode 100644 tools/include/xen/COPYING
> 
> --
> Anthony PERARD