From patchwork Thu Nov 10 16:59:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Vrabel X-Patchwork-Id: 13039022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA4B0C4167B for ; Thu, 10 Nov 2022 17:00:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.442030.696078 (Exim 4.92) (envelope-from ) id 1otAuI-00037I-Ls; Thu, 10 Nov 2022 17:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442030.696078; Thu, 10 Nov 2022 17:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuI-00036a-GO; Thu, 10 Nov 2022 17:00:02 +0000 Received: by outflank-mailman (input) for mailman id 442030; Thu, 10 Nov 2022 17:00:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuG-0002uf-MF for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 17:00:00 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c2dcb2e-6119-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:59:59 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so3896581wmb.2 for ; Thu, 10 Nov 2022 08:59:59 -0800 (PST) Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk. [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id j5-20020a05600c1c0500b003cfbbd54178sm9403666wms.2.2022.11.10.08.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:59:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 1c2dcb2e-6119-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=jR9sL9xZ87Lim2oBNCVC1s9tGbb7OCjb5ynHIotoKw0=; b=qWbUXpUaZO2M2dtX+vIvfmPuj/g8QkzNqZBcpZu9CWe3QeQ04ksOAu1srnyERkmOtf SwWmFHXm+onT912QNEFJPrLOiWNBoo+Hv5iP8n1AWuXad+ap5XCyggjv3vK32Gjjg97W uSE9r3qCFM/2wJuVBamxEK4si+AgfN2k4MiAYE/xs/KdYrrFRw+ECvs69G7BjqnGIE3N v2008s552u9U5FsZfnB5aSzIjiQkhODxiWSyRagwjJMbAVJLWXK32ZpDpvtHtiZU7f6a 9fHSwRpjo4LpKCuEPAySmM4eJIBJSN4JE4ZDdSNGaIe8ScldymXeFqnmAltzNPmsLaZ6 EMQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jR9sL9xZ87Lim2oBNCVC1s9tGbb7OCjb5ynHIotoKw0=; b=JkJMtSzCCnj4tauxY6EAjQzawqwLKbVkh3MmPTNES9z90kbnKkQ8rNRiwOJa6muz1y VDecGzCjxtR6OB9ybxVYg514PxkAAzVYAWD227GFdBcmq74YMzfP0mDEk4nWufpJYlHZ jOsY+IITerkpX1C5N2HNkoRiJC8yWBxmgXO4HOjSsc5iaRJ1kCd9LncLNGKGf7cWUtiK NslsDDCRimjX/AvWA61WJnv50w6R00QyQp9BKMPEkcTZIGZUbzFsDOinqijqMHfIZkkM 6Yjw+FFRDSG++9SkdeLEAHOjdMOkBCDx//zeGWfb8ZV0gTbKWI+IpDguRF1PUBNPzP3b fPQQ== X-Gm-Message-State: ACrzQf2XPicgPpjgLaHH72Xe0vJ4ruGmrERJsEM9i+Zac8LmEuDrkVwD qKVN4kcuRrWZhndr6ln/LsVBg/oA+jQ= X-Google-Smtp-Source: AMsMyM6n1OFHG8Zd8JC3d6UsF+ZjrzWpShMVJmuZY4jAtLsdc3XLhCBK16lMu+nx1LpJfKfi/GEBkQ== X-Received: by 2002:a7b:c30c:0:b0:3c6:f26a:590f with SMTP id k12-20020a7bc30c000000b003c6f26a590fmr44268221wmj.205.1668099598900; Thu, 10 Nov 2022 08:59:58 -0800 (PST) Sender: David Vrabel From: David Vrabel X-Google-Original-From: David Vrabel To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu , David Vrabel Subject: [PATCH 0/3] x86: Fix racy accesses to MSI-X Control register Date: Thu, 10 Nov 2022 16:59:32 +0000 Message-Id: <20221110165935.106376-1-dvrabel@amazon.co.uk> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 The main patch in this series is 3/3 with some preparatory patches to simplify the implementation. To summarize: Concurrent access the the MSI-X control register are not serialized with a suitable lock. For example, in msix_capability_init() access use the pcidevs_lock() but some calls to msi_set_mask_bit() use the interrupt descriptor lock. This can lead to MSI-X being incorrectly disabled and subsequent failures due to msix_memory_decoded() calls that check for MSI-X being enabled. David