[v3,00/17] tools/xenstore: do some cleanup and fixes

Message

Jürgen Groß Jan. 17, 2023, 9:11 a.m. UTC

This is a first run of post-XSA patches which piled up during the
development phase of all the recent Xenstore related XSA patches.

At least the first 5 patches are completely independent from each
other. After those the dependencies are starting to be more complex.

This is a mixture of small fixes, enhancements and cleanups.

Changes in V3:
- patches 2, 3, and 5 of V2 have been applied already
- new patch 12
- addressed comments

Changes in V2:
- patches 1+2 of V1 have been applied already
- addressed comments
- new patch 19

Juergen Gross (17):
  tools/xenstore: let talloc_free() preserve errno
  tools/xenstore: remove all watches when a domain has stopped
  tools/xenstore: add hashlist for finding struct domain by domid
  tools/xenstore: introduce dummy nodes for special watch paths
  tools/xenstore: replace watch->relative_path with a prefix length
  tools/xenstore: move changed domain handling
  tools/xenstore: change per-domain node accounting interface
  tools/xenstore: don't allow creating too many nodes in a transaction
  tools/xenstore: replace literal domid 0 with dom0_domid
  tools/xenstore: make domain_is_unprivileged() an inline function
  tools/xenstore: let chk_domain_generation() return a bool
  tools/xenstore: don't let hashtable_remove() return the removed value
  tools/xenstore: switch hashtable to use the talloc framework
  tools/xenstore: make log macro globally available
  tools/xenstore: introduce trace classes
  tools/xenstore: let check_store() check the accounting data
  tools/xenstore: make output of "xenstore-control help" more pretty

 docs/misc/xenstore.txt                 |  10 +-
 tools/xenstore/hashtable.c             | 104 ++---
 tools/xenstore/hashtable.h             |   7 +-
 tools/xenstore/talloc.c                |  21 +-
 tools/xenstore/xenstored_control.c     |  36 +-
 tools/xenstore/xenstored_core.c        | 266 +++++++----
 tools/xenstore/xenstored_core.h        |  31 ++
 tools/xenstore/xenstored_domain.c      | 620 +++++++++++++------------
 tools/xenstore/xenstored_domain.h      |  21 +-
 tools/xenstore/xenstored_transaction.c |  76 +--
 tools/xenstore/xenstored_transaction.h |   7 +-
 tools/xenstore/xenstored_watch.c       |  36 +-
 12 files changed, 652 insertions(+), 583 deletions(-)

Comments

Jan Beulich Jan. 17, 2023, 9:37 a.m. UTC | #1

On 17.01.2023 10:11, Juergen Gross wrote:
> This is a first run of post-XSA patches which piled up during the
> development phase of all the recent Xenstore related XSA patches.
> 
> At least the first 5 patches are completely independent from each
> other. After those the dependencies are starting to be more complex.

The same was said in v2, yet three(?) of the early patches were
committed already. Hence with a look towards committing I wonder in
how far the 5 above is accurate.

Jan

Jürgen Groß Jan. 17, 2023, 9:50 a.m. UTC | #2

On 17.01.23 10:37, Jan Beulich wrote:
> On 17.01.2023 10:11, Juergen Gross wrote:
>> This is a first run of post-XSA patches which piled up during the
>> development phase of all the recent Xenstore related XSA patches.
>>
>> At least the first 5 patches are completely independent from each
>> other. After those the dependencies are starting to be more complex.
> 
> The same was said in v2, yet three(?) of the early patches were
> committed already. Hence with a look towards committing I wonder in
> how far the 5 above is accurate.

I think it is still true, maybe even patch 6 could be applied, but that
one would require at least some context editing (changes of patch 4 are
visible in the patch file).


Juergen