| Message ID | 20230712073556.14719-1-peter.hoyes@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add escape character argument to Xen console | expand |
Hi Peter, > On 12 Jul 2023, at 09:35, Peter Hoyes <Peter.Hoyes@arm.com> wrote: > > From: Peter Hoyes <Peter.Hoyes@arm.com> > > Dom0 may be accessed via telnet, meaning the default escape character > (which is the same as telnet's) cannot be directly used to exit the > console. It would be helpful to make the escape character customizable > in such use cases, falling back to the existing > > Make the necessary changes to the console client, libxl and the xl > console sub-command to support this. > > Changes in v4: > * Update xl docs > * Add necessary changes for libxl API version compatibility > * Improve escape sequence argument validation > > Peter Hoyes (2): > tools/console: Add escape argument to configure escape character > xl: Add escape character argument to xl console In the patches you did not add a change log to get what has been modified between versions of the serie. This is making it a bit harder to diff review. Could you resent your serie and add a change log: -- Changes in v4: - xxx - xxx Changes in v3: - xxx ...etc Thanks Cheers Bertrand > > docs/man/xl.1.pod.in | 8 ++++++- > tools/console/client/main.c | 21 +++++++++++++---- > tools/include/libxl.h | 39 +++++++++++++++++++++++++++++--- > tools/libs/light/libxl_console.c | 30 +++++++++++++++++------- > tools/xl/xl_cmdtable.c | 3 ++- > tools/xl/xl_console.c | 10 +++++--- > tools/xl/xl_vmcontrol.c | 2 +- > 7 files changed, 92 insertions(+), 21 deletions(-) > > -- > 2.34.1 >
From: Peter Hoyes <Peter.Hoyes@arm.com> Dom0 may be accessed via telnet, meaning the default escape character (which is the same as telnet's) cannot be directly used to exit the console. It would be helpful to make the escape character customizable in such use cases, falling back to the existing Make the necessary changes to the console client, libxl and the xl console sub-command to support this. Changes in v4: * Update xl docs * Add necessary changes for libxl API version compatibility * Improve escape sequence argument validation Peter Hoyes (2): tools/console: Add escape argument to configure escape character xl: Add escape character argument to xl console docs/man/xl.1.pod.in | 8 ++++++- tools/console/client/main.c | 21 +++++++++++++---- tools/include/libxl.h | 39 +++++++++++++++++++++++++++++--- tools/libs/light/libxl_console.c | 30 +++++++++++++++++------- tools/xl/xl_cmdtable.c | 3 ++- tools/xl/xl_console.c | 10 +++++--- tools/xl/xl_vmcontrol.c | 2 +- 7 files changed, 92 insertions(+), 21 deletions(-)