| Message ID | 20230818125753.876699-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Rombios build fixes | expand |
On 18/08/2023 1:57 pm, Andrew Cooper wrote: > Andrew Cooper (2): > rombios: Avoid using K&R function syntax > rombiosn: Remove the use of egrep > > tools/firmware/rombios/32bit/Makefile | 2 +- > tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > > base-commit: e6cb27f2f20d09dd2ba135fbc341a4dc98656e10 Urgh, forgot to write what I meant to write. https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/972116359 This gives a clean CI run when ROMBios is explicitly (re)activated. ~Andrew
On 18.08.2023 15:05, Andrew Cooper wrote: > On 18/08/2023 1:57 pm, Andrew Cooper wrote: >> Andrew Cooper (2): >> rombios: Avoid using K&R function syntax >> rombiosn: Remove the use of egrep >> >> tools/firmware/rombios/32bit/Makefile | 2 +- >> tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +++++----- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> >> base-commit: e6cb27f2f20d09dd2ba135fbc341a4dc98656e10 > > Urgh, forgot to write what I meant to write. > > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/972116359 > > This gives a clean CI run when ROMBios is explicitly (re)activated. On irc you said "more array bounds issues in GET_BDA", yet nothing further is being adjusted here in that regard? Jan
On 18/08/2023 2:13 pm, Jan Beulich wrote: > On 18.08.2023 15:05, Andrew Cooper wrote: >> On 18/08/2023 1:57 pm, Andrew Cooper wrote: >>> Andrew Cooper (2): >>> rombios: Avoid using K&R function syntax >>> rombiosn: Remove the use of egrep >>> >>> tools/firmware/rombios/32bit/Makefile | 2 +- >>> tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +++++----- >>> 2 files changed, 6 insertions(+), 6 deletions(-) >>> >>> >>> base-commit: e6cb27f2f20d09dd2ba135fbc341a4dc98656e10 >> Urgh, forgot to write what I meant to write. >> >> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/972116359 >> >> This gives a clean CI run when ROMBios is explicitly (re)activated. > On irc you said "more array bounds issues in GET_BDA", yet nothing further > is being adjusted here in that regard? So yes, I did end up being confused about those. They're from the iPXE build, not the RomBIOS build. They can be seen in https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4899807239 but there's clearly no -Werror going on. I'm going to leave it for now. The only reasonable fix would be to bump the version of iPXE and I don't have time to that right now. ~Andrew