[v3,0/4] xenwatchdogd bugfixes and enhancements

Message

Leigh Brown April 11, 2024, 6:20 p.m. UTC

From: Leigh Brown <[e-mail]>

The primary intention of this patch series is to replace the
pathologically bad behaviour of rebooting the domain if you run
"xenwatchdogd -h". To that end, I have implemented comprehensive
argument validation. This validation ensures you can't pass
arguments that instantly reboot the domain or cause it to spin
loop running sleep(0) repeatedly.

I added a couple of enhancements whilst working on the changes as
they were easy enough.  In particular, being able to run in the
foreground, disarming the watchdog on exit, help and a manpage.


Changes since v2:
- Drop patches 1-3 from v2, as they have been applied.
- Tweak check for NULL character.
- Fix initial implementation of parse_secs() not to use optind.
- Updated copyright notice.
- Better patch message for enhancements patch.
- Addressed feedback on manpage.

Changes since v1:
- Add Signed-off-by on every patch.
- Make global variables static.

Leigh Brown (4):
  tools/misc: xenwatchdogd: add parse_secs()
  tools/misc: xenwatchdogd enhancements
  tools/misc: Add xenwatchdogd.c copyright notice
  docs/man: Add xenwatchdog manual page

 docs/man/xenwatchdogd.8.pod |  55 ++++++++++++++++
 tools/misc/xenwatchdogd.c   | 121 +++++++++++++++++++++++++++++++-----
 2 files changed, 161 insertions(+), 15 deletions(-)
 create mode 100644 docs/man/xenwatchdogd.8.pod