mbox series

[for-4.19(?),0/3] tools/libxs: More CLOEXEC fixes

Message ID 20240628143116.1044976-1-andrew.cooper3@citrix.com (mailing list archive)
Headers show
Series tools/libxs: More CLOEXEC fixes | expand

Message

Andrew Cooper June 28, 2024, 2:31 p.m. UTC 
More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the first
attempt to fix this wasn't complete.

libxl is far worse, but I don't have time to get started on that mess.

Andrew Cooper (3):
  tools/libxs: Fix CLOEXEC handling in get_dev()
  tools/libxs: Fix CLOEXEC handling in get_socket()
  tools/libxs: Fix CLOEXEC handling in xs_fileno()

 tools/config.h.in     |  3 ++
 tools/configure       | 12 ++++++++
 tools/configure.ac    |  2 ++
 tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++---------
 4 files changed, 72 insertions(+), 13 deletions(-)

Comments

Jürgen Groß July 1, 2024, 9:03 a.m. UTC | #1 
On 28.06.24 16:31, Andrew Cooper wrote:
> More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the first
> attempt to fix this wasn't complete.
> 
> libxl is far worse, but I don't have time to get started on that mess.
> 
> Andrew Cooper (3):
>    tools/libxs: Fix CLOEXEC handling in get_dev()
>    tools/libxs: Fix CLOEXEC handling in get_socket()
>    tools/libxs: Fix CLOEXEC handling in xs_fileno()
> 
>   tools/config.h.in     |  3 ++
>   tools/configure       | 12 ++++++++
>   tools/configure.ac    |  2 ++
>   tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++---------
>   4 files changed, 72 insertions(+), 13 deletions(-)
> 

For the series:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen
Anthony PERARD July 1, 2024, 9:28 a.m. UTC | #2 
On Mon, Jul 01, 2024 at 11:03:02AM +0200, Jürgen Groß wrote:
> On 28.06.24 16:31, Andrew Cooper wrote:
> > More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the first
> > attempt to fix this wasn't complete.
> > 
> > libxl is far worse, but I don't have time to get started on that mess.
> > 
> > Andrew Cooper (3):
> >    tools/libxs: Fix CLOEXEC handling in get_dev()
> >    tools/libxs: Fix CLOEXEC handling in get_socket()
> >    tools/libxs: Fix CLOEXEC handling in xs_fileno()
> > 
> >   tools/config.h.in     |  3 ++
> >   tools/configure       | 12 ++++++++
> >   tools/configure.ac    |  2 ++
> >   tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++---------
> >   4 files changed, 72 insertions(+), 13 deletions(-)
> > 
> 
> For the series:
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,
Oleksii Kurochko July 1, 2024, 3:06 p.m. UTC | #3 
On Fri, 2024-06-28 at 15:31 +0100, Andrew Cooper wrote:
> More fixes to CLOEXEC handling in libxenstore.  For 4.19, because the
> first
> attempt to fix this wasn't complete.
> 
> libxl is far worse, but I don't have time to get started on that
> mess.
> 
> Andrew Cooper (3):
>   tools/libxs: Fix CLOEXEC handling in get_dev()
>   tools/libxs: Fix CLOEXEC handling in get_socket()
>   tools/libxs: Fix CLOEXEC handling in xs_fileno()
> 
>  tools/config.h.in     |  3 ++
>  tools/configure       | 12 ++++++++
>  tools/configure.ac    |  2 ++
>  tools/libs/store/xs.c | 68 ++++++++++++++++++++++++++++++++++-------
> --
>  4 files changed, 72 insertions(+), 13 deletions(-)
> 
For the whole series:
 Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii