From patchwork Wed Nov 13 12:41:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Stanner X-Patchwork-Id: 13873562 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D94CD41C3E for ; Wed, 13 Nov 2024 12:43:12 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.835552.1251417 (Exim 4.92) (envelope-from ) id 1tBChp-0003p9-Lj; Wed, 13 Nov 2024 12:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 835552.1251417; Wed, 13 Nov 2024 12:42:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tBChp-0003oV-GD; Wed, 13 Nov 2024 12:42:45 +0000 Received: by outflank-mailman (input) for mailman id 835552; Wed, 13 Nov 2024 12:42:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tBCho-0003m4-Bg for xen-devel@lists.xenproject.org; Wed, 13 Nov 2024 12:42:44 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c22ee1d4-a1bc-11ef-a0c7-8be0dac302b0; Wed, 13 Nov 2024 13:42:36 +0100 (CET) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-uaqureCkMxGI3q2SgPXraQ-1; Wed, 13 Nov 2024 07:42:31 -0500 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d432f9f5eso3589154f8f.0 for ; Wed, 13 Nov 2024 04:42:31 -0800 (PST) Received: from eisenberg.redhat.com (nat-pool-muc-u.redhat.com. [149.14.88.27]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed99aa18sm18023528f8f.61.2024.11.13.04.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 04:42:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c22ee1d4-a1bc-11ef-a0c7-8be0dac302b0 X-Custom-Connection: eyJyZW1vdGVpcCI6IjE3MC4xMC4xMjkuMTI0IiwiaGVsbyI6InVzLXNtdHAtZGVsaXZlcnktMTI0Lm1pbWVjYXN0LmNvbSJ9 X-Custom-Transaction: eyJpZCI6ImMyMmVlMWQ0LWExYmMtMTFlZi1hMGM3LThiZTBkYWMzMDJiMCIsInRzIjoxNzMxNTAxNzU2LjY2MzE4LCJzZW5kZXIiOiJwc3Rhbm5lckByZWRoYXQuY29tIiwicmVjaXBpZW50IjoieGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnIn0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731501755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gi/nDuPOQh+kW8YCVePTGgMsqduTQsEMI/h4REBTyU8=; b=XPq3IzCJ1K/qL737veRrH5eMdIWbPVROD1Bv6J/fB/gVLEvbEmfG14bZW+a+n4zXKXSW8W eS+lJvMa4zecUG1VZTPo5czrUEB4PFCY1rYLxtEmu3NtsLTAYerFo3tzq25UM1W2dFFfJl jkEMZhjPdk0vdnT6UBWL7Q4TqJyeKLw= X-MC-Unique: uaqureCkMxGI3q2SgPXraQ-1 X-Mimecast-MFC-AGG-ID: uaqureCkMxGI3q2SgPXraQ X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731501751; x=1732106551; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gi/nDuPOQh+kW8YCVePTGgMsqduTQsEMI/h4REBTyU8=; b=rJBQaPvnnOy54a9zQ/F+PLDSylV7LyNcqYTwYAKZEiMqF6NSi2woDBo8j/ScwwZx9j AHigywLywZ3SXj7YvJ4FGow7se0acnI1wt6TvYLSbow7xvWp5m8aN75YZpITYakt0hUJ ihYlIIyLuoOHPOb5CcaQCTdK4ICisP3ATgZ87ZY13q0+8u6V8XUPmmpMwLuVoMxtinyf Gmt3W2Pf9F5jsItFUTYMxt/JX4wvczoMKYdRwi1R2YjU/0ufVmErQVuOOok0GliQyser SAx/un7cfjB2XMDRpH//3WIdJNbIE0jju4Mdn5imcG/D91a9TIIrv/2lBsCtkTHoZVjO pSVQ== X-Forwarded-Encrypted: i=1; AJvYcCU9u/NlGiwNLtVsZUhtDnMVMSo44aKMYkWb7dS7SF0KhVOo/jMHIJj+f8j+aUt98Kc9yZVZ8PgwoEE=@lists.xenproject.org X-Gm-Message-State: AOJu0YxFZHRL0jnEIsx6Duxo9yBt805lkC/wO1Kz9yTiwOCIWz6lyk87 XUi5U4DfF6y4NpDOnpdl3v9YIpFy6eWoz0ls8k4bE2TMrcAAJ2+oE9EzubKftzLJl6Ylwq749lO G4X40CufOfrvfpMBJ/64hDZzMX+4/o/0JK3rNT8o+uCL7AH7pfrRaqzd7enp3Bwu1 X-Received: by 2002:a5d:5f53:0:b0:381:f595:fd0a with SMTP id ffacd0b85a97d-3820810ffc0mr4675161f8f.16.1731501750632; Wed, 13 Nov 2024 04:42:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkW+KWr+FGBC4soAeZ9AbHODqoGfzXwj1GlUIlZwp3/7RfEbVzZfIvsQ3hNUEE9XJJckqbgQ== X-Received: by 2002:a5d:5f53:0:b0:381:f595:fd0a with SMTP id ffacd0b85a97d-3820810ffc0mr4675138f8f.16.1731501750223; Wed, 13 Nov 2024 04:42:30 -0800 (PST) From: Philipp Stanner To: Damien Le Moal , Niklas Cassel , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Greg Kroah-Hartman , Alex Dubov , Sudarsana Kalluru , Manish Chopra , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Philipp Stanner , Mario Limonciello , Chen Ni , Ricky Wu , Al Viro , Breno Leitao , Kevin Tian , Thomas Gleixner , Mostafa Saleh , Andy Shevchenko , Jason Gunthorpe , Yi Liu , Kunwu Chan , Ankit Agrawal , Christian Brauner , Reinette Chatre , Eric Auger , Ye Bin Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 00/11] Remove implicit devres from pci_intx() Date: Wed, 13 Nov 2024 13:41:48 +0100 Message-ID: <20241113124158.22863-2-pstanner@redhat.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7SqlCWKtB-P6JZC5A5Ro5qAxeTchc6wv-GOBC3X6vvw_1731501751 X-Mimecast-Originator: redhat.com @Driver-Maintainers: Your driver might be touched by patch "Remove devres from pci_intx()". You might want to take a look. Changes in v2: - Drop pci_intx() deprecation patch. - ata: Add RB from Sergey and Niklas. - wifi: Add AB by Kalle. - Drop INTx deprecation patch - Drop ALSA / hda_intel patch because pci_intx() was removed from there in the meantime. Changes since the RFC [1]: - Add a patch deprecating pci{m}_intx(). (Heiner, Andy, Me) - Add Acked-by's already given. - Export pcim_intx() as a GPL function. (Alex) - Drop patch for rts5280, since this driver will be removed quite soon. (Philipp Hortmann, Greg) - Use early-return in pci_intx_unmanaged() and pci_intx(). (Andy) Hi all, this series removes a problematic feature from pci_intx(). That function sometimes implicitly uses devres for automatic cleanup. We should get rid of this implicit behavior. To do so, a pci_intx() version that is always-managed, and one that is never-managed are provided. Then, all pci_intx() users are ported to the version they need. Afterwards, pci_intx() can be cleaned up and the users of the never-managed version be ported back to pci_intx(). This way we'd get this PCI API consistent again. Patch "Remove devres from pci_intx()" obviously reverts the previous patches that made drivers use pci_intx_unmanaged(). But this way it's easier to review and approve. It also makes sure that each checked out commit should provide correct behavior, not just the entire series as a whole. Merge plan for this is to enter through the PCI tree. [1] https://lore.kernel.org/all/20241009083519.10088-1-pstanner@redhat.com/ Regards, P. Philipp Stanner (11): PCI: Prepare removing devres from pci_intx() drivers/xen: Use never-managed version of pci_intx() net/ethernet: Use never-managed version of pci_intx() net/ntb: Use never-managed version of pci_intx() misc: Use never-managed version of pci_intx() vfio/pci: Use never-managed version of pci_intx() PCI: MSI: Use never-managed version of pci_intx() ata: Use always-managed version of pci_intx() wifi: qtnfmac: use always-managed version of pcim_intx() HID: amd_sfh: Use always-managed version of pcim_intx() Remove devres from pci_intx() drivers/ata/ahci.c | 2 +- drivers/ata/ata_piix.c | 2 +- drivers/ata/pata_rdc.c | 2 +- drivers/ata/sata_sil24.c | 2 +- drivers/ata/sata_sis.c | 2 +- drivers/ata/sata_uli.c | 2 +- drivers/ata/sata_vsc.c | 2 +- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 ++-- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 +- .../wireless/quantenna/qtnfmac/pcie/pcie.c | 2 +- drivers/pci/devres.c | 24 +++---------------- drivers/pci/pci.c | 16 +++---------- include/linux/pci.h | 1 + 13 files changed, 18 insertions(+), 45 deletions(-)