From patchwork Tue Feb 4 11:33:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 13958940 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 976BEC02197 for ; Tue, 4 Feb 2025 11:34:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.881270.1291395 (Exim 4.92) (envelope-from ) id 1tfHC3-0001Mi-VR; Tue, 04 Feb 2025 11:34:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 881270.1291395; Tue, 04 Feb 2025 11:34:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tfHC3-0001Mb-Sm; Tue, 04 Feb 2025 11:34:15 +0000 Received: by outflank-mailman (input) for mailman id 881270; Tue, 04 Feb 2025 11:34:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tfHC2-0001MV-5y for xen-devel@lists.xenproject.org; Tue, 04 Feb 2025 11:34:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f459060c-e2eb-11ef-99a4-01e77a169b0f; Tue, 04 Feb 2025 12:34:11 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0BEB41F365; Tue, 4 Feb 2025 11:34:11 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9BDFF1393E; Tue, 4 Feb 2025 11:34:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MXrVIzL7oWeaLAAAD6G6ig (envelope-from ); Tue, 04 Feb 2025 11:34:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f459060c-e2eb-11ef-99a4-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1738668851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0u5AgPuZOnxJoWqJSpzeFR1NyoCrZTKWM/Xog2Fu8/Q=; b=WxYS25m/Me2nmLzEpHYgbl3LKhXzXnXkrpmkINXCC+ItpITW6HAxC1oktP43FW1lRe9urG PRIumqo0ldq+AFfxQiIUhv7zD5wuFo8b17yXDpl+KF061PC7/fN+k4W3YSNpOZAaYeCsNF kgPK4sLiojR/TdzM1bClQpKWHr+guxI= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b="WxYS25m/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1738668851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0u5AgPuZOnxJoWqJSpzeFR1NyoCrZTKWM/Xog2Fu8/Q=; b=WxYS25m/Me2nmLzEpHYgbl3LKhXzXnXkrpmkINXCC+ItpITW6HAxC1oktP43FW1lRe9urG PRIumqo0ldq+AFfxQiIUhv7zD5wuFo8b17yXDpl+KF061PC7/fN+k4W3YSNpOZAaYeCsNF kgPK4sLiojR/TdzM1bClQpKWHr+guxI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , "Daniel P. Smith" , Samuel Thibault Subject: [PATCH v8 0/9] remove libxenctrl usage from xenstored Date: Tue, 4 Feb 2025 12:33:58 +0100 Message-ID: <20250204113407.16839-1-jgross@suse.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 0BEB41F365 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Xenstored is using libxenctrl for only one purpose: to get information about state of domains. This patch series is removing that dependency by introducing a new stable interface which can be used by xenstored instead. There was a RFC series sent out 3 years ago, which I have taken as a base and by addressing all comments from back then. The main differences since that RFC series are: - Instead of introducing an new main hypercall for a stable management interface I have just added a new domctl sub-op, as requested in 2021. - I have added a new library libxenmanage for easy use of the new stable hypervisor interface. Main motivation for adding the library was the recent attempt to decouple oxenstored from the Xen git tree. By using the new library, oxenstored could benefit in the same way as xenstored from the new interface: it would be possible to rely on stable libraries only. - Mini-OS has gained some more config options recently, so it was rather easy to make xenstore[pvh]-stubdom independent from libxenctrl, too. Please note that the last 4 patches can be committed only after the related Mini-OS patch "config: add support for libxenmanage" has gone in AND the Mini-OS commit-id has been updated in Config.mk accordingly! The Mini-OS patch has been Acked already, so it can go in as soon as patch 5 of this series (the one introducing libxenmanage) has been committed. As patches 1 and 2 change current behavior, Jan didn't want to give his Ack (he didn't reject the patch either). So I'm asking other "Rest" maintainers to look at those patches specifically. Changes in V2: - new patch 1 - former patch 5 mover earlier, now patch 2 (can go in without the rest of the series) - addressed comments Changes in V3: - addressed comments Changes in V4: - patches 1 and 3 of V3 dropped, as already committed - addressed comments Changes in V5: - addressed comments Changes in V6: - patch 1 of V5 has been committed - new patches 1-3 for fixing a race and avoiding new races with the added functionality (result of a comment by Jan Beulich) - rework of locking in patch 4 (Jan Beulich) Changes in V7: - addressed comments - rebase Changes in V8: - patch 1 of v7 has gone in - addressed comments - new patches 7-9 using the new unique_id and xenmanage_poll_changed_domain() Juergen Gross (9): xen/events: don't allow binding a global virq from any domain xen/events: allow setting of global virq handler only for unbound virqs xen: add bitmap to indicate per-domain state changes xen: add new domctl get_changed_domain tools/libs: add a new libxenmanage library tools/xenstored: use new stable interface instead of libxenctrl docs: update xenstore migration stream definition tools/xenstored: use unique_id to identify new domain with same domid tools/xenstored: use xenmanage_poll_changed_domain() docs/designs/xenstore-migration.md | 14 ++- stubdom/Makefile | 8 +- stubdom/mini-os.mk | 1 + tools/flask/policy/modules/dom0.te | 1 + tools/flask/policy/modules/xen.if | 5 +- tools/flask/policy/modules/xenstore.te | 1 + tools/include/xenmanage.h | 92 ++++++++++++++ tools/libs/Makefile | 1 + tools/libs/manage/Makefile | 10 ++ tools/libs/manage/Makefile.common | 3 + tools/libs/manage/core.c | 168 +++++++++++++++++++++++++ tools/libs/manage/libxenmanage.map | 8 ++ tools/libs/uselibs.mk | 2 + tools/xenstored/Makefile | 2 +- tools/xenstored/Makefile.common | 2 +- tools/xenstored/core.h | 1 - tools/xenstored/domain.c | 145 ++++++++++++++------- tools/xenstored/lu.c | 1 + tools/xenstored/lu_daemon.c | 1 + tools/xenstored/xenstore_state.h | 2 +- xen/common/domain.c | 125 ++++++++++++++++++ xen/common/domctl.c | 18 ++- xen/common/event_channel.c | 72 ++++++++++- xen/include/public/domctl.h | 26 ++++ xen/include/xen/event.h | 4 + xen/include/xen/sched.h | 5 + xen/include/xsm/dummy.h | 8 ++ xen/include/xsm/xsm.h | 6 + xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 7 ++ xen/xsm/flask/policy/access_vectors | 2 + 31 files changed, 677 insertions(+), 65 deletions(-) create mode 100644 tools/include/xenmanage.h create mode 100644 tools/libs/manage/Makefile create mode 100644 tools/libs/manage/Makefile.common create mode 100644 tools/libs/manage/core.c create mode 100644 tools/libs/manage/libxenmanage.map