From patchwork Wed Feb 19 14:18:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 13982358 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DED4EC021B1 for ; Wed, 19 Feb 2025 14:18:42 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.893000.1301932 (Exim 4.92) (envelope-from ) id 1tkkuC-0006vU-PM; Wed, 19 Feb 2025 14:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 893000.1301932; Wed, 19 Feb 2025 14:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tkkuC-0006vN-Le; Wed, 19 Feb 2025 14:18:28 +0000 Received: by outflank-mailman (input) for mailman id 893000; Wed, 19 Feb 2025 14:18:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tkkuC-0006vH-2n for xen-devel@lists.xenproject.org; Wed, 19 Feb 2025 14:18:28 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6045436b-eecc-11ef-9896-31a8f345e629; Wed, 19 Feb 2025 15:18:22 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 38BB9216DE; Wed, 19 Feb 2025 14:18:21 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CE6E1137DB; Wed, 19 Feb 2025 14:18:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gdNSMCzotWc1GgAAD6G6ig (envelope-from ); Wed, 19 Feb 2025 14:18:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6045436b-eecc-11ef-9896-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1739974702; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=M06gtcJeT5NzagmEL1S0JXPHjyp++7dF5voXStZHqNM=; b=EwkXoCDGnrZ12NqbYnuIZZhn2WVO6y0y4w7bnRTKjxwFBwSFgbBWT4K3dVpkFfguE4pE2j zUOl8lMq0wC8iL164iJ57zouRC4x1uOAyctvQGCW2vlWxi8am28tuZinzMebocNC7WmL8I bTtkHf6PdfSWqvZzh+OsdtPlyWY6/PE= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b="AoujR0/c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1739974701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=M06gtcJeT5NzagmEL1S0JXPHjyp++7dF5voXStZHqNM=; b=AoujR0/cJ15U+QaDsDcLJWpuJdSlHrjFWK/+hYiNxvATGW/XmOS9kck3D6PSW8Nof5CmF4 Vz/WGvQfaxFxzfSM5eKByIvYmSi5btGycSlqpmZdS82/1ma3UmzmZhjZnoPSgIxs2hYbVR XPm4BfnMI5bSNvZkGwqowFS+upYDkv0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: oleksii.kurochko@gmail.com, Juergen Gross , Jan Beulich , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini Subject: [PATCH v2 0/2] xen/list: some fixes in list.h Date: Wed, 19 Feb 2025 15:18:16 +0100 Message-ID: <20250219141818.8789-1-jgross@suse.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 38BB9216DE X-Rspamd-Action: no action X-Spamd-Result: default: False [-1.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,suse.com,citrix.com,vates.tech,amd.com,xen.org,kernel.org]; RCPT_COUNT_SEVEN(0.00)[10]; TAGGED_RCPT(0.00)[]; DKIM_TRACE(0.00)[suse.com:+]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Patch 1 is a fix for an undefined behavior reported by Andrew. I think this patch should be considered for 4.20. Patch 2 is fixing wrong comments in list.h I stumbled over when doing patch 1. As it is absolutely no risk involved with this patch, I think it should be 4.20 material, too. Changes in V2: - comments addressed Juergen Gross (2): xen/list: avoid UB in list iterators xen/list: fix comments in include/xen/list.h xen/drivers/passthrough/x86/hvm.c | 3 +- xen/include/xen/list.h | 144 ++++++++++++++++++------------ 2 files changed, 90 insertions(+), 57 deletions(-)