mbox series

[RFC,0/3] x86emul: further work

Message ID 5C8B91B4020000780021F3AA@prv1-mh.provo.novell.com (mailing list archive)
Headers show
Series x86emul: further work | expand

Message

Jan Beulich March 15, 2019, 11:51 a.m. UTC
On top of the AVX512 series I'd like to put out for discussion

1: generalize wbinvd() hook
2: support WBNOINVD
3: support MOVDIR{I,64B} insns

Clearly, if the concept of the first two patches is acceptable, I'd
then do the same for INVLPG, making it a more generic TLB
management hook.

Jan

Comments

Andrew Cooper March 15, 2019, 2:32 p.m. UTC | #1
On 15/03/2019 11:51, Jan Beulich wrote:
> On top of the AVX512 series I'd like to put out for discussion
>
> 1: generalize wbinvd() hook
> 2: support WBNOINVD
> 3: support MOVDIR{I,64B} insns
>
> Clearly, if the concept of the first two patches is acceptable, I'd
> then do the same for INVLPG, making it a more generic TLB
> management hook.

I've taken a very brief look over.  I think generalising the hook is a
good move, but can I recommend cache_op as a much shorter name.

The clflushopt and clwb macros suffer the same bug that the current
clflush one does.  I've posted "xen/x86: Fix cflush()'s parameter
tracking" to resolve the issue, and these should be adjusted in line.

~Andrew