| Message ID | DU0P192MB1700AD4C3E33FF8F5D6E90F0E3332@DU0P192MB1700.EURP192.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| Headers | show |
| Series | tools: init scripts: Add missing XENCONSOLED_ARGS variable to xencommons | expand |
On 20.03.2024 08:48, Rafaël Kooi wrote: > V2: Now without test emails ending up on the mailing list. And with the > correct title prefix. > > I noticed that the systemd services referenced the XENCONSOLED_ARGS > variable, but it was missing from xencommons. > I actually ran into this when experimenting with a Qubes patch where I > thought I needed to modify this variable. It turned out to not be the > case, but I figure it's good to include this for sake of completeness. > > Rafaël Kooi (1): > tools: init scripts: Add missing XENCONSOLED_ARGS variable > > tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 6 ++++++ > 1 file changed, 6 insertions(+) Two further remarks: Patch series want to have the patches sent "in reply to" the cover letter, such that the whole thing appears as a single mail thread. For singular patches, generally no cover letter is required (thus avoiding the question of threading). Jan
On 20/03/2024 08:55, Jan Beulich wrote: > On 20.03.2024 08:48, Rafaël Kooi wrote: >> V2: Now without test emails ending up on the mailing list. And with the >> correct title prefix. >> >> I noticed that the systemd services referenced the XENCONSOLED_ARGS >> variable, but it was missing from xencommons. >> I actually ran into this when experimenting with a Qubes patch where I >> thought I needed to modify this variable. It turned out to not be the >> case, but I figure it's good to include this for sake of completeness. >> >> Rafaël Kooi (1): >> tools: init scripts: Add missing XENCONSOLED_ARGS variable >> >> tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 6 ++++++ >> 1 file changed, 6 insertions(+) > > Two further remarks: Patch series want to have the patches sent "in reply to" > the cover letter, such that the whole thing appears as a single mail thread. > For singular patches, generally no cover letter is required (thus avoiding > the question of threading). > > Jan I don't understand why it's not present on the mailing list, the "In-Reply-To" header is present in the patch file. Maybe outlook is stripping it, I'll have to look into it. As for the second point, I'll make sure to keep that in mind. Thanks, Rafaël Kooi
On 20.03.2024 08:59, Rafaël Kooi wrote: > On 20/03/2024 08:55, Jan Beulich wrote: >> On 20.03.2024 08:48, Rafaël Kooi wrote: >>> V2: Now without test emails ending up on the mailing list. And with the >>> correct title prefix. >>> >>> I noticed that the systemd services referenced the XENCONSOLED_ARGS >>> variable, but it was missing from xencommons. >>> I actually ran into this when experimenting with a Qubes patch where I >>> thought I needed to modify this variable. It turned out to not be the >>> case, but I figure it's good to include this for sake of completeness. >>> >>> Rafaël Kooi (1): >>> tools: init scripts: Add missing XENCONSOLED_ARGS variable >>> >>> tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 6 ++++++ >>> 1 file changed, 6 insertions(+) >> >> Two further remarks: Patch series want to have the patches sent "in reply to" >> the cover letter, such that the whole thing appears as a single mail thread. >> For singular patches, generally no cover letter is required (thus avoiding >> the question of threading). > > I don't understand why it's not present on the mailing list, the > "In-Reply-To" header is present in the patch file. Maybe outlook is > stripping it, I'll have to look into it. If you send using Outlook, why don't you simply send the patch(es) as replies to the cover letter? That's what I'm doing using Thunderbird (i.e. like you I'm not using "git send-email"). Jan
On 20/03/2024 09:35, Jan Beulich wrote:> If you send using Outlook, why don't you simply send the patch(es) as > replies to the cover letter? That's what I'm doing using Thunderbird > (i.e. like you I'm not using "git send-email"). > > Jan I do use "git send-email" actually, I have it set up to use their SMTP servers. I figured I would do as the Romans do, I assumed that "git send-email" would be the path of least resistance. I have figured out why the messages don't thread though. Outlook seems to be rewriting the "Message-ID" header, but then fails to update the "In-Reply-To" headers. I'll make a gmail address for future patches, seeing Outlook is mailing list unfriendly. Rafaël