From patchwork Mon Dec 30 19:32:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lars Kurth X-Patchwork-Id: 11313663 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2CFD1398 for ; Mon, 30 Dec 2019 19:34:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C63D220409 for ; Mon, 30 Dec 2019 19:34:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C63D220409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1im0nW-0004Az-5i; Mon, 30 Dec 2019 19:33:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1im0nV-0004AE-2m for xen-devel@lists.xenproject.org; Mon, 30 Dec 2019 19:33:49 +0000 X-Inumbo-ID: 1d786ddc-2b3b-11ea-88e7-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d786ddc-2b3b-11ea-88e7-bc764e2007e4; Mon, 30 Dec 2019 19:32:29 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1im0m9-0003TL-GW; Mon, 30 Dec 2019 19:32:25 +0000 Received: from localhost ([127.0.0.1] helo=MacBook-Pro-2.Home) by xenbits.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1im0m9-0007YU-At; Mon, 30 Dec 2019 19:32:25 +0000 From: Lars Kurth To: xen-devel@lists.xenproject.org Date: Mon, 30 Dec 2019 19:32:12 +0000 Message-Id: X-Mailer: git-send-email 2.13.0 Subject: [Xen-devel] [PATCH v4 0/7] Code of Conduct + Extra Guides and Best Practices + VOTE X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , xen-api@lists.xenproject.org, minios-devel@lists.xenproject.org, committers@xenproject.org, mirageos-devel@lists.xenproject.org, win-pv-devel@lists.xenproject.org MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Lars Kurth This series proposes a concrete version of the Xen Project CoC based on v1.4 of the Contributor Covenant. See [1] Closing the discussion ====================== I think we are at the point where we are ready to publish our guidance. Feedback has been minor since the last version and loose ends were primarily to do with missing examples. To close this, I wanted to get votes on the proposal in the usual way. Technically, only leadership team members of mature projects which are Hypervisor, XAPI and the Windows PV driver project can vote. However, in this case I do believe we do want to hear voices of others. Voting would follow the rules outlined in https://xenproject.org/developers/governance/#project-decisions Leadership team members should vote by replying if they are happy with the substance of the proposal by using the usual terminology +2 : I am happy with this proposal, and I will argue for it +1 : I am happy with this proposal, but will not argue for it 0 : I have no opinion -1 : I am not happy with this proposal, but will not argue against it -2 : I am not happy with this proposal, and I will argue against it If there are minor changes (such as typos, etc) we should fix this in due course. If there are major objections, please highlight here but also raise it against the specific patch and make clear what the objection is. More notes on Changes ===================== It tries to address all elements in the v2 review, which raised a number of hard questions, which were mostly addressed in v3. One of the main outstanding items in v3 were good examples for cover letters and well structured large patch series which were added in v4. For convenience of review and in line with other policy documents I created a git repository at [2]. This series can be found at [3]. I also reformatted the series to 80 characters and replaced inline style links with reference style links to make it easier to stick to a character limit. [1] https://www.contributor-covenant.org/version/1/4/code-of-conduct.md [2] http://xenbits.xen.org/gitweb/?p=people/larsk/code-of-conduct.git;a=summary [3] http://xenbits.xen.org/gitweb/?p=people/larsk/code-of-conduct.git;a=shortlog;h=refs/heads/CoC-v4 Changes since v3 * More typo and whitespace fixes code-review-guide.md * Added example under *Workflow from a Reviewer's Perspective* section Changes since v2 * Reformatted all text to 80 characters and replaced link style code-review-guide.md * Extend introduction * Add "Code Review Workflow" covering - "Workflow from a Reviewer's Perspective" - "Workflow from an Author's Perspective" - "Problematic Patch Reviews" TODO: find suitable examples on how to structure/describe good patch series communication-practice.md * Fix typos * Extended "Verbose vs. terse" * Added "Clarity over Verbosity" * Broke "Identify the severity of an issue or disagreement" into two chapters - "Identify the severity and optionality of review comments" and made clarifications - "Identify the severity of a disagreement" - Expanded "Prioritize significant flaws" * Added "Reviewers: Take account of previous reviewer(s) comments" * Added prefixes such as "Reviewers:" where appropriate resolving-disagreement.md * Fix typos * Add section: "Issue: Multiple ways to solve a problem" Changes since v1 * Code of Conduct Only whitespace changes * Added Communication Guide Contains values and a process based on advice and mediation in case of issues This is the primary portal for * Added Code Review Guide Which is based on [4] with some additions for completeness It primarily sets expectations and anything communication related is removed * Added guide on Communication Best Practice Takes the communication section from [4] and expands on it with more examples and cases. This is probably where we may need some discussion * Added document on Resolving Disagreement A tiny bit of theory to set the scene It covers some common cases of disagreements and how we may approach them Again, this probably needs some discussion Cc: minios-devel@lists.xenproject.org Cc: xen-api@lists.xenproject.org Cc: win-pv-devel@lists.xenproject.org Cc: mirageos-devel@lists.xenproject.org Cc: committers@xenproject.org Lars Kurth (7): Import v1.4 of Contributor Covenant CoC Xen Project Code of Conduct Reformat Xen Project CoC to fit into 80 character limit Add Communication Guide Add Code Review Guide Add guide on Communication Best Practice Added Resolving Disagreement --- 2.13.0