From patchwork Tue Nov 17 18:24:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?RWR3aW4gVMO2csO2aw==?= X-Patchwork-Id: 11913213 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B246014C0 for ; Tue, 17 Nov 2020 18:25:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7433924686 for ; Tue, 17 Nov 2020 18:25:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="J0+UpsOG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7433924686 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.29206.58484 (Exim 4.92) (envelope-from ) id 1kf5eg-0000N7-RB; Tue, 17 Nov 2020 18:24:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 29206.58484; Tue, 17 Nov 2020 18:24:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kf5eg-0000Mz-Nf; Tue, 17 Nov 2020 18:24:38 +0000 Received: by outflank-mailman (input) for mailman id 29206; Tue, 17 Nov 2020 18:24:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kf5ef-0000JQ-4P for xen-devel@lists.xenproject.org; Tue, 17 Nov 2020 18:24:37 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1021ad91-c687-437e-bb8b-37f15fd9eb24; Tue, 17 Nov 2020 18:24:31 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kf5ef-0000JQ-4P for xen-devel@lists.xenproject.org; Tue, 17 Nov 2020 18:24:37 +0000 X-Inumbo-ID: 1021ad91-c687-437e-bb8b-37f15fd9eb24 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1021ad91-c687-437e-bb8b-37f15fd9eb24; Tue, 17 Nov 2020 18:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1605637471; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4HMvIBx0BI9P0e9tGOp3LfzAc3z+4o6/c/L/wV9Ft/A=; b=J0+UpsOG/fTGmgpotvsj/UAqJqiVo7Ygp2FoTEcJk/i7FwggeEogPYrA 0a4pshEdQIHxYOnwokInzzVx0qY61Xvdd+PcTgELTV6EvHqkFDIKc8BQr ar7JykjHo+tXvd4fKSEDp1qkFs1FxHUsKgZyPn8toV96olMJUxQj+vioy U=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yfjK8pbVZlS8xaoxMdLChXUuOw2PJlmlBBbqQb8r11PGMT8NegFwLaxXk/dJuzgwoURSX4J4eZ 5qr/H0iuOUHpuH/ZBXP7oDwmOXQU4prMecmOTSJf2K9OjmKvlLzj/gR4qx34WuOJSSLh7OvP0q zr0Sf6RQhYn4NO/m5Hgc4DXoZN/2KGpZChVkcoYMmGaAOsHrGbrWckiuP5m3EBlumWnfcMNb1g HZFyDVq2NrmLnH6wbVs7uNRNw8FRhT5rPeg1YktZ+IO0AX5TAtlzqzrkIM8Kb3ZA/VdJnSvd4L 51c= X-SBRS: None X-MesageID: 32508574 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,486,1596513600"; d="scan'208";a="32508574" From: =?utf-8?b?RWR3aW4gVMO2csO2aw==?= To: CC: =?utf-8?b?RWR3aW4gVMO2csO2aw==?= , "Doug Goldstein" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , "Stefano Stabellini" , Wei Liu , Christian Lindig , David Scott Subject: [PATCH v1 0/4] tools/ocaml/libs/xc: domid control at domain creation time Date: Tue, 17 Nov 2020 18:24:08 +0000 Message-ID: X-Mailer: git-send-email 2.18.4 MIME-Version: 1.0 The xl toolstack allows some control over the domid at VM creation time, allow xenopsd similar control by exposing the appropriate domid field in the OCaml xenctrl bindings. A new API function is introduced to preserve backwards compatibility without merge ordering requirements between the Xen and xenopsd patches: Xen can merge the patch and xenopsd will keep building with the old function, and a new version of xenopsd will start using the new function. I've also included some build system fixes to allow me to test the build in an upstream build environment: ``` cd automation/build podman build -t registry.gitlab.com/xen-project/xen/ubuntu:focal -f ubuntu/focal.dockerfile ubuntu DOCKER_CMD=podman CONTAINER_NO_PULL=1 CONTAINER=registry.gitlab.com/xen-project/xen/ubuntu:focal automation/scripts/containerize make build-tools-oxenstored ``` It'd be good if someone could test whether containerize still works on non-SELinux systems now, or whether we need more detection logic in the script. This works around bugs in the OCaml makefiles that end up in "inconsistent assumptions" by doing a 'make clean' before building the OCaml files every time. This is inefficient, but works. Long term it would be beneficial to switch to Dune as build system, which can do correct incremental builds with minimal configuration. I'll send a separate patch series for that. Edwin Török (4): automation/scripts/containerize: fix DOCKER_CMD=podman automation/: add Ubuntu:focal container Makefile: add build-tools-oxenstored tools/ocaml/libs/xc: backward compatible domid control at domain creation time Makefile | 6 +++ automation/build/ubuntu/focal.dockerfile | 50 ++++++++++++++++++++++++ automation/scripts/containerize | 7 ++-- tools/ocaml/Makefile | 8 ++++ tools/ocaml/libs/xc/xenctrl.ml | 3 ++ tools/ocaml/libs/xc/xenctrl.mli | 2 + tools/ocaml/libs/xc/xenctrl_stubs.c | 9 ++++- 7 files changed, 80 insertions(+), 5 deletions(-) create mode 100644 automation/build/ubuntu/focal.dockerfile Acked-by: Christian Lindig