From patchwork Fri Feb 2 09:37:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simone Ballarin X-Patchwork-Id: 13542561 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C11A1C48291 for ; Fri, 2 Feb 2024 09:38:53 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.674919.1050089 (Exim 4.92) (envelope-from ) id 1rVq0P-0005sc-J8; Fri, 02 Feb 2024 09:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 674919.1050089; Fri, 02 Feb 2024 09:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rVq0P-0005sV-FR; Fri, 02 Feb 2024 09:38:41 +0000 Received: by outflank-mailman (input) for mailman id 674919; Fri, 02 Feb 2024 09:38:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rVq0O-0005sE-3i for xen-devel@lists.xenproject.org; Fri, 02 Feb 2024 09:38:40 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6d50c72-c1ae-11ee-98f5-efadbce2ee36; Fri, 02 Feb 2024 10:38:37 +0100 (CET) Received: from beta.station (net-188-218-67-100.cust.vodafonedsl.it [188.218.67.100]) by support.bugseng.com (Postfix) with ESMTPSA id 8C67D4EE0737; Fri, 2 Feb 2024 10:38:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6d50c72-c1ae-11ee-98f5-efadbce2ee36 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, sstabellini@kernel.org, Maria Celeste Cesario , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , =?utf-8?q?Roger_Pau_Monn?= =?utf-8?q?=C3=A9?= , Dario Faggioli , Simone Ballarin , Doug Goldstein Subject: [PATCH v3 0/4] address violation of MISRA C:2012 Rule 13.1 Date: Fri, 2 Feb 2024 10:37:43 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 From: Maria Celeste Cesario The Xen sources contain violations of MISRA C:2012 Rule 13.1 whose headline states: "Initializer lists shall not contain persistent side effects". The file properties.json containing function and macro properties is introduced, as stated in v2 discussion. Some functions and macros are found to have properties that can be exploited by static analyzers. For this reason, the file docs/properties.json contains all the needed properties. A description of the json file is documented in docs/properties.rst. Some persistent effects have been moved outside initializer lists to address violations of Rule 13.1. Link to the discussion: https://lore.kernel.org/all/cover.1700844359.git.simone.ballarin@bugseng.com/T/#u Changes in v3: - change prefix from xen to xen/ns16550 - add assignment of rc in xen/ns16550 - use rc as controlling expression in the following if-statement - change commit prefix from xen/arm to xen - specify where saf-3-safe comments are applied in guestcopy.c - reword saf comments text Maria Celeste Cesario (1): eclair: add and manage properties Simone Ballarin (3): xen: add SAF deviation for debugging and logging effects xen/ns16550: address violations of MISRA C:2012 Rule 13.1 xen/x86: address violations of MISRA C:2012 Rule 13.1 .../eclair_analysis/ECLAIR/analysis.ecl | 1 + automation/eclair_analysis/prepare.sh | 2 + docs/misra/safe.json | 16 + docs/properties.json | 841 ++++++++++++++++++ docs/properties.rst | 58 ++ xen/arch/arm/device.c | 1 + xen/arch/arm/guestcopy.c | 16 +- xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/io_apic.c | 9 +- xen/arch/x86/mpparse.c | 3 +- xen/arch/x86/setup.c | 3 +- xen/common/sched/core.c | 3 + xen/drivers/char/ns16550.c | 4 +- 13 files changed, 948 insertions(+), 10 deletions(-) create mode 100644 docs/properties.json create mode 100644 docs/properties.rst