From patchwork Fri Feb 2 15:16:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simone Ballarin X-Patchwork-Id: 13543015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CFFEC48291 for ; Fri, 2 Feb 2024 15:17:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.675076.1050250 (Exim 4.92) (envelope-from ) id 1rVvHg-0006Mq-C3; Fri, 02 Feb 2024 15:16:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 675076.1050250; Fri, 02 Feb 2024 15:16:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rVvHg-0006Mj-9P; Fri, 02 Feb 2024 15:16:52 +0000 Received: by outflank-mailman (input) for mailman id 675076; Fri, 02 Feb 2024 15:16:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rVvHe-0005mR-Gr for xen-devel@lists.xenproject.org; Fri, 02 Feb 2024 15:16:50 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 159e6126-c1de-11ee-98f5-efadbce2ee36; Fri, 02 Feb 2024 16:16:48 +0100 (CET) Received: from beta.station (net-188-218-67-100.cust.vodafonedsl.it [188.218.67.100]) by support.bugseng.com (Postfix) with ESMTPSA id 63D3E4EE0737; Fri, 2 Feb 2024 16:16:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 159e6126-c1de-11ee-98f5-efadbce2ee36 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, sstabellini@kernel.org, Simone Ballarin , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , =?utf-8?q?Roger_Pau_Monn?= =?utf-8?q?=C3=A9?= , Dario Faggioli , Doug Goldstein Subject: [XEN PATCH v4 0/4] address violation of MISRA C:2012 Rule 13.1 Date: Fri, 2 Feb 2024 16:16:01 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 The Xen sources contain violations of MISRA C:2012 Rule 13.1 whose headline states: "Initializer lists shall not contain persistent side effects". The file properties.json containing function and macro properties is introduced, as stated in v2 discussion. Some functions and macros are found to have properties that can be exploited by static analyzers. For this reason, the file docs/properties.json contains all the needed properties. A description of the json file is documented in docs/properties.rst. Some persistent effects have been moved outside initializer lists to address violations of Rule 13.1. Link to the discussion: https://lore.kernel.org/all/cover.1700844359.git.simone.ballarin@bugseng.com/T/#u Changes in v4: - added missing script for converting function_macro_properties.json in ECL configurations and other related improvements. Changes in v3: - change prefix from xen to xen/ns16550 - add assignment of rc in xen/ns16550 - use rc as controlling expression in the following if-statement - change commit prefix from xen/arm to xen - specify where saf-3-safe comments are applied in guestcopy.c - reword saf comments text Maria Celeste Cesario (1): eclair: move function and macro properties outside ECLAIR Simone Ballarin (3): xen: add SAF deviation for debugging and logging effects xen/ns16550: address violations of MISRA C:2012 Rule 13.1 xen/x86: address violations of MISRA C:2012 Rule 13.1 .../eclair_analysis/ECLAIR/analysis.ecl | 1 + .../ECLAIR/call_properties.ecl | 128 --- automation/eclair_analysis/prepare.sh | 2 + automation/eclair_analysis/propertyparser.py | 37 + docs/function_macro_properties.json | 841 ++++++++++++++++++ docs/function_macro_properties.rst | 58 ++ docs/misra/safe.json | 16 + xen/arch/arm/device.c | 1 + xen/arch/arm/guestcopy.c | 16 +- xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/io_apic.c | 9 +- xen/arch/x86/mpparse.c | 3 +- xen/arch/x86/setup.c | 3 +- xen/common/sched/core.c | 3 + xen/drivers/char/ns16550.c | 4 +- 15 files changed, 985 insertions(+), 138 deletions(-) delete mode 100644 automation/eclair_analysis/ECLAIR/call_properties.ecl create mode 100644 automation/eclair_analysis/propertyparser.py create mode 100644 docs/function_macro_properties.json create mode 100644 docs/function_macro_properties.rst