| Message ID | e53b3573-9c9a-734c-df67-6f6da7fd8ef4@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | IOMMU: restrict visibility/scope if certain variables | expand |
Hi Jan, Adding Paul in CC as he now co-maintain the IOMMU code. On 28/02/2020 12:24, Jan Beulich wrote: > A number of the command line controlled variables are x86- > or even x86-HVM-specific. Don't have those variables elsewhere > in the first place (in some cases replace them by a #define), > and as a result also don't silently accept such "iommu=" > sub-options which in fact have no effect. I can confirm that all the parameters listed below are not used on Arm. > > 1: iommu_intremap is x86-only > 2: iommu_intpost is x86/HVM-only > 3: iommu_igfx is x86-only > 4: iommu_qinval is x86-only > 5: iommu_snoop is x86/HVM-only > > The series contextually depends on "AMD/IOMMU: without XT, > x2APIC needs to be forced into physical mode" > > Jan > Cheers,
> From: Jan Beulich <jbeulich@suse.com> > Sent: Friday, February 28, 2020 8:25 PM > > A number of the command line controlled variables are x86- > or even x86-HVM-specific. Don't have those variables elsewhere > in the first place (in some cases replace them by a #define), > and as a result also don't silently accept such "iommu=" > sub-options which in fact have no effect. > > 1: iommu_intremap is x86-only > 2: iommu_intpost is x86/HVM-only > 3: iommu_igfx is x86-only > 4: iommu_qinval is x86-only > 5: iommu_snoop is x86/HVM-only > > The series contextually depends on "AMD/IOMMU: without XT, > x2APIC needs to be forced into physical mode" > I'm generally OK with this series, but will give my r-b after all other vendors have confirmed the scope here. Thanks Kevin