From patchwork Tue Aug 6 13:08:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11078867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D531B1399 for ; Tue, 6 Aug 2019 13:09:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1C0F2845E for ; Tue, 6 Aug 2019 13:09:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B21D8288D7; Tue, 6 Aug 2019 13:09:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6AC9E2845E for ; Tue, 6 Aug 2019 13:09:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1huzCK-0003Mq-12; Tue, 06 Aug 2019 13:08:16 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1huzCI-0003Mb-6v for xen-devel@lists.xenproject.org; Tue, 06 Aug 2019 13:08:14 +0000 X-Inumbo-ID: 3e3c24b5-b84b-11e9-8980-bc764e045a96 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 3e3c24b5-b84b-11e9-8980-bc764e045a96; Tue, 06 Aug 2019 13:08:12 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 74F71B11B; Tue, 6 Aug 2019 13:08:11 +0000 (UTC) From: Jan Beulich To: "xen-devel@lists.xenproject.org" References: <5a4d4a61-a543-c657-8458-cbc6b5a8a633@suse.com> Message-ID: <06b8a3a1-8e24-3b77-2a21-7802f4fb19af@suse.com> Date: Tue, 6 Aug 2019 15:08:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <5a4d4a61-a543-c657-8458-cbc6b5a8a633@suse.com> Content-Language: en-US Subject: [Xen-devel] [PATCH v5 02/10] AMD/IOMMU: drop stray "else" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Brian Woods , Suravee Suthikulpanit Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The blank line between it and the prior if() clearly indicates that this was meant to be a standalone if(). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Acked-by: Brian Woods --- v5: New. --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -166,8 +166,8 @@ static int __init iov_detect(void) if ( !iommu_enable && !iommu_intremap ) return 0; - else if ( (init_done ? amd_iommu_init_interrupt() - : amd_iommu_init(false)) != 0 ) + if ( (init_done ? amd_iommu_init_interrupt() + : amd_iommu_init(false)) != 0 ) { printk("AMD-Vi: Error initialization\n"); return -ENODEV;