Message ID | 06e542f4-1ac5-0a70-eb34-3dcd1b543134@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | x86: correct bogus error indicator of cpu_add() | expand |
On 27/09/2019 15:43, Jan Beulich wrote: > Commit 54ce2db8b8 ("x86/numa: adjust datatypes for node and pxm") > changed this from the -1 (i.e. -EPERM, which was already bogus) that > comes back from setup_node() to NUMA_NO_NODE (0xff). Use a proper error > indicator instead. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
On 27.09.19 16:43, Jan Beulich wrote: > Commit 54ce2db8b8 ("x86/numa: adjust datatypes for node and pxm") > changed this from the -1 (i.e. -EPERM, which was already bogus) that > comes back from setup_node() to NUMA_NO_NODE (0xff). Use a proper error > indicator instead. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Release-acked-by: Juergen Gross <jgross@suse.com> Juergen
--- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1281,7 +1281,7 @@ int cpu_add(uint32_t apic_id, uint32_t a "Setup node failed for pxm %x\n", pxm); x86_acpiid_to_apicid[acpi_id] = BAD_APICID; mp_unregister_lapic(apic_id, cpu); - cpu = node; + cpu = -ENOSPC; goto out; } if ( apic_id < MAX_LOCAL_APIC )
Commit 54ce2db8b8 ("x86/numa: adjust datatypes for node and pxm") changed this from the -1 (i.e. -EPERM, which was already bogus) that comes back from setup_node() to NUMA_NO_NODE (0xff). Use a proper error indicator instead. Signed-off-by: Jan Beulich <jbeulich@suse.com>