From patchwork Mon Sep 6 12:59:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12476939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CDA2C433FE for ; Mon, 6 Sep 2021 13:00:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 185CB60F92 for ; Mon, 6 Sep 2021 13:00:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 185CB60F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.179816.326217 (Exim 4.92) (envelope-from ) id 1mNEE5-0004rA-TO; Mon, 06 Sep 2021 12:59:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179816.326217; Mon, 06 Sep 2021 12:59:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE5-0004r3-PV; Mon, 06 Sep 2021 12:59:53 +0000 Received: by outflank-mailman (input) for mailman id 179816; Mon, 06 Sep 2021 12:59:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE4-0004qY-Gq for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:59:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 52036839-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 12:59:51 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-9-xAUjZGraMhuknGFuXbTleA-1; Mon, 06 Sep 2021 14:59:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Mon, 6 Sep 2021 12:59:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 12:59:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0288.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 12:59:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52036839-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=TAsfWiHE7FZWYTewzBgpb+QG9gVW3kWFnzbDI6TYQZ4q61WIEVh0JLmWYfqCz7kJjy6nvA 1qLtePpTs+Wnj9fILoNt7kw9GlELIxxNVHIGvBKGLTJsNhYP47HtI9sp3/JMwOheLQWum8 /uC25cCoklG6xZH6UXkaBi6w6stIP9I= X-MC-Unique: xAUjZGraMhuknGFuXbTleA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLjHtcBlvctdvTt75iYoXLbCptmC1uoUlrqNiQmQOWmN5NMRBe+ubNquiHZn7Wq5b/C/z67M+RdwyNcjKJKh02ATQmXYOrLkVubin4yYYHIRfRSzSvkoVYatGqs0as1BQP0L+Y97lHeLfoZHK94JsMRT8IrlWfP3wQ2jgihURSI0tk14jvyx/GZ9p78FXtC4g63uV4MhEyoDHahdiEqGvXATD+T+FhreW3qXYUw3+ZaajRM/IfMyzUTDycSGZXgW88Gb2CFkJbNWnzUs08XmUmhZVZitKoQ55psDDzosUvTaLRNcIc80BeFRWQroEalriCgOHyeLqx2fVWiCJZc//Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=PF+1ThupuWkV23rBEb/AVG9YKXiiGvWzWk8N0RVdNnbRiY8A9Y1xfd0Ys2B6n9B8bIi5+yrhKDP5LlyHid8BZcSECQY5ToTb05h/ieblw7n0uV7xrluquc6TLnGeefGIMyWcvJLD4YPtwWKMfERKsEhykRZ0NCb1HRs3UY+d0sH4dsrTgiBMt7bSutsb4uqPk4cbmG9rhfWQ7CvulLnIJqeo1EOA1JeVxKl+J+t8wUXxcf0yL4fJPYZV6zu2vnAfKaEYcXMbeglndhz4/v5FSKxibFcor1TaHlfRrY1cAtnjJQHwHkvQUhi+InvBm1GMzwe/wH+JNRYImUUulv2h9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 1/5] x86/mwait-idle: mention assumption that WBINVD is not needed From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: Message-ID: <0ebb0de3-2500-a9a2-8128-64b9d4a27cb7@suse.com> Date: Mon, 6 Sep 2021 14:59:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Language: en-US X-ClientProxiedBy: PR0P264CA0288.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::36) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7171f000-7582-4922-d127-08d97136349e X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wklRinhSRVpDYvJdmegP10VvhuZJ/azd6SK3EM0JRoO+jeONCwEo0dDrPHZIuQDrxm31/i3doby2IO5X3Wz68ierdfXcSEQM2b1PfiWoOmdmpUqO+6Oi03hx01V0Eo6076ekcEruFFs4nxaAbfG5zttp/Y/N4OJSmiY7ON7Z8UlRomzcDiWYsd4cO02iRWeIb0oJEQiAKz3YSsgpkDBoABzVH2N6/OzjzKNjFLnhVPvddGwkOn/Dd8tij4ivx3BaLAmWM+UVlCVgSONrteD0Xertv70pBHzmFKTjmKlyilsJvsnbL1hswMy4m/7yzCahsRflgR0HKzcUii8TplJ501Nwe4EIDsQfYy2tsPWfJZDjEYQKQvvEZBstvNfexOmA1z6O8oqTOPZegnxl2mIkOQNz4B/LU6Q5CvnMfanNE8MmrDOmbejoWYX/dA9YCrjxaKZKjeuUDhkZPS+PTlOs6jRKke0xOy4FkA+c74HRnfIOVYl9RZkoe9SeMhT8ftCWHnYgMcTBbhV8pMtYhtXg8GMdw/5oNRmk1yUFURpWsPN6wL6YyPf9JQ6lqjaS45Skf4pCWP6emhg5ORp4CcytYlwwIF0wfU3w4cmADcR5BKnI8oLy4p0uuLLtKAtK4YIIAzzRzFjdHiGwTYy2ukJpPTBFn9qjiBMS1lyB4S4YK9JRh8pSndGvuwK6PL+fHSpVLmUh/g4RWA5QTvEAJqlS6Bt8ORLpgHHUMVQDcWzSPwc/sudAHLc8DanABn8qZWic X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(346002)(396003)(39860400002)(376002)(16576012)(54906003)(478600001)(316002)(6916009)(2906002)(31696002)(66476007)(8676002)(186003)(8936002)(26005)(5660300002)(4326008)(6486002)(956004)(31686004)(66946007)(38100700002)(36756003)(86362001)(2616005)(83380400001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Z7JEWCPufOWe6iIqoSzJ2RMxyrNy?= =?utf-8?q?MbcV++vOwqQQNJxTEbZnmjK1knh37vmguRiUqPJtTS0+aBJTzbhdkfBn3arEhAjb7?= =?utf-8?q?nmzBF1FdHcibVBGDNaFEF5jnCu6IjKj0PXBZLnPEnLMVYILEIO3qx3fbgeNzIkVih?= =?utf-8?q?bSHPwL1f22pf/eFxz/s+ADhdfUWcJ6P367Tb2tXjLRfS78P1LT9HAsuhHiE9+UM41?= =?utf-8?q?51JLogtmGf7camM3XbmEn1fNIaBxDL/SvLHWlA1+1ztdYKseYsuWDBQ8CkxrXCbel?= =?utf-8?q?zdKc6cHXabmUylvKLzNptDh6yKGKTUEUOIP4mQ9511O2ymjXQZs4xH0vMVpBSFMKj?= =?utf-8?q?iP6rJy17GYPUiHiMbS0HB8AeszOeSvx9IuQ7urBoE2MGOORkayWV8LQx/gTybUP+5?= =?utf-8?q?SPQR9t5Qjf3lgw5xSDPMeMjw/kg5SRQjToAPaOxoAB+GYKLWvcnAz4qw+s2vuNVx3?= =?utf-8?q?NFMUVh4mcBLBhArQBncyDWj2oXqMcqQOyWF27gUDtSehwXMN8ytGWMnLWGoj5hRN0?= =?utf-8?q?Ad41AhcIndbHieyOcY23QfGcDyoR0zP2/UJYqAtRYIANNvsBJT0vKv1OEp2CX9R3N?= =?utf-8?q?YYXkOfb7U8i0KZnG+zHc1BaOSw8CQFkmp2EFVX/J8mP5eYPUKrdXOtcAq6Y61JE3x?= =?utf-8?q?woMl3hoVjephhMGGVr9Hk0s4ACDDxSgebvejVKtEF9cZB4K/QDuEmfTalrnhrCXeV?= =?utf-8?q?EANP70ut+EZyWydwT5TY0AJVcV4ePE7l3gFYg8TB/ETPAgWsz3ZU4dDkb2bazS7Ax?= =?utf-8?q?doZNNXhwAu2WrsoJHt8eP7PiuRofkkSLmXu/3ayVk6r/j+fj6jrfNbcKW8Ooxtwc8?= =?utf-8?q?RJb8Jq/UsM33ES34ertPpPBfjnUld2ZZFoEUU2OwlKPCOTW+a+HmD27etnuqmvTmy?= =?utf-8?q?9bJ9IsO5xEz3ZrJMEKXAnGK3cKcMECtZTiDDpUyTQ59T7FCZeaptSsUMoBXjvok4j?= =?utf-8?q?7Ly2fF44oyAd8ssBqsGsaMvThMl+h9pStMF+daoAbABDTxyLC572B1LYZ2RL9v081?= =?utf-8?q?unYiNf12ba+rjMVsiRSmjHGCb6unI1RS5xzaTtmmOvFAmHqepzzfutIRAslABSP3N?= =?utf-8?q?6h9+4u9S0HtGmg9cqaTx1MVvZIaBloLy7a957MK3fAVvfUCTA2hCp1DMXoWtXYFTO?= =?utf-8?q?zGekVU2wSWf4q4uYxcXdi4f4UM48r2oUHzT5BjElOLVXs4vXzdztWvNWF8f9KLSZz?= =?utf-8?q?Ai1/A+Ivr6E+hYIRaPNv8jw32EcULdQOLeT9ME5+9/PI9XIL1uEwWqncUrWy/aSwU?= =?utf-8?q?36jrDd1X1UsZNY4Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7171f000-7582-4922-d127-08d97136349e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 12:59:47.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HqSobVfJ3c2p3fXDjWInCq+5ruoGY8x9/vU4bs9CSCmzW2E0UsiD53GkKIhd4o6HQl1fd2aqdwkm16KZmow+PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533 From: Alexander Monakov Intel SDM does not explicitly say that entering a C-state via MWAIT will implicitly flush CPU caches as appropriate for that C-state. However, documentation for individual Intel CPU generations does mention this behavior. Since intel_idle binds to any Intel CPU with MWAIT, list this assumption of MWAIT behavior. In passing, reword opening comment to make it clear that the driver can load on any old and future Intel CPU with MWAIT. Signed-off-by: Alexander Monakov Signed-off-by: Rafael J. Wysocki [Linux commit: 8bb2e2a887afdf8a39e68fa0dccf82a168aae655] Dropped "reword opending comment" part - this doesn't apply to our code: First thing mwait_idle_probe() does is call x86_match_cpu(); we do not have a 2nd such call looking for just MWAIT (in order to the use _CST data directly, which we can't get our hands at _CST at this point yet). Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -31,6 +31,10 @@ * * Chipset BM_STS (bus master status) bit is a NOP * for preventing entry into deep C-states + * + * CPU will flush caches as needed when entering a C-state via MWAIT + * (in contrast to entering ACPI C3, in which case the WBINVD + * instruction needs to be executed to flush the caches) */ /*