From patchwork Mon Apr 11 09:37:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12808750 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56E67C433F5 for ; Mon, 11 Apr 2022 09:37:51 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.302782.516548 (Exim 4.92) (envelope-from ) id 1ndqUJ-0008Qs-UQ; Mon, 11 Apr 2022 09:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 302782.516548; Mon, 11 Apr 2022 09:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ndqUJ-0008Ql-RJ; Mon, 11 Apr 2022 09:37:35 +0000 Received: by outflank-mailman (input) for mailman id 302782; Mon, 11 Apr 2022 09:37:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ndqUI-0007jK-Jw for xen-devel@lists.xenproject.org; Mon, 11 Apr 2022 09:37:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe4d3d03-b97a-11ec-8fbc-03012f2f19d4; Mon, 11 Apr 2022 11:37:24 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-9BhgKYcINt2V84FTkllM0Q-1; Mon, 11 Apr 2022 11:37:31 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by HE1PR0401MB2457.eurprd04.prod.outlook.com (2603:10a6:3:7e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 09:37:29 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022 09:37:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe4d3d03-b97a-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1649669853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QrdD3qAeqW/aeTb5B3y1/J7DaT6w+fqGApWyQhpbnKk=; b=Nsv4TpZZr04QG1PdRx/z7EXlQMT263BHa6QTRvBR4muAEtoKPyRxjdQBNiz0Yb3pF4LBWA XbpfWnFF6n45yl4cACpQ+D1+UdgpVJ7l4jY+KuES3OclT1NoYD4sCN9Gj0a9yM4UdrpL9Z CaXDTecY+qsbAsXER+PEXaFQF0UlRsU= X-MC-Unique: 9BhgKYcINt2V84FTkllM0Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QgTBgvpR63PNgKhgJ0nQKAd5MNxT7StX6ijlbl1NRG+6QIkeYLqhFfra5FH08k7x2bmvf0PGXfVCKXkz3pjoHkIb+zWY7ateUxnjA+ymQpVPHpbF9qufg4QckXstczQszcY8kqxfzpeLxHvVg+kGOipUkOLWlRRaEqkDYE1cBKSvkSehBBTiSn+TKIItllYUK0qcg2iQ2GR8zsrB87JQ9kq1EV5yq+MboqiuPJJEQn9NnEKCadIHpC9Z1dHErM0ejiTvSFXkjyk1qBSiD7lI/+RZTTZUc9xEYju5n5LDozp01AbCStk3ufDWMoQ+BVWJHtUwJoJt57NnLPFLxCzL/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QrdD3qAeqW/aeTb5B3y1/J7DaT6w+fqGApWyQhpbnKk=; b=VlYb5LIF8UwdTDCtiRgc1LPc2FbVRjVOylJ5KlfpT5RkDQ/SzFGPNZFArsexdwX+jas2xFwEWU+WAgW6U21geCeJyGojYMsBOftKG2pyE/MS7MEFSveVXj+kQJNZVbADyIQoMwrHTM3PJcBUAfrxOo45sKysxft9XiiQi311vFt5fT6gsBIsbJ8vspi9GQTz55yX1le7mO1oJ98uWbZjuyXW4CCsCIFKRk+8x7PuVQ63p0VLBhPx4WxdUqyrA8ffkVp1SAoL6HQ/tVti8mSalFf+9g0t9p6exe6eFx0+PAza1r78KBu2gRv0+i0rqbSNT76DTgeRaGXVPuFocoqWoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0f7136ae-0b52-431d-f789-4b7d5bbecb25@suse.com> Date: Mon, 11 Apr 2022 11:37:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Paul Durrant , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com> In-Reply-To: <4785ba7d-8759-7441-4ac8-0866489707b6@suse.com> X-ClientProxiedBy: AM6PR0202CA0071.eurprd02.prod.outlook.com (2603:10a6:20b:3a::48) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7abd9412-85f7-45ca-ae8b-08da1b9ee57f X-MS-TrafficTypeDiagnostic: HE1PR0401MB2457:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SCt/YgoSKOkcgOM8H8+RLNmkPEZwpkNbY+RwjDd3CCqlkAEPRxR1MbznBlArG7Ck0khu19MmfxLYogLhUzLXuwaCA9GHFYwqFAVbZB5it5wIna1shzUUHAIsjNHw2a3dFRkd0wWKwdhtqCfuy8EEW3ynvheAVpeAf49eVEPCqzHHHgl+WhoeizHnqsPT0llSzXFeV75Cum4HsaePI/iy8r5bnHE3/10qFd4MhJ5SPCsxVdFcz6acvxhfJcCLJE7RrqMUImAo+PehD4ym1Q13HuTQNtnL+BzTmu/ZhCsT8Bzuhy+eR/vfpVDlvDPhX22jhgKLe8tZDwPOgUkNGbaN4VyiETnp1sZk0ZRr1QY9k89OG4FZPwAgl8Un6N++CYyCV+pob7NkMfiZWKyV6eCYn/9jiG++uLKh7YZJBALjbbfqJs3CMmdNbIMi/DMcYf/NzZtpov/zui0Xj3F79LIn8ammU3O3iXqMrhFFHA5okmZWYvxZgTml7Vg3vK9ZYB5GWcBIBwwS6jGgsmg9Pytu4kig0yEROdtDpFZqLSQVZnctAIyMs7VzYNC1bBlRCLiHOB4GqtUlUG+He6PgqXN6FmglKOTfJwNtfF1vm/G303fIea1pusvf+k3d2UU+rD54frGCAFe/II2zTX+iTpH5PKhqkTqrZ0PXMPPdsWOiTA8VitX19yyfAOyT/ZhSt1PmP97xLzVIG3VoMuPdcoKeu874RQMlGDOcA/o+2eFegHlUPy2kX8VnDFWQSyJy0HZz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(8676002)(31696002)(5660300002)(6916009)(66476007)(66556008)(4326008)(8936002)(316002)(86362001)(6512007)(6506007)(186003)(6486002)(38100700002)(2616005)(26005)(54906003)(508600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?pmcfJ07bbAgktId2oJQU0C3L+y6k?= =?utf-8?q?1TiBS4WRLCI4tYBr6U0iyyOFjkSH2Be2a+ZM9Q/U18rOkZnJ1Y0SQxk8bGsQTxCkp?= =?utf-8?q?/Bi8fdg5U5gET++d4zLXT7Dw+0Xkxxh9tkuA6CAhry1HLy4+hSaQUja+BWogUqX2a?= =?utf-8?q?PT4giK8VaJyS3Dx3wj2UzwwaMqVVTbv/yVPD60OctSNUrgeTyTWTMyYWEYCiDpd6O?= =?utf-8?q?3PKTByqTQrAxsP0j3uAtPzfiOhvL+Ny8JVsgHluOkSkUHy2FPj69s3kJot84ark9w?= =?utf-8?q?6sNQ3R+5x7V2SwsHsYLyY5bjYZyFVtBJoEuq9T/aHGcjyJ+GOsRdVxKvQFVgCcEJL?= =?utf-8?q?vdpbQEeBhg2ZOJeWQGLpZR9BVZ/r7L+U6SNFIUl6BbTObG8YsG8uH/RRLbFsbh3Ap?= =?utf-8?q?iuiP0oQ79gwu9pCIaXDvW9Psi65j90LL3ilNXrJeI9YwxzE+tgdwo+AFyGl0H2ByS?= =?utf-8?q?+R9a0aMWQzCwWTghzwEekTct+8Aimj2WY22zQv1ROwen1wsEkLaQArAdPur49kQeU?= =?utf-8?q?92ttt0s15IMiSMRKuCLAizwAL5F7oAP/Ocezg4WRahcqMF8fCqUqoaoR7wb0tFNoO?= =?utf-8?q?+eGzjkS4khzHKWPjcPa30pypMKcDmo90pHoWwch86mlwQXjBkL7JQ3g2210npUgsg?= =?utf-8?q?5Yj2EW3ZlG4fTdu19NsV5VEXntX7RVVXkyvPwIEJaVFPsMkI5zQzzzFjRvpb/vutz?= =?utf-8?q?yZiiNEegprm/TokA8O+2AORCjqMEliwCSkI+dAs/qEpJ3OcqDcuPzN3eadsjEgX8+?= =?utf-8?q?ftSKPuLGSgvWINU771AMDUM4/RQmp9ZVU1AZyr8MCElMxLoWujiNQMPKzaPWcKfMK?= =?utf-8?q?r4pgxyOwYEKSBUvEj0EySQSJgUJDYCidjTlbulGjCJmQXUE7wNY5KeL9MdKd5Ml4A?= =?utf-8?q?rqPkN7RXIOiiVAdJOpiwFn58U1oSI9tpvsPAQn4A0+VUVfo0afWmcztey03wj/ScY?= =?utf-8?q?O4kNSs/cKkSVULLN4IuUSiiuNLpQDp04cj2VWePT+7qprkS2CSNarVjWKhrkduZ7b?= =?utf-8?q?cBlobSMbAfdJIJXEd/inHEIz7ChJ8CBrJvMscnBtsez3DEI9CY331AGdzCZT3LcCk?= =?utf-8?q?eDIObZKv/iR+LYFUZJ9Yl38asWUjGFIADLgvlWD/iGIAwHsFdRQKlWb+aWCzrj0LV?= =?utf-8?q?th18RnzVMVwTYBxIIvJwBXpveyUrdmvIh+NcWjxG8xnxOq2ZsRPubcgHpHs+9rXOE?= =?utf-8?q?Cx3u/JTD13sT0k8AAXJDPeJ0C8zWOVcgpGRI6M+feogqrOPnMWCGrL5VeC3KJja/s?= =?utf-8?q?7gi1PaHs7PZoqHVHbIr9+Pz/yUbgiEAIVeCgg0RED+JF1LUWKfsMsjBvO7UjULbKS?= =?utf-8?q?yvlLr1z8kzKwKcKB2FOWdMSBZWwRTBoJ6r9mOIrTizddHaWqMhLwqwNCeCaRHMzMK?= =?utf-8?q?pqn8UMCLLx1q9wtTryCw0gcKfOLU8E7q+amdX+sffVo9I88uir/zquff5FEiAvSgC?= =?utf-8?q?jJbqvw078egMTrofsTQqRpkRqNMgFMB/Go9MyLii30PMluT70e/d/fmvMxLsKe4aL?= =?utf-8?q?cGxBf+74dV3b2TuBTjZQQ7jnLC81yS/ITtVtqyuZUqUfHLY/jSXJ5NHJG3bjqwSsn?= =?utf-8?q?tngRxDWrnZLqCvNzaaMRTlYX5UwEdtEOhtXQ6BRJNaEBeJ/9NEIrTX2NdCz5pv8Jr?= =?utf-8?q?Xjwqkf8vm9//EQdFN/tqeKXRoVdOVJ0g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7abd9412-85f7-45ca-ae8b-08da1b9ee57f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 09:37:29.6416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hr5IiKLGI3vwuvaSQiQlW+2mYDtoj7/YEruIeyH94txpuARHuldh2CqNVP+HBwsxN1f1BV0TqoMqXWtW+l+j1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2457 The field taking the value 7 (resulting in 18-bit DIDs when using the calculation in cap_ndoms(), when the DID fields are only 16 bits wide) is reserved. Instead of misbehaving in case we would encounter such an IOMMU, refuse to use it. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Kevin Tian --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -1267,8 +1267,11 @@ int __init iommu_alloc(struct acpi_drhd_ quirk_iommu_caps(iommu); + nr_dom = cap_ndoms(iommu->cap); + if ( cap_fault_reg_offset(iommu->cap) + cap_num_fault_regs(iommu->cap) * PRIMARY_FAULT_REG_LEN > PAGE_SIZE || + ((nr_dom - 1) >> 16) /* I.e. cap.nd > 6 */ || (has_register_based_invalidation(iommu) && ecap_iotlb_offset(iommu->ecap) >= PAGE_SIZE) ) { @@ -1294,8 +1297,6 @@ int __init iommu_alloc(struct acpi_drhd_ if ( !ecap_coherent(iommu->ecap) ) iommu_non_coherent = true; - nr_dom = cap_ndoms(iommu->cap); - if ( nr_dom <= DOMID_MASK * 2 + cap_caching_mode(iommu->cap) ) { /* Allocate domain id (bit) maps. */