From patchwork Tue Sep 10 10:09:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13798267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEDDAECE564 for ; Tue, 10 Sep 2024 10:09:30 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.795241.1204529 (Exim 4.92) (envelope-from ) id 1snxoI-0008VL-AZ; Tue, 10 Sep 2024 10:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 795241.1204529; Tue, 10 Sep 2024 10:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1snxoH-0008SZ-NF; Tue, 10 Sep 2024 10:09:21 +0000 Received: by outflank-mailman (input) for mailman id 795241; Tue, 10 Sep 2024 10:09:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1snxoG-0006in-7K for xen-devel@lists.xenproject.org; Tue, 10 Sep 2024 10:09:20 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bccaf5ba-6f5c-11ef-99a1-01e77a169b0f; Tue, 10 Sep 2024 12:09:16 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-79-37-206-90.retail.telecomitalia.it [79.37.206.90]) by support.bugseng.com (Postfix) with ESMTPSA id 4BEED4EE07BE; Tue, 10 Sep 2024 12:09:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bccaf5ba-6f5c-11ef-99a1-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1725962956; bh=uy8RzmNPWe8sN7uF0NONIzcrXeo4qTykXjJvLpaUdFY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j9uWRD21docJyr5AGSepOo5zOUTZXlr3xMf3M7p44ORvblAyhRkDy/i40/WvA6RJs DMPUGn2NUqw7aIFJIEQ1wuzYpNdX+xQZMn/TR5XEPeiTvDbEq+ZLxRLYqqV1YuItwJ ShLhJxrCVN9TUNNd3/H/pFF89yQ7kK8dm3n9OUD2YIiNPM7YAsdv0k3nkt+K+c65oZ WpKPHKSi7pqUXzO9mLnZzlz8jCj9MKK3OyxtoSaWuYziEZhRQLp7VSPqW1SMJy1E+k FAcV70IXvs3Sxo8uve2NyblWLFCtKy7lOMqrh5ycQVV9LZF0Y45VwvCFPX8irrgSzX ZvMmh2yFbLm8w== From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [XEN PATCH 09/12] x86/emul: address violations of MISRA C Rule 16.3 Date: Tue, 10 Sep 2024 12:09:01 +0200 Message-Id: <0fa68b9aee5a7a3f1b696bfc6b18ecc826663212.1725958417.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Address violations of MISRA C:2012 Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/x86_emulate/fpu.c | 4 ++++ xen/arch/x86/x86_emulate/x86_emulate.c | 1 + 2 files changed, 5 insertions(+) diff --git a/xen/arch/x86/x86_emulate/fpu.c b/xen/arch/x86/x86_emulate/fpu.c index 480d879657..3351f549e7 100644 --- a/xen/arch/x86/x86_emulate/fpu.c +++ b/xen/arch/x86/x86_emulate/fpu.c @@ -218,6 +218,7 @@ int x86emul_fpu(struct x86_emulate_state *s, */ if ( dst->type == OP_MEM && !s->fpu_ctrl && !fpu_check_write() ) dst->type = OP_NONE; + break; } break; @@ -296,6 +297,7 @@ int x86emul_fpu(struct x86_emulate_state *s, default: generate_exception(X86_EXC_UD); } + break; } break; @@ -386,6 +388,7 @@ int x86emul_fpu(struct x86_emulate_state *s, */ if ( dst->type == OP_MEM && !s->fpu_ctrl && !fpu_check_write() ) dst->type = OP_NONE; + break; } break; @@ -457,6 +460,7 @@ int x86emul_fpu(struct x86_emulate_state *s, case 7: /* fistp m64i */ goto fpu_memdst64; } + break; } break; diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index 2b03d65fce..9fb316e0d7 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -8297,6 +8297,7 @@ x86_emulate( } if ( rc != 0 ) goto done; + break; default: break; }