| Message ID | 1158df1cde660e817c4f6d6e0a46ef22bd92dc04.1685027257.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | enable MMU for RISC-V | expand |
On Thu, May 25, 2023 at 06:28:16PM +0300, Oleksii Kurochko wrote: > bss clear cycle requires proper alignment of __bss_start. > > ALIGN(PAGE_SIZE) before "*(.bss.page_aligned)" in xen.lds.S > was removed as any contribution to "*(.bss.page_aligned)" have to > specify proper aligntment themselves. > > Fixes: cfa0409f7cbb ("xen/riscv: initialize .bss section") > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > Reviewed-by: Jan Beulich <jbeulich@suse.com> > --- > Changes in V9: > * Nothing changed. Only rebase. > --- > Changes in V8: > * Remove ". = ALIGN(PAGE_SIZE);" before "*(.bss.page_aligned)" in > vmlinux.lds.S file as any contribution to .bss.page_aligned have to specify > proper alignment themselves. > * Add "Fixes: cfa0409f7cbb ("xen/riscv: initialize .bss section")" to > the commit message > * Add "Reviewed-by: Jan Beulich <jbeulich@suse.com>" to the commit message > --- > Changes in V7: > * the patch was introduced in the current patch series. > --- > xen/arch/riscv/xen.lds.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S > index fe475d096d..df71d31e17 100644 > --- a/xen/arch/riscv/xen.lds.S > +++ b/xen/arch/riscv/xen.lds.S > @@ -137,9 +137,9 @@ SECTIONS > __init_end = .; > > .bss : { /* BSS */ > + . = ALIGN(POINTER_ALIGN); > __bss_start = .; > *(.bss.stack_aligned) > - . = ALIGN(PAGE_SIZE); > *(.bss.page_aligned) > . = ALIGN(PAGE_SIZE); > __per_cpu_start = .; > -- > 2.40.1 > > Acked-by: Bobby Eshleman <bobbyeshleman@gmail.com>
diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index fe475d096d..df71d31e17 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -137,9 +137,9 @@ SECTIONS __init_end = .; .bss : { /* BSS */ + . = ALIGN(POINTER_ALIGN); __bss_start = .; *(.bss.stack_aligned) - . = ALIGN(PAGE_SIZE); *(.bss.page_aligned) . = ALIGN(PAGE_SIZE); __per_cpu_start = .;
bss clear cycle requires proper alignment of __bss_start. ALIGN(PAGE_SIZE) before "*(.bss.page_aligned)" in xen.lds.S was removed as any contribution to "*(.bss.page_aligned)" have to specify proper aligntment themselves. Fixes: cfa0409f7cbb ("xen/riscv: initialize .bss section") Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> --- Changes in V9: * Nothing changed. Only rebase. --- Changes in V8: * Remove ". = ALIGN(PAGE_SIZE);" before "*(.bss.page_aligned)" in vmlinux.lds.S file as any contribution to .bss.page_aligned have to specify proper alignment themselves. * Add "Fixes: cfa0409f7cbb ("xen/riscv: initialize .bss section")" to the commit message * Add "Reviewed-by: Jan Beulich <jbeulich@suse.com>" to the commit message --- Changes in V7: * the patch was introduced in the current patch series. --- xen/arch/riscv/xen.lds.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)